- Koha-bugs - lists.koha-community.org

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #104 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- I think this has gone through enough testing and enough hands now to push it through QA. I'm happy with the final results and code and whilst I'd love to add some signoff lines to this, I have no doubt it's in use in production at inLibro already, and I'm taking Hammat's continuation of my proposed alternative as agreement of that approach. Passing QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #103 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185827&action=e… Bug 9762: (follow-up) Add integration tests and improve AddRenewal logging consistency This commit adds two key improvements to the Bug 9762 circulation override logging: 1. **Consistent JSON Logging**: Updated AddRenewal to always log in JSON format, matching AddIssue behavior. Previously AddRenewal only logged JSON when confirmations/forced were present, otherwise logged just the item number. 2. **Integration Tests**: Added comprehensive tests for both AddIssue and AddRenewal JSON logging functionality: - Test normal operations (empty confirmations/forced arrays) - Test override operations (populated confirmations/forced arrays) - Verify JSON structure and content accuracy The AddRenewal function now consistently logs: ```json { "issue": 123, "itemnumber": 456, "confirmations": [...], "forced": [...] } ``` This ensures uniform action log format across all circulation operations and provides better integration test coverage for the override logging functionality. Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #102 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185826&action=e… Bug 9762: (follow-up) Fix failing Circulation.t test The test was failing with RegisterRequired exception because payin_amount() requires a cash register when UseCashRegisters preference is enabled. Fixed by setting UseCashRegisters to 0 in the lost item return policies test to allow payments without requiring a cash register. Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #101 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185825&action=e… Bug 9762: (follow-up) Fix failing CanBookBeIssued test The test was failing because: 1. IssuingInProcess preference was not explicitly set, affecting the code path for message logging 2. The patron category had a random noissuescharge value that overrode the system preference Fixed by: - Setting IssuingInProcess to 0 to ensure correct code path - Setting patron category noissuescharge to undef to use system preference Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185323|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185824&action=e… Bug 9762: (follow-up) Add branchcode to Log circulation and add some override confirmations in action logs, fix typos Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185322|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185823&action=e… Bug 9762: (Alternative) Handle renewals Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185321|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185822&action=e… Bug 9762: (Alternative) Log circulation overrides An alternative approach to the original submission for bug 9762. Instead of recording a distinct action log line for a set of override messages in addition to the standard issue record, this patch updates the existing issue log to include any confirmation or impossible responses from the preceeding CanBookBeIssued call. We continue to record these as a JSON structure as the prior patch did, but instead of human messages we use the predefined codes as returned from the existing CanBookBeIssued response. To test: After each step, a single action log message should be displayed under `Tools > Log viewer`. The message itself will now consist of a JSON string with an array of 'confirmations' and 'forced' strings representing the overriden feedback from CanBookBeIssued. Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185320|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185821&action=e… Bug 9762: (QA follow-up) Remove superflous string construction We never actually pass `$message` back to anywhere so there's no reason to create it in the first place. Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185319|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185820&action=e… Bug 9762: (QA follow-up) Fix failing test Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '25

27 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185318|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 185819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185819&action=e… Bug 9762: (QA follow-up) Add missing issueconfirmed check Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0