- Koha-bugs - lists.koha-community.org

[Bug 17217] New: Allow to reserve first available item from a group of titles (OPAC)
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217 Bug ID: 17217 Summary: Allow to reserve first available item from a group of titles (OPAC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 15516 This bug follows bug 15516. This is the OPAC part Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to reserve first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 27300] New: Create a hold group for multiple items in one record
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 Bug ID: 27300 Summary: Create a hold group for multiple items in one record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Some libraries want to be able to create a hold group for multiple items in one record. (There could be a variety of reasons relating to location, itype, etc.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Pedro Amorim <pedro.amorim(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17217, 27300 | --- Comment #494 from Pedro Amorim <pedro.amorim(a)openfifth.co.uk> --- Removing bug 17217 and bug 27300 as blocked bugs as those have been considered duplicates instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217 [Bug 17217] Allow to reserve first available item from a group of titles (OPAC) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 [Bug 27300] Create a hold group for multiple items in one record in staff interface -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15851] New: "Analytics: Show analytics" showing regardless of whether they have analytics.
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Bug ID: 15851 Summary: "Analytics: Show analytics" showing regardless of whether they have analytics. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: ed.veal(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl All of records where position 7 of the leader indicates serial automatically display "Analytics: Show analytics" -- regardless of whether they have analytics. To confirm, we linked numerous items to host records in the case where monographic volumes were bound together via the "Link to Host Item" feature, automatically creating 773s. These are not in question and we do not want to make any changes that would affect them. The request is to remove the display "Analytics: Show analytics" for periodical records that do not have analytics. -- You are receiving this mail because: You are watching all bug changes.

1 112

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #493 from Pedro Amorim <pedro.amorim(a)openfifth.co.uk> --- (In reply to David Cook from comment #488) > (In reply to Pedro Amorim from comment #486) > > - Staff: Hold group modal (when clicking the "(part of a hold group link)") > > contains out of date UI elements styling > > How do you mean? (I'll take a look at other modals for inspiration while I > wait to hear back.) Looks good and works as expected now after the additional patches. > > - Staff: Created a hold group searching 'music' and picking 1st and 3rd > > records. After checking in one item of a hold group and confirming, the item > > became in transit, the other hold was not deleted (I would expect it to be > > deleted as per the test plan) > > I'm not able to reproduce this. I thought that I did reproduce it... but it > was just because I forgot to checkbox the "hold group" box. Fresh k-t-d, all patches applied, reset_all (DisplayAddHoldGroups already enabled): 1) Search for 'music': http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=music 2) Select the checkbox on the 1st record (Nordic roots) and 3rd record (Clothes, clothes...) 3) Click the 'Place hold' button 4) Search for 'koha (42)' user. Pick that. 5) Check the 'treat as hold group' checkbox 6) Select the pickup locations 'Fairfield' for Nordic root, 'Fairview' for Clothes, clothes... Click 'Place holds'. 7) Visit the user page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 8) Notice the holds tab marks '1' hold (considering the hold group as one hold) but lists both holds, with each having the 'part of a hold group' link. 9) Check-in an item of 'Nordic roots': 39999000003154 10) Click 'Confirm hold and transfer'. 11) Repeat 7) Notice both holds are still present. I would expect the 'Clothes, clothes...' hold to have been deleted now that the hold group has been satisfied. > > - OPAC: Using koha:koha user in ktd, when creating a hold group from the > > OPAC, following the "Gairm" and "Clean code" example, I get the following > > error message: > > # One or more holds were not placed due to following errors: You have > > exceeded the number of concurrent holds for this record > > But if I place both holds without ticking the 'treat as hold group' > > checkbox, both holds are correctly placed. > > I was unable to follow the rest of the OPAC test plan. > > Ok I've reproduced this. It's one of those examples of something I've fixed > locally in production but hadn't fixed in the Bugzilla patches... I'll get > that fixed. Simple fix. Can't reproduce anymore. Works as described on the test plan. > > - Staff: As above, when doing the same exercise on Staff UI, only 'Clean > > code' hold goes through, 'Gairm' hold is never created. No error message > > shown. > > This is very weird. I just re-tried the test plan again and it worked for > both the OPAC and Staff interface. Are you sure that you applied the patch, > updated the schema, and restarted your Starman? Can't reproduce anymore. Works as described on the test plan. Note that the test plan works if the checked in item is to be picked up at the same library as the patron. Checked in ttem becomes 'waiting'. The other hold in the hold group is deleted. As per my instructions above, for both Staff and OPAC, if the item that satisfied the hold group becomes "In transit", the other hold in the hold group is not deleted. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #492 from David Cook <dcook(a)prosentient.com.au> --- Unfortunately, I've run out of time for uploading the code for the detail page work, but I can look at that again next week... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #491 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 183915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183915&action=e… Bug 15516: (follow-up) Fix some merge bugs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #490 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #488) > (In reply to Pedro Amorim from comment #486) > > - Staff: Hold group modal (when clicking the "(part of a hold group link)") > > contains out of date UI elements styling > > How do you mean? (I'll take a look at other modals for inspiration while I > wait to hear back.) I'm comparing "koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc" to the modals in "koha-tmpl/intranet-tmpl/prog/en/includes/modals". Unfortunately, not sure what you mean here. > > - Staff: Hold group modal 'x' and 'close' button don't work. > > Yep, known issue. I'll look at fixing that. Fixed in next patch upload. > > - Staff: After the above, when visiting the holds queue page, I get a 500 > > error with the following entry on the logs: > > # Not an ARRAY reference at /kohadevbox/koha/circ/view_holdsqueue.pl line 58. > > Yep known issue. (It works locally so I'll have to investigate why it works > locally. ) Locally, we've just removed support for "(part of a hold group link)" in http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl because the table there is from the tmp_holdsqueue table and hold_group_id is not a column in that table. I'm going to do the same thing in the next patch upload, but this might need a better solution. In practice, the lack of support here hasn't been an issue for the library using this feature. > > - OPAC: Using koha:koha user in ktd, when creating a hold group from the > > OPAC, following the "Gairm" and "Clean code" example, I get the following > > error message: > > # One or more holds were not placed due to following errors: You have > > exceeded the number of concurrent holds for this record > > But if I place both holds without ticking the 'treat as hold group' > > checkbox, both holds are correctly placed. > > I was unable to follow the rest of the OPAC test plan. Fixed in next patch upload. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #489 from David Cook <dcook(a)prosentient.com.au> --- Additional note: 1. At http://localhost:8080/cgi-bin/koha/opac-user.pl?&opac-user-holds=1 if you click on "(part of a hold group)" it doesn't open in a modal. It just shows in the "Title" table cell which looks weird. I guess this isn't a bug so much as a suboptimal part of the feature. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #488 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Pedro Amorim from comment #486) > - Staff: Hold group modal (when clicking the "(part of a hold group link)") > contains out of date UI elements styling How do you mean? (I'll take a look at other modals for inspiration while I wait to hear back.) > - Staff: Hold group modal 'x' and 'close' button don't work. Yep, known issue. I'll look at fixing that. > - Staff: Created a hold group searching 'music' and picking 1st and 3rd > records. After checking in one item of a hold group and confirming, the item > became in transit, the other hold was not deleted (I would expect it to be > deleted as per the test plan) I'm not able to reproduce this. I thought that I did reproduce it... but it was just because I forgot to checkbox the "hold group" box. > - Staff: After the above, when visiting the holds queue page, I get a 500 > error with the following entry on the logs: > # Not an ARRAY reference at /kohadevbox/koha/circ/view_holdsqueue.pl line 58. Yep known issue. (It works locally so I'll have to investigate why it works locally. ) > - OPAC: Using koha:koha user in ktd, when creating a hold group from the > OPAC, following the "Gairm" and "Clean code" example, I get the following > error message: > # One or more holds were not placed due to following errors: You have > exceeded the number of concurrent holds for this record > But if I place both holds without ticking the 'treat as hold group' > checkbox, both holds are correctly placed. > I was unable to follow the rest of the OPAC test plan. Ok I've reproduced this. It's one of those examples of something I've fixed locally in production but hadn't fixed in the Bugzilla patches... I'll get that fixed. Simple fix. > - Staff: As above, when doing the same exercise on Staff UI, only 'Clean > code' hold goes through, 'Gairm' hold is never created. No error message > shown. This is very weird. I just re-tried the test plan again and it worked for both the OPAC and Staff interface. Are you sure that you applied the patch, updated the schema, and restarted your Starman? -- You are receiving this mail because: You are watching all bug changes.

1 0