June 2012 - Koha-bugs - lists.koha-community.org

[Bug 8017] New: Remove unnecessary processing on return of GetAllIssues
by bugzilla-daemon＠bugs.koha-community.org 15 Sep '12

15 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Priority: P5 - low Change sponsored?: --- Bug ID: 8017 Assignee: gmcharlt(a)gmail.com Summary: Remove unnecessary processing on return of GetAllIssues QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell(a)ptfs-europe.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha This is potentially a large list used in staff and opac to show a user's circulation history. The routine itself makes an unnecessary iteration over the list to do an inefficient copy and the consumers of the list also loop over and copy the list before the final loop perdormed in instantiating the template. Move unnecessary processing out of the loops (e.g. format dates using the tt custom plugin dont format dates we are not displaying). Don't increase the performabce hit of the routine -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 7225] New: "Delete all items" should be greyed out when a title has no items
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7225 Bug #: 7225 Summary: "Delete all items" should be greyed out when a title has no items Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: ian.walls(a)bywatersolutions.com If a bibliographic record has no items we should not offer the user the option to "delete all items." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 8

[Bug 6375] New: Markup and style corrections for overdue report
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6375 Bug #: 6375 Summary: Markup and style corrections for overdue report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/circ/overdue.pl OS/Version: All Status: ASSIGNED Severity: minor Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org - Use fieldset and legend tags to replace border around date filter - Move parentheses into conditional so they don't appear empty when no phone number exists. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 6

[Bug 8288] New: showmarc.tt should not include full doc-head-close.inc
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Priority: P5 - low Change sponsored?: --- Bug ID: 8288 Assignee: oleonard(a)myacpl.org Summary: showmarc.tt should not include full doc-head-close.inc Severity: minor Classification: Unclassified OS: All Reporter: oleonard(a)myacpl.org Hardware: All Status: NEW Version: master Component: Templates Product: Koha showmarc.tt is only called by modal dialogs for previewing MARC records or card views in acquisitions and cataloging. Since it is a minimal page loaded within a page it doesn't need to load all the CSS and JS a full page does. It also creates the possibility of unintended consequences if you have intranetuserjs triggering something on document load: the event will be triggered again when the dialog loads. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 7227] New: "Delete all items" action should redirect to the detail view, not the items view
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7227 Bug #: 7227 Summary: "Delete all items" action should redirect to the detail view, not the items view Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: ian.walls(a)bywatersolutions.com If you "Delete all items" from the catalog toolbar, upon completion you're redirected to catalogue/moredetail.pl. This doesn't make sense because moredetail.pl is designed to display information about items. If you've deleted all items there's nothing relevant to see. You should instead be redirected to the default biblio view. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 7

[Bug 7616] New: Remove unused template markup for css_libs, css_module, js_libs, etc.
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Bug #: 7616 Summary: Remove unused template markup for css_libs, css_module, js_libs, etc. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: koha.sekjal(a)gmail.com There was a time when it was planned that Koha would automatically load CSS and JS file based on certain contexts. Thus in Auth.pm: # load the template variables for stylesheets and JavaScript $template->param( css_libs => $in->{'css_libs'} ); $template->param( css_module => $in->{'css_module'} ); $template->param( css_page => $in->{'css_page'} ); $template->param( css_widgets => $in->{'css_widgets'} ); $template->param( js_libs => $in->{'js_libs'} ); $template->param( js_module => $in->{'js_module'} ); $template->param( js_page => $in->{'js_page'} ); $template->param( js_widgets => $in->{'js_widgets'} ); *_libs would be general libraries like jQuery and YUI. *_module would be files which were specific to "modules" like circulation or cataloging. *_page would be page-specific files, and *_widgets would be things like the calendar widget I suppose. This method of handling these assets was never implemented and the references to it should be removed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 9

[Bug 7259] New: Show a count of items pending approval on staff client home and tools pages
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 Bug #: 7259 Summary: Show a count of items pending approval on staff client home and tools pages Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: ian.walls(a)bywatersolutions.com CC: gmcharlt(a)gmail.com The staff client home page and tools page should show a count of items which are pending approval: suggestions, comments and tags. Screenshot of the proposed revised interfaces: Staff client home page: http://www.screencast.com/t/PYObAMwHz Tools page: http://www.screencast.com/t/AxewTrBFxUTy -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 15

[Bug 6622] New: Remove closing style tag from staff-global.css
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6622 Bug #: 6622 Summary: Remove closing style tag from staff-global.css Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: minor Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org A </style> is stuck at the end of staff-global.css. Git blames me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 6

[Bug 6980] New: Existing extended patron attributes are shown on patron screens even when ExtendedPatronAttributes is disabled
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6980 Bug #: 6980 Summary: Existing extended patron attributes are shown on patron screens even when ExtendedPatronAttributes is disabled Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 Component: Patrons AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org CC: gmcharlt(a)gmail.com If you have added extended patron attributes but have since turned off the ExtendedPatronAttributes preference those existing attributes will still be displayed in the sidebar of circulation and patron-related pages. The display of these attributes should be controlled by the ExtendedPatronAttributes preference. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 7

[Bug 6337] New: Variable scope errors in staff client cart print view
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '12

14 Sep '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6337 Bug #: 6337 Summary: Variable scope errors in staff client cart print view Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org Some T:T variable scope errors in the staff client cart template cause bad formatting of the print view. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 7