March 2013 - Koha-bugs - lists.koha-community.org

[Bug 8780] New: Lower dependency version for DateTime::TimeZone
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Priority: P5 - low Change sponsored?: --- Bug ID: 8780 Assignee: gmcharlt(a)gmail.com Summary: Lower dependency version for DateTime::TimeZone Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset(a)hotmail.com Hardware: All Status: NEW Version: unspecified Component: Installation and upgrade (command-line installer) Product: Koha A base Debian install of 6.0.5 has a DateTime::TimeZone version 1.20 available (including debian.koha-community.org repositories), but the PerlDependencies.pm says 1.26 After discussions on the IRC channel (http://irc.koha-community.org/irclog/koha/2012-09-17) from 08:50-09:35 and 12:44-13:07, I decided to email Colin Campbell. He replied: "No its a nominal number. Looking through the changes log nearly all changes up to current (1.50) are just updates to reflect data changes in some timezones. We're mainly using it for the timezone names so I think 1.20 will be fine. I think the only reason a number was chosen was because one of the install routines didnt allow us just to say any DateTime::TimeZone Cheers Colin" Given that Colin says it should be okay to lower it to 1.20, and that Wajasu has purposefully tweaked his out since June (almost 3 months), I propose we lower the minimum value to 1.20 from 1.26. This will make git installs under Debian attainable. Test ----- 1) Do a fresh git clone on Debian. 2) cd the clone. 3) sudo apt-get install dselect 4) sudo dpkg --set-selections < install_misc/debian.packages 5) sudo dselect 6) choose I, C, R, and then Q. 7) ./koha_perl_deps.pl -m -u 8) Notice that despite being installed, DateTime::TimeZone is 1.20 vs. the required 1.26 now apply patch 9) ./koha_perl_deps.pl -m -u 10) Notice that DateTime::TimeZone is no longer listed. As for the other items, that can be fixed by running my check_deps.sh script which is in the release-tools repo (I believe), and as such, is another bug report. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 8793] New: Remove references to OPAC icons from NORMARC staff XSLT
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Priority: P5 - low Change sponsored?: --- Bug ID: 8793 CC: gmcharlt(a)gmail.com Assignee: magnus(a)enger.priv.no Summary: Remove references to OPAC icons from NORMARC staff XSLT Severity: minor Classification: Unclassified OS: All Reporter: magnus(a)enger.priv.no Hardware: All Status: ASSIGNED Version: master Component: Staff Client Product: Koha This was first pointed out on Bug 8624. NORMARCslim2intranetDetail.xsl: <xsl:element name="img"><xsl:attribute name="src">/opac-tmpl/prog/famfamfam/<xsl:value-of select="$materialTypeCode"/>.png</xsl:attribute><xsl:attribute name="alt"></xsl:attribute></xsl:element> NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Mon'"><img src="/opac-tmpl/prog/famfamfam/silk/book.png" alt="Bok" title="Bok"/> Bok</xsl:when> <xsl:when test="$typeOf008='Per'"><img src="/opac-tmpl/prog/famfamfam/silk/newspaper.png" alt="Periodika" title="Periodika"/> Periodika</xsl:when> <xsl:when test="$typeOf008='Fil'"><img src="/opac-tmpl/prog/famfamfam/silk/computer_link.png" alt="Fil" title="Fil"/> Fil</xsl:when> <xsl:when test="$typeOf008='Kar'"><img src="/opac-tmpl/prog/famfamfam/silk/map.png" alt="Kart" title="Kart"/> Kart</xsl:when> <xsl:when test="$typeOf008='FV'"><img src="/opac-tmpl/prog/famfamfam/silk/film.png" alt="Film og video" title="Film og video"/> Film og video</xsl:when> <xsl:when test="$typeOf008='Mus'"><img src="/opac-tmpl/prog/famfamfam/silk/sound.png" alt="Musikktrykk og lydopptak" title="Musikktrykk og lydopptak"/> Musikk</xsl:when> MARC21 does not seem to use images like this, so I'll probably just remove them. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 8624] New: famfamfam should be outside theme directory
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Priority: P5 - low Change sponsored?: --- Bug ID: 8624 Assignee: oleonard(a)myacpl.org Summary: famfamfam should be outside theme directory Severity: minor Classification: Unclassified OS: All Reporter: jcamins(a)cpbibliography.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha The famfamfam image set is a standard third-party collection that is not "skinned" for different themes. Therefore, it should be moved outside the theme directory to /koha-tmpl/opac-tmpl/famfamfam/ -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 8606] New: Talking Tech broken by Bug 7001
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Priority: P5 - low Change sponsored?: --- Bug ID: 8606 Assignee: koha-bugs(a)lists.koha-community.org Summary: Talking Tech broken by Bug 7001 Severity: enhancement Classification: Unclassified OS: All Reporter: kyle(a)bywatersolutions.com Hardware: All Status: NEW Version: master Component: Notices Product: Koha The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 7894] New: Broken detail page for first link on page 2 from search result page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7894 Priority: P5 - low Change sponsored?: --- Bug ID: 7894 Assignee: oleonard(a)myacpl.org Summary: Broken detail page for first link on page 2 from search result page in OPAC QA Contact: koha.sekjal(a)gmail.com Severity: blocker Classification: Unclassified OS: All Reporter: arslanone(a)gmail.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Hi, When you search the OPAC, clicking on the 1st result of page 2 always gives this error: ------------------------------------------- "Software error: Can't use string ("00800nam a22002537a 450000100050") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Search.pm line 1493." ------------------------------------------- Screenshot: http://postimage.org/image/ouqivltox/ The error only happens when we search in the OPAC, go to page 2, and click on 1st record. Search a different term and, that will result in some different record on page 2 top, and clicking that record will give same error. Right click and copy the link of that record, and open it by directly pasting in another browser and the record will show properly. Meaning there is nothing wrong with the record itself. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 6151] New: IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Bug #: 6151 Summary: IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: ASSIGNED Severity: major Priority: P5 Component: Circulation AssignedTo: ian.walls(a)bywatersolutions.com ReportedBy: ian.walls(a)bywatersolutions.com QAContact: koha-bugs(a)lists.koha-community.org CC: gmcharlt(a)gmail.com If IndependantBranches is on, and an item is checked into a branch that is not it's current HomeOrHoldBranchReturn branch, a "Wrong Branch" message is given, and the return is denied. This is not always desirable behaviour. For example, some libraries may want an item owned by Branch A but issued from Branch B to be returnable to either A or B (the patron returning the material to A saves the library transit costs), or even to be returnable to Library C if the transit network is robust. More heinous a problem, if an item is issued from Library B, and HomeOrHoldingBranchReturn is set to Homebranch, the patron cannot return the item to Library B. And further, when AutomaticItemReturn is turned on and HomeOrHoldingBranchReturn is HoldingBranch, an item issued from Library B and returned to Library B will not trigger a transfer message to return it to Library A. So, with the two above, if HomeOrHoldingBranchReturn is considered the only adjustable variable (since changing IndependantBranches has many, many consequences, and AutomaticItemReturn is a library policy decision), neither setting will allow for desirable behaviour. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 28

[Bug 8428] New: can't save contracts
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Priority: P5 - low Change sponsored?: --- Bug ID: 8428 Assignee: koha-bugs(a)lists.koha-community.org Summary: can't save contracts Severity: major Classification: Unclassified OS: All Reporter: nengard(a)gmail.com URL: /cgi-bin/koha/admin/aqcontract.pl?op=add_form&booksell erid=1 Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha I'm trying to create a contract and no matter how many times I click the save button nothing happens. I get no errors, no saving, no confirmation, just nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 8598] New: borrower image and home library disappear on Files tab
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Priority: P5 - low Change sponsored?: --- Bug ID: 8598 CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Assignee: koha-bugs(a)lists.koha-community.org Summary: borrower image and home library disappear on Files tab Severity: normal Classification: Unclassified OS: All Reporter: nengard(a)gmail.com URL: /cgi-bin/koha/members/files.pl?borrowernumber=52 Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Created attachment 11451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11451&action=edit patron on all other tabs When looking at patron files the patron's image and home library on the top left disappear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 8761] New: Correct compile time warnings in C4::Circulation
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Priority: P5 - low Change sponsored?: --- Bug ID: 8761 Assignee: gmcharlt(a)gmail.com Summary: Correct compile time warnings in C4::Circulation Severity: minor Classification: Unclassified OS: All Reporter: colin.campbell(a)ptfs-europe.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha A recent enhancement to C4::Circulation has introduced some ambiguous constructs which on current perls give compile time warnings with perl 5.16.0 or 5.16.1 (I've not tested with older) if you check compilation with perl -wc C4/Circulation.pm you get the following warnings Scalar value @values[$take] better written as $values[$take] at Circulation.pm line 985. Scalar value @alloweddate[0] better written as $alloweddate[0] at Circulation.pm line 991. Scalar value @alloweddate[1] better written as $alloweddate[1] at Circulation.pm line 993. Scalar value @alloweddate[2] better written as $alloweddate[2] at Circulation.pm line 993. Scalar value @alloweddate[2] better written as $alloweddate[2] at Circulation.pm line 994. Heres the doc from perlwarn (W syntax) You've used an array slice (indicated by @) to select a single element of an array. Generally it's better to ask for a scalar value (indicated by $). The difference is that $foo[&bar] always behaves like a scalar, both when assigning to it and when evaluating its argument, while @foo[&bar] behaves like a list when you assign to it, and provides a list context to its subscript, which can do weird things if you're expecting only one subscript. On the other hand, if you were actually hoping to treat the array element as a list, you need to look into how references work, because Perl will not magically convert between scalars and lists for you. See perlref. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 8395] New: order receive not sorting right
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '13

21 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395 Priority: P5 - low Change sponsored?: --- Bug ID: 8395 Assignee: koha-bugs(a)lists.koha-community.org Summary: order receive not sorting right Severity: major Classification: Unclassified OS: All Reporter: nengard(a)gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Acquisitions Product: Koha Created attachment 10722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10722&action=edit not sorted See the attached image - when I click on the 'Summary' heading to sort things, they are in no order that I can figure out. They should be in alpha order by title since that's the first bit of data in that field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17