April 2014 - Koha-bugs - lists.koha-community.org

[Bug 10789] New: Excessive and often incorrect use of finish in C4::Acquisitions
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789 Bug ID: 10789 Summary: Excessive and often incorrect use of finish in C4::Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org C4/Acquisitions.pm contains a lot of calls to finish. These seem to be copied as magic by someone who is unaware of the usage (please read the DBI doc for full details) In brief finish is only required to be called after a select statement where you have not read back the full result set. It should never be called after a non-select statement. In fact there are a couple of places in C4::Acquisitions.pm where its not called where it should be. In practice a call to finish in top level code is almost always always a bad sign. Lets clean these up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 11743] New: Remove unused DataTables plugin from OPAC theme directories
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11743 Bug ID: 11743 Summary: Remove unused DataTables plugin from OPAC theme directories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Two theme directories contain a copy of the main DataTables plugin which is unused and can be removed: opac-tmpl/ccsr/en/lib/jquery/plugins/jquery.dataTables.min.js opac-tmpl/bootstrap/lib/jquery/plugins/jquery.dataTables.min.js All OPAC templates now use the copy in opac-tmpl/lib/jquery/plugins/ -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 11765] New: Remove unused function isDate from templates
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11765 Bug ID: 11765 Summary: Remove unused function isDate from templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 11764 Several templates declare a JavaScript function "isDate" but the function is never used. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 11764] New: Move repeatedly redefined function toUC() into staff-global.js
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11764 Bug ID: 11764 Summary: Move repeatedly redefined function toUC() into staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org In many admin templates there is a "toUC" function is redeclared, used to transform input into uppercase. This small function can be moved into staff-global.js to avoid repetition. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 11628] New: staffaccess permission is missing in french userflags.sql file
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11628 Bug ID: 11628 Summary: staffaccess permission is missing in french userflags.sql file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: sophie.meynieux(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com 'staffaccess' permission (17) is missing in installer/mysql/data/fr-FR/1-Obligatoire/userflags.fr This patch adds it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 11735] New: Use new DataTables include in calendar template
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Bug ID: 11735 Summary: Use new DataTables include in calendar template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/holidays.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 11720 The calendar template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 11739] New: Use new DataTables include in notices template
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11739 Bug ID: 11739 Summary: Use new DataTables include in notices template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 11720 The Notices and Slips template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 11737] New: Use new DataTables include in quotes management template
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Bug ID: 11737 Summary: Use new DataTables include in quotes management template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/quotes.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 11720 The quotes management template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 11670] New: Remove sorting from patron lists action columns
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Bug ID: 11670 Summary: Remove sorting from patron lists action columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The table that lists patron lists has sortable columns for add, edit, and delete buttons. These columns should not be sortable. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 11721] New: Use new DataTables include in suggestions template
by bugzilla-daemon＠bugs.koha-community.org 19 May '14

19 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Bug ID: 11721 Summary: Use new DataTables include in suggestions template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/suggestion/suggestion.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The suggestions template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 9