August 2016 - Koha-bugs - lists.koha-community.org

[Bug 8055] reversing fines wonky
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall(a)gmail.com |koha-bugs(a)lists.koha-commun | |ity.org Status|Failed QA |ASSIGNED --- Comment #10 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I'm planning a true Void Payment function for the accounts rewrite rewrite. I will not be working on this patch any longer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #67 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- It might also depend on configuraton - it's possible to block renewals of overdue items now, but it's a more recent feature. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #66 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #64) > But doesn't the problem described here still exist after bug 15675? Renewing > an item with a fine should recreate the problem - so maybe we should also > run the clean-up script again? Yeah, you are right! In the production DB, past bug 15675, there may be some 'FU' fines records still linked to the existing issue records, which are not currently accruing, looks like they should be dealt with somehow. I wonder while I have no such cases in my test DB, probably because it got cloned from the production DB some time ago, and there was not a whole lot of renewals done in it since then. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15544] Facets must be managed from the intranet
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- It looks like this might have got lost - it was never set to "Needs Sign-off". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic(a)tamil.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #65 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Jacek Ablewicz from comment #60) > Created attachment 54779 [details] [review] > Bug 14390: [Follow-up] Only update FU record in UpdateFine > > Exclude O, F and M when outstanding == 0. Great idea, misa like! Not 100% perfect ;), but a lot better performance-wise in a typical production DB, just the right thing to do without rewriting ~half of this function from scratch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #64 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- But doesn't the problem described here still exist after bug 15675? Renewing an item with a fine should recreate the problem - so maybe we should also run the clean-up script again? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #63 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #61) > Did we verify old cases of double FU from renewals are taken care of > (cleaned)? Old 2+ FU records for the same item were taken care of in Bug 15675 (IMO quite effecively) - I don't think there is a need to include / repeat the same or similar procedure in this report. Double FUs created post-Bug 15675: there shouldn't be any (none such cases in my test DB, at least). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16894] New: re-show email on patron search results
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894 Bug ID: 16894 Summary: re-show email on patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 10318 add added email in patron search results. Looks like when the result page has been transformed to use Ajax Datables, this column was forgotten. Since column visibility can now be managed, its ok to have more columns I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #62 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- Note: for ensuring that MaxFine behaviour is unchanged, I did just: 1) set MaxFine to 100.00 2) commented out $accountline->set(...) in UpdateFine 3) (without the last patch): fines.pl 2>warnings.01 - I got over 1200 "Reducing fine for ... MaxFine reached" warnings in warnings.01 for my test database with 19k overdues 4) (with the last patch included): fines.pl 2>warnings.02 5) diff warnings.01 warnings.02: no differences Some extra testing with step 2) excluded would be better, but hopefully the above is good enough. Also in my opinion code changes introduced by the last patch are 100% solid and regression-free. -- You are receiving this mail because: You are watching all bug changes.

1 0