August 2016 - Koha-bugs - lists.koha-community.org

[Bug 17167] New: Koha has two separate renewal responses
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17167 Bug ID: 17167 Summary: Koha has two separate renewal responses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When checking an item out through SIP and the item has hit it's renewal limit, Koha responds with "Item has reached maximum renewals", but when renewing an item through SIP and the item has hit it's renewal limit, Koha responds with "NO_MORE_RENEWALS: 1 ". It doesn't make sense that there are different responses for essentially the same thing, even though in this case it is technically two different processes. Also, the number 1 seems to have no purpose. I increased the number of renewals, and this number doesn't change, so I don't know what it is supposed to be indicating. This makes trapping renewal limits more tedious. I would recommend the following changes to these responses. 1. Have the checkout and renewal processes through SIP respond with the same "Item has reached maximum renewals." 2. Note the period added to the end of the response. 3. Note the removal of the space at the end of the renewal response. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 10148] 007 not filling in with existing values
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #11 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54778|0 |1 is obsolete| | --- Comment #60 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54779&action=ed… Bug 14390: [Follow-up] Only update FU record in UpdateFine Exclude O, F and M when outstanding == 0. Check if the issue_id points to a FU record. Note: We only warn now when we see a second FU record with this issue id. That should be a rare exception. As before, we are just counting it in our total. Added a FIXME. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested fine on overdue. Renewed and backdated for a second fine. The F and FU can be seen on the Fines tab and are totaled on Check out. Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #59 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #52) > IMO adding the filter (for FU, or FU|O|M ?) in > > if ( $rec->{issue_id} == $issue_id ) { > > should do the trick. Followed that after all too. Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #58 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Oops. Taking the liberty to replace your last follow-up, Kyle. Kyle or Jacek: Could one (or both) of you test this one too ? After that we can probably go the QA fast lane.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54704|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54778&action=ed… Bug 14390: [Follow-up] Only update FU record in UpdateFine Exclude O, F and M when outstanding == 0. Check if the issue_id points to a FU record. Note: We only warn now when we see a second FU record with this issue id. That should be a rare exception. As before, we are just counting it in our total. Added a FIXME. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested fine on overdue. Renewed and backdated for a second fine. The F and FU can be seen on the Fines tab and are totaled on Check out. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #94 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14699] Intranet search history issues due to DataTables pagination
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #9 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Julian Maurice from comment #8) > (In reply to Owen Leonard from comment #7) > > (In reply to Nick Clemens from comment #6) >I suggest to keep the current behaviour, > change only the labels to "Select all visible rows" or something similar, > and maybe add an action "Clear all history" ? That sounds fine to me The problem in comment 6 with the delete button should also be addressed: with these patches the delete link still isn't visibly enabled but will delete all selected regardless of visibility -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #56 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- P.S.: And sorry for the logorrhea ;). I'm just getting worried that it may miss a deadline for the upcoming 16.05 maintenance release. -- You are receiving this mail because: You are watching all bug changes.

1 0