August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54778|0 |1 is obsolete| | --- Comment #60 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 54779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54779&action=ed… Bug 14390: [Follow-up] Only update FU record in UpdateFine Exclude O, F and M when outstanding == 0. Check if the issue_id points to a FU record. Note: We only warn now when we see a second FU record with this issue id. That should be a rare exception. As before, we are just counting it in our total. Added a FIXME. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested fine on overdue. Renewed and backdated for a second fine. The F and FU can be seen on the Fines tab and are totaled on Check out. Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #59 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #52) > IMO adding the filter (for FU, or FU|O|M ?) in > > if ( $rec->{issue_id} == $issue_id ) { > > should do the trick. Followed that after all too. Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #58 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Oops. Taking the liberty to replace your last follow-up, Kyle. Kyle or Jacek: Could one (or both) of you test this one too ? After that we can probably go the QA fast lane.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54704|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54778&action=ed… Bug 14390: [Follow-up] Only update FU record in UpdateFine Exclude O, F and M when outstanding == 0. Check if the issue_id points to a FU record. Note: We only warn now when we see a second FU record with this issue id. That should be a rare exception. As before, we are just counting it in our total. Added a FIXME. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested fine on overdue. Renewed and backdated for a second fine. The F and FU can be seen on the Fines tab and are totaled on Check out. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #94 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14699] Intranet search history issues due to DataTables pagination
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #9 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Julian Maurice from comment #8) > (In reply to Owen Leonard from comment #7) > > (In reply to Nick Clemens from comment #6) >I suggest to keep the current behaviour, > change only the labels to "Select all visible rows" or something similar, > and maybe add an action "Clear all history" ? That sounds fine to me The problem in comment 6 with the delete button should also be addressed: with these patches the delete link still isn't visibly enabled but will delete all selected regardless of visibility -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #56 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- P.S.: And sorry for the logorrhea ;). I'm just getting worried that it may miss a deadline for the upcoming 16.05 maintenance release. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #55 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #54) > (In reply to Jacek Ablewicz from comment #53) > > (In reply to Marcel de Rooy from comment #49) > > > > > But take care with $type that you get from CalcFine. > > > It may not be what you expect it to be .. > > > > Looks like $type argument passed to UpdateFine() is always NULL / undef, > > setting it to the custom string is not possible in Administration -> > > Circulation and fines rules, or anywhere else in the system (not > > implemented?). But in case it's not NULL in the database, it affects just a > > fine description and the log entry. > > > > There doesn't seem to be anything wrong with it - ? > > Well anything? :) > These kind of things make maintaining code only harder. They implicitly > suggest something while it is not there. Couldn't agree more.. What I meant was: anything wrong with it in UpdateFine() in particular, which may make a proposed solutions insufficient or more problematic? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15139] Show nonpublic note in overdues report
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Another library is asking for this - almost missed I had already filed a report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0