August 2016 - Koha-bugs - lists.koha-community.org

[Bug 16806] New: "Too soon" renewal error generates no alert for user
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Bug ID: 16806 Summary: "Too soon" renewal error generates no alert for user Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Created attachment 52773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52773&action=ed… example of error Steps to recreate: - for a particular item type & patron category, configure a non-zero "no renewal before" date i.e. make it so items cannot be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl Actual results: - note that under the "Renew" column a message prints indicating you cannot renew, due to lines 244-249 of /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt - https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c… - however, the logic above on lines 77-85 doesn't match, the "too_soon" error isn't being tested for - https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c… The end result is undesirable: because the error loop triggers, the patron sees a message, but *there's no reason given*! See attached screenshot. Expected results: - a message prints indicating the reason why you cannot renew the item I'll add a patch to opac-user.tt for this shortly. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 16776] New: If language is set by external link language switcher does not work
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Bug ID: 16776 Summary: If language is set by external link language switcher does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Follwoing scenario: - Have a multilingual koha installation, let's say en, de-CH, fr-FR and it-IT - Create external links e.g. from the multilingual library website to each language variant of OPAC: ...cgi-bin/koha/opac-main.pl?language=en ...cgi-bin/koha/opac-main.pl?language=de-CH ...cgi-bin/koha/opac-main.pl?language=fr-FR ...cgi-bin/koha/opac-main.pl?language=it-IT Each link opens fine displaying the language as appropriate. Now try to switch language on the page you just opened via the external link. It won't work, it will always stay on the language defined by the external link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17141 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17141 [Bug 17141] Incorrect method called in edi_cron to get logdir -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16848] New: Wrong warning "Invalid date ... passed to output_pre" can be carped
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Bug ID: 16848 Summary: Wrong warning "Invalid date ... passed to output_pre" can be carped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org >From Koha::DateUtils::output_pref: $dt = eval { dt_from_string( $str ) } if $str; carp "Invalid date '$str' passed to output_pref\n" if $@; This second line is wrong: if $str does not exist, the first line is not evaluated and $@ could be filled with previous error. To reproduce: diff --git a/t/DateUtils.t b/t/DateUtils.t index eede4a0..2dd6a9d 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -229,3 +229,5 @@ is( $output_for_invalid_date, undef, 'output_pref should return undef if an inva warning_is { output_pref( { 'str' => $testdate_iso, dt => $dt, dateformat => 'iso', dateonly => 1 } ) } { carped => 'output_pref should not be called with both dt and str parameters' }, 'output_pref should carp if str and dt parameters are passed together'; + +output_pref(); Then: prove t/DateUtils.t will display: t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or string at Koha/DateUtils.pm line 217. Invalid date '' passed to output_pref at t/DateUtils.t line 233. t/DateUtils.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00 csys = 1.42 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 17074] New: Fix links in result list of 'scan indexes' search and keep search term
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17074 Bug ID: 17074 Summary: Fix links in result list of 'scan indexes' search and keep search term Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: katrin.fischer(a)bsz-bw.de Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The 'scan indexes' search that can be reached from the advanced search has 2 problems to begin with: - The search term you searched for is not displayed in the input field. - The links in the result list are missing the index and because of that, are not giving the correct results. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 17053] New: Clearing search term in Reports
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17053 Bug ID: 17053 Summary: Clearing search term in Reports Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: jesse(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If you click the clear button to clear the search term it does take the search term away. However, the next time you click on "Saved reports" the search term is still there. 1. Do a search for "series" 2. Click the clear button ("Series" is removed from the search box and the list of reports populates with all reports) 3. Do anything (or nothing) 4. Click on "saved reports" 5. "Series" is in the search box and the list of reports are limited to reports about series. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #61 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Did we verify old cases of double FU from renewals are taken care of (cleaned)? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17087] New: Set Test::WWW::Mechanize version to 1.42
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17087 Bug ID: 17087 Summary: Set Test::WWW::Mechanize version to 1.42 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org This was set to a version that is not available in Wheezy or Jessie. The version is not required, the only change to 1.42 (packaged for Wheezy and Jessie) is a fix for Windows, see http://cpansearch.perl.org/src/PETDANCE/Test-WWW-Mechanize-1.44/Changes -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 17167] New: Koha has two separate renewal responses
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17167 Bug ID: 17167 Summary: Koha has two separate renewal responses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When checking an item out through SIP and the item has hit it's renewal limit, Koha responds with "Item has reached maximum renewals", but when renewing an item through SIP and the item has hit it's renewal limit, Koha responds with "NO_MORE_RENEWALS: 1 ". It doesn't make sense that there are different responses for essentially the same thing, even though in this case it is technically two different processes. Also, the number 1 seems to have no purpose. I increased the number of renewals, and this number doesn't change, so I don't know what it is supposed to be indicating. This makes trapping renewal limits more tedious. I would recommend the following changes to these responses. 1. Have the checkout and renewal processes through SIP respond with the same "Item has reached maximum renewals." 2. Note the period added to the end of the response. 3. Note the removal of the space at the end of the renewal response. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 10148] 007 not filling in with existing values
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '16

23 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #11 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.

1 0