November 2017 - Koha-bugs - lists.koha-community.org

[Bug 17833] New: Memcached silently fails to _initilize_memcached() on the second time it is invoked
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Bug ID: 17833 Summary: Memcached silently fails to _initilize_memcached() on the second time it is invoked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org When _initilize_memcached() is called the first time, it sets the 'ismemcached'-key and returns 1. When _initilize_memcached() is called the second time, the 'ismemcached'-key already exists and '' is returned (this default to False in Perl). Koha thinks that memcached is not in use and decides to use some other caching mechanism instead. Cache::Memcached::Fast returns undef on server error: https://metacpan.org/pod/Cache::Memcached::Fast#add Koha MUST listen to undefined, instead of False to define whether or not memcached is properly working. Also added simple helpful diagnostics to help identify and log when this memcached server connection problem arises. Here is a small test run to verify this behaviour: root@kohadev:~# echo "fresh memcached start" fresh memcached start root@kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '1' getkey: 'text' root@kohadev:~# echo "val already cached" val already cached root@kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '' getkey: 'text' root@kohadev:~# echo "memcached killed and not responding" memcached killed and not responding root@kohadev:~# perl l.pl undef getkey: '' root@kohadev:~# echo "The return value is undefined" The return value is undefined root@kohadev:~# Here is the code snippet used to test the Memcached-server in the previous example output: kivilahtio@koha_ci_1 /h/k/Koha> cat t.pl use Cache::Memcached::Fast; use Modern::Perl; my $memd = new Cache::Memcached::Fast({ servers => [ '/lxcBindMount/tmp/memcached.sock' ], namespace => 'koha_ci_1:', connect_timeout => 0.2, io_timeout => 0.5, close_on_error => 1, max_failures => 3, failure_timeout => 2, ketama_points => 150, nowait => 1, hash_namespace => 1, }); # Get server versions. my $versions = $memd->server_versions; while (my ($server, $version) = each %$versions) { print "$server $version\n"; } # Store scalars. my $rv = $memd->add('skey', 'text'); print "undef\n" if not defined $rv; print "def : '$rv'\n" if defined $rv; print "getkey: '".$memd->get('skey')."'\n"; -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 19304] New: Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Bug ID: 19304 Summary: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 19303] New: Move C4::Members::GetFirstValidEmailAddress to Koha:: Patron->first_valid_email_address
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Bug ID: 19303 Summary: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org This new Koha::Patron->first_valid_email_address already exists, it should be called directly. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19300] New: Move C4::Reserves:: OPACItemHoldsAllowed to the code namespace
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Bug ID: 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the code namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 19603] New: Move admin templates JavaScript to the footer: Patrons and circulation
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 Bug ID: 19603 Summary: Move admin templates JavaScript to the footer: Patrons and circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)bugs.koha-community.org, nick(a)bywatersolutions.com, simon.pouchol(a)biblibre.com, testopia(a)bugs.koha-community.org Depends on: 19594 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the patrons and circulation administration templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 [Bug 19594] Move admin templates JavaScript to the footer: MARC-related -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 17951] New: koha-create should create the template cache dir and configure it in koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Bug ID: 17951 Summary: koha-create should create the template cache dir and configure it in koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 33

[Bug 19494] New: Add reservedate to Holds awaiting pickup
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494 Bug ID: 19494 Summary: Add reservedate to Holds awaiting pickup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 18537] New: Update Ukrainian installer sample files for 17.05
by bugzilla-daemon＠bugs.koha-community.org 15 Jan '18

15 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Bug ID: 18537 Summary: Update Ukrainian installer sample files for 17.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: dubyk(a)ukr.net QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Created attachment 63100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63100&action=ed… Update Ukrainian installer sample files for 17.05 Update and translate sample SQL file of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 30

[Bug 19694] New: Edited shipping cost in invoice doesn't save
by bugzilla-daemon＠bugs.koha-community.org 15 Jan '18

15 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694 Bug ID: 19694 Summary: Edited shipping cost in invoice doesn't save Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org If you change the shipping cost in an existing invoice, the page reloads on saving and gives you a success message, but the amount stays the same. Tested so far in 16.11.13 and 3.22.18. To test: - Search for an existing invoice - Show details - Changing shipping cost - Save - Verify the old amount is still shown, although there is a success message on top -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 18201] New: Confusing language on Export data - bibliographic records " Remove non-local items"
by bugzilla-daemon＠bugs.koha-community.org 15 Jan '18

15 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Bug ID: 18201 Summary: Confusing language on Export data - bibliographic records "Remove non-local items" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When exporting records and selecting branches many users (and myself) assume that 'Remove non-local items' means: remove items not belonging the branches i am exporting But it actually means: Remove items not belonging to the branch I am logged in as At a minimum I think we need to update the language, ideally I think we should provide the expected behavior as an option. -- You are receiving this mail because: You are watching all bug changes.

1 39