June 2017 - Koha-bugs - lists.koha-community.org

[Bug 16329] New: Koha::Logger->sql(). Unified interface to log SQL statements OR use DBIx::Log4perl
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16329 Bug ID: 16329 Summary: Koha::Logger->sql(). Unified interface to log SQL statements OR use DBIx::Log4perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Instead of whenever needing to log SQL statements, making a custom logging output/function, introduce a centralized subroutine to handle all sql-statement logging. How the SQL-statements should be logged remains to be seen, but currently simply presenting very simple formatting we can discuss about. SQL libraries (DBI, DBIx) also allow logging SQL-statements but lack the fine-grained control Log4perl offers. Or maybe Log4perl can be integrated better to DBI / DBIx with this: https://metacpan.org/pod/DBIx::Log4perl Because I am not a huge fan of DBIx and also integrating that to Koha::Object is a lot of work, will not pursue that track further. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 16304] New: Koha::Logger, lazy load loggers so environment can be properly set.
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304 Bug ID: 16304 Summary: Koha::Logger, lazy load loggers so environment can be properly set. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org If you instantiate Koha::Loggers before having set the C4::Context->interface, their interface defaults to 'opac'. This is rather undesired especially for 'commandline' scripts such as cronjobs. A solution to this is to lazyLoad loggers when they are really needed. LazyLoading might also have a performance boost when using packages that initialize a package-level logger but which never gets used. see t/Koha/Logger.t on how to replicate this issue, but here is a nutshell of how to replicate this issue: @@ file A.pm package A; use Koha::Logger; my $logger = Koha::Logger->get({category => __PACKAGE__}); #interface unknown sub doStuff { $logger->error('My interface is always "opac"'); } @@ script run.pl use C4::Context; C4::Context->interface('commandline'); use A; A::doStuff(); #error is logged using the "opac"-interface instead #of the "commandline"-interface -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 17418] New: Move staff client home page JavaScript to the footer
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bug ID: 17418 Summary: Move staff client home page JavaScript to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org This patch will do two things: 1. Update the header and footer include files in order to be able to manage JavaScript either in the header or the footer. 2. Modify the staff client home page as a proof of concept, moving global and in-page JavaScript assets to the footer. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 17859] New: Move JavaScript to the footer on about and auth pages
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Bug ID: 17859 Summary: Move JavaScript to the footer on about and auth pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17418 Blocks: 17858 Two "standalone" templates which can have the JavaScript moved to the footer: The about page and the login page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 17893] New: Move JavaScript to the footer on staff client catalog pages
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Bug ID: 17893 Summary: Move JavaScript to the footer on staff client catalog pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: claire_gravely(a)hotmail.com, jonathan.druart(a)bugs.koha-community.org, testopia(a)bugs.koha-community.org Depends on: 17870, 17418 Blocks: 17858 This patch will move JavaScript to the footer on a number of pages in the catalog module of the staff client: basket/basket.tt catalogue/ISBDdetail.tt catalogue/MARCdetail.tt catalogue/advsearch.tt catalogue/detail.tt catalogue/imageviewer.tt catalogue/issuehistory.tt catalogue/itemsearch.tt catalogue/labeledMARCdetail.tt catalogue/moredetail.tt catalogue/results.tt catalogue/search-history.tt In the process I will be consolidating JS from several of those templates into one separate JavaScript file. Other modifications will be required in order for JavaScript to be able to be called from catalog-related include files. Since include files are parsed before jQuery is loaded in the footer, jQuery-specific code will have to be adapted or moved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 17416] New: Move javascript in doc-head-close.inc into a separate include
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Bug ID: 17416 Summary: Move javascript in doc-head-close.inc into a separate include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I would like to move the staff client JavaScript assets from the header to the footer. This is a best practice for speed because pages can begin rendering before all JavaScript is loaded. This bug is a first step which shouldn't affect any JS behavior. It will move the parts of doc-head-close.inc which relate to JavaScript into a separate file, js_includes.inc. A later patch will move the include into the footer. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 17870] New: Call to include file incorrectly moved into the footer
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Bug ID: 17870 Summary: Call to include file incorrectly moved into the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: bouzid.fergani(a)inlibro.com, jonathan.druart(a)bugs.koha-community.org, katrin.fischer(a)bsz-bw.de, kyle(a)bywatersolutions.com, philippe.blouin(a)inlibro.com, testopia(a)bugs.koha-community.org Depends on: 17416, 17418 Blocks: 17858, 17859 In Bug 17418 I moved a line from doc-head-close.inc to js_includes.inc which I shouldn't have: -[% PROCESS 'html_helpers.inc' %] That file isn't JS and many pages depend on it being defined at the top of the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 [Bug 17416] Move javascript in doc-head-close.inc into a separate include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 [Bug 17859] Move JavaScript to the footer on about and auth pages -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 16450] New: Remove the use of "onclick" from guarantor search template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 Bug ID: 16450 Summary: Remove the use of "onclick" from guarantor search template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/guarantor_search.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13041, 16386 When adding a guantor to a patron record, a search form is shown in a popup window. This page should be reworked to avoid the use of "onclick." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 [Bug 13041] Can't add user as manager of basket if name includes a single quote https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 [Bug 16386] Replace the use of "onclick" from patron card creator templates -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 16386] New: Replace the use of "onclick" from patron card creator templates
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 Bug ID: 16386 Summary: Replace the use of "onclick" from patron card creator templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: arslanone(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 16372 Several patron card creator templates include the use of an "onclick" attribute. These should be removed in favor of defining events in JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 16457] New: Remove the use of "onclick" from the patron entry form
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 Bug ID: 16457 Summary: Remove the use of "onclick" from the patron entry form Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/memberentry.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 13041, 16386, 16450 There are several instances of "onclick" in memberentrygen.tt. It should be rewritten so that JS functionality can be separate from the markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 [Bug 13041] Can't add user as manager of basket if name includes a single quote https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 [Bug 16386] Replace the use of "onclick" from patron card creator templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 [Bug 16450] Remove the use of "onclick" from guarantor search template -- You are receiving this mail because: You are watching all bug changes.

1 19