June 2017 - Koha-bugs - lists.koha-community.org

[Bug 18088] New: Software error additem.pl Can' t call method subfield error. Can't add items.
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18088 Bug ID: 18088 Summary: Software error additem.pl Can't call method subfield error. Can't add items. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: hard359(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl While adding items it sais: Can't call method "subfield" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 91. Line 88 to 103 sub _increment_barcode { my ($record, $frameworkcode) = @_; my ($tagfield,$tagsubfield) = &GetMarcFromKohaField("items.barcode",$frameworkcode); unless ($record->field($tagfield)->subfield($tagsubfield)) { my $sth_barcode = $dbh->prepare("select max(abs(barcode)) from items"); $sth_barcode->execute; my ($newbarcode) = $sth_barcode->fetchrow; $newbarcode++; # OK, we have the new barcode, now create the entry in MARC record my $fieldItem = $record->field($tagfield); $record->delete_field($fieldItem); $fieldItem->add_subfields($tagsubfield => $newbarcode); $record->insert_fields_ordered($fieldItem); } return $record; } -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 18199] New: Proxy support for UsageStats
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18199 Bug ID: 18199 Summary: Proxy support for UsageStats Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: tkalix(a)bredex.de QA Contact: testopia(a)bugs.koha-community.org Hello, I have had problems uploading the usage stats. The monthly script failed with some error message. The solution was to edit the file UsageStats.pm and insert my http proxy after line 347. And now it is working fine. It would be good if the utility uses the proxy support I configured in Koha, so one does not need to use the workaround I did. Thanks, Torsten. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 18750] New: t/db_dependent/Circulation/Branch.t fails.
by bugzilla-daemon＠bugs.koha-community.org 04 May '19

04 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18750 Bug ID: 18750 Summary: t/db_dependent/Circulation/Branch.t fails. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com prove t/db_dependent/Circulation/Branch.t fails test 12 not ok 12 - AddReturn respects default return policy - return to homebranch In C4::Circulation, the CanBookBeReturned returns 0 for the wrong branch, but never tests if it is returnable for the right branch. Adding in logic triggers the NeedsTransfer else case near the end of the AddReturn function. It is unclear what else might break as a side-effect of this patch method. I will put this into Discussion, unless someone else can verify this is the correct way to fix the problem. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 16300] New: Remove the use of "onclick" from circulation and fine rules template
by bugzilla-daemon＠bugs.koha-community.org 02 May '19

02 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Bug ID: 16300 Summary: Remove the use of "onclick" from circulation and fine rules template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/smart-rules.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, testopia(a)bugs.koha-community.org, veron(a)veron.ch Depends on: 15456 There is one place where an "onclick" attribute is used in admin/smart-rules.tt. It should be rewritten so that JS functionality is separate from the markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 16167] New: Authorised value images may be removed
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Bug ID: 16167 Summary: Authorised value images may be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16041 The feature to attach an image to an authorised value does not seem to work perfectly and it's possible that nobody uses it. I'd suggest to discuss about that removal on this bug report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041 [Bug 16041] StaffAuthorisedValueImages & AuthorisedValueImages preferences - impact on search performace -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 17101] New: Confirm a question before check in
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Bug ID: 17101 Summary: Confirm a question before check in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: T.Reimann95(a)gmx.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Here should be a new option for checkin message by itemtypes implemented. This new option required a confirmation from the user (over a question which is written there) bevor the item is checked in. The only possible answer for the question are yes or no. By yes the item is checked in, by no it's not checked in. To give an example what is meant here: If you create the item type audiobook, you then can add the Check in Message : "Does envelope and content match?" and for the check in message type: question. So if now a item with the item type audiobook is checked in, the user is ask : "Does envelope and content match?" and got the answer possibiltys yes and no. At this moment he can't read a new barcode, so he must answer the question. If he answer yes the item is check in, if he answer no the item is not check in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 43

[Bug 17899] New: Show only mine does not work in newordersuggestion.pl
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Bug ID: 17899 Summary: Show only mine does not work in newordersuggestion.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 12775 added a link "Show only mine" in newordersuggestion.pl. This does not work, no results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 18163] New: Elasticsearch itemtype indexing correctly for unimarc
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '19

22 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Bug ID: 18163 Summary: Elasticsearch itemtype indexing correctly for unimarc Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: pjamorim91(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org After installing and indexing Elasticsearch, a search for itemtype is not working correctly. The reason for this I think is that Marc21 uses the index itype whereas Unimarc uses the index itemtype. The index mapped in mappings.yml is itype, and a search for item type in unimarc will search on itemtype index, which has nothing mapped to. Furthermore, trying to change the index from itype to itemtype in the mappings panel for elasticsearch will trigger the following error: Can't call method "label" on an undefined value at /usr/share/koha/intranet/cgi-bin/admin/searchengine/elasticsearch/mappings.pl line 69 -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 18432] New: Most code comments assume male gender
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Bug ID: 18432 Summary: Most code comments assume male gender Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Developer documentation Assignee: gmcharlt(a)gmail.com Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Throughout the Koha codebase, the pronoun "he" is used to refer to a generic third person who could be of any gender. For instance, in C4/Suggestions.pm line #66: 'When a librarian manages the suggestion, he can set the status to "REJECTED" or "ACCEPTED".' That assumes all librarians are male. It's particularly problematic given that, in the US at least, the profession is heavily female. In other files, all borrowers are assumed to be male. In the interest of making the code base more inclusive, it'd be better to not assume a male gender. The patch—which touches *a lot* of disparate files but almost only comments—changes all instances of "he" or "him" I could find to "he or she" and "him or her" respectively. I'd also be in support of singular "they"/"their" in these situations if people prefer that. In a few cases, a non-human object was being referred to as "he", so I used "it" instead. FYI, the regex I used to find uses of the pronoun "he" and "him": - / (H|h)e (?!or she)/ - / (H|h)im (?!or her)/ I ignored "docs/history.txt" and "misc/release_notes" since those seem to refer to actual men who worked on Koha, and also the Maori translations. There were 3 "unimarc_framework_DEFAULT.sql" files also used "he" in a way that seemed to refer to a particular individual, though I'm not sure. Testing plan: - I can't really formulate a "testing plan" for this patch since it shouldn't impact actual executing code - The patch does touch strings in a few tests so at the very least these should continue to pass: M C4/SIP/t/06patron_enable.t M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M t/db_dependent/Circulation.t M t/db_dependent/Koha/Patrons.t M t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 17535] New: Regression: Search for reports by keyword
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Bug ID: 17535 Summary: Regression: Search for reports by keyword Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 14435 Introduced by bug 14435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 [Bug 14435] Recover feature to store and access results of a report -- You are receiving this mail because: You are watching all bug changes.

1 10