September 2017 - Koha-bugs - lists.koha-community.org

[Bug 18183] New: jQuery append error related to script tags in cloneItemBlock
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '18

22 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Bug ID: 18183 Summary: jQuery append error related to script tags in cloneItemBlock Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org This is a strange javascript error that I experienced on a 3.22 system and could not reproduce with the current (modified) framework in master. But since the code is essentially the same, it might still be possible. The js error is: TypeError: document.getElementById(...) is null The line in koha-tmpl/intranet-tmpl/prog/js/additem.js that causes this error is: $(clone).append(data); While running append, jQuery seems to call .domManip and .globalEval internally. The result on the interface is that you do not have an item block when receiving an order (AcqCreateItem=receiving). Note that data comes from services/itemrecorddisplay.pl and is a very long string containing all item fields and even script tags for plugins. Between the ACQ framework in 3.22 and in master (copied from Default), I noticed some smaller changes in the lines for plugins. Since the js variable "clone" contains a jQuery object for an element that is not yet added to the page, I could imagine a getElementById error. But it does not always occur, so some other condition must be triggered too. This condition appears to be connected to the script tags, since removing all plugins from the ACQ framework in 3.22 made the error disappear (no solution however). Some interesting comments on jQuery's handling of appending script tags are found in http://stackoverflow.com/questions/610995/cant-append-script-element Triggered by the getElementById error, I rearranged a few lines in cloneItemBlock so that I appended clone (the 'floating' div field for the new item) first to the outeritemblock div on the page and after that I appended the data string (item fields and script tags) to clone. This resolved the js error on 3.22 and did not affect master. Conclusion: We seem to stumble over a problem with our plugin script tags in jQuery's script evaluation when clone is not bound to the page yet. The proposed patch just adds this workaround touching three lines. If we would like to change (again) the way we handle script tags for plugins, we will need much more effort. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 18458] New: Merging authority record incorrectly orders subfields
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 Bug ID: 18458 Summary: Merging authority record incorrectly orders subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When merging two authorities and updating the linked biblios MARC::Field->new() is called with the tagnumber, indicators, and the new subfield $9 This causes this subfield to be the first in the field as a whole and is inconsistent with usualy ordering -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 19200] New: Warns when exporting a basket
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 Bug ID: 19200 Summary: Warns when exporting a basket Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org When exporting a basket with the default CSV profile: Use of uninitialized value in string eq at /home/vagrant/kohaclone/acqui/basket.pl line 173. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_basket_2epl line 177, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. When exporting a basket with some other CSV profile: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_basket_2epl line 177, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 18242] New: Remove primary key on old_issues.issue_id
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Bug ID: 18242 Summary: Remove primary key on old_issues.issue_id Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. -- You are receiving this mail because: You are watching all bug changes.

1 49

[Bug 17466] New: Show number of outstanding issues when checking in
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Bug ID: 17466 Summary: Show number of outstanding issues when checking in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 18363] New: Delink analytical records is gone
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18363 Bug ID: 18363 Summary: Delink analytical records is gone Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: verolencinas(a)yahoo.com.ar QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In Koha 16.05.11 you cannot "delink" analytical records. The link is gone and the action buttons don't display this option on the analytical record. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 17833] New: Memcached silently fails to _initilize_memcached() on the second time it is invoked
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Bug ID: 17833 Summary: Memcached silently fails to _initilize_memcached() on the second time it is invoked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org When _initilize_memcached() is called the first time, it sets the 'ismemcached'-key and returns 1. When _initilize_memcached() is called the second time, the 'ismemcached'-key already exists and '' is returned (this default to False in Perl). Koha thinks that memcached is not in use and decides to use some other caching mechanism instead. Cache::Memcached::Fast returns undef on server error: https://metacpan.org/pod/Cache::Memcached::Fast#add Koha MUST listen to undefined, instead of False to define whether or not memcached is properly working. Also added simple helpful diagnostics to help identify and log when this memcached server connection problem arises. Here is a small test run to verify this behaviour: root@kohadev:~# echo "fresh memcached start" fresh memcached start root@kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '1' getkey: 'text' root@kohadev:~# echo "val already cached" val already cached root@kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '' getkey: 'text' root@kohadev:~# echo "memcached killed and not responding" memcached killed and not responding root@kohadev:~# perl l.pl undef getkey: '' root@kohadev:~# echo "The return value is undefined" The return value is undefined root@kohadev:~# Here is the code snippet used to test the Memcached-server in the previous example output: kivilahtio@koha_ci_1 /h/k/Koha> cat t.pl use Cache::Memcached::Fast; use Modern::Perl; my $memd = new Cache::Memcached::Fast({ servers => [ '/lxcBindMount/tmp/memcached.sock' ], namespace => 'koha_ci_1:', connect_timeout => 0.2, io_timeout => 0.5, close_on_error => 1, max_failures => 3, failure_timeout => 2, ketama_points => 150, nowait => 1, hash_namespace => 1, }); # Get server versions. my $versions = $memd->server_versions; while (my ($server, $version) = each %$versions) { print "$server $version\n"; } # Store scalars. my $rv = $memd->add('skey', 'text'); print "undef\n" if not defined $rv; print "def : '$rv'\n" if defined $rv; print "getkey: '".$memd->get('skey')."'\n"; -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 19304] New: Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Bug ID: 19304 Summary: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 19303] New: Move C4::Members::GetFirstValidEmailAddress to Koha:: Patron->first_valid_email_address
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Bug ID: 19303 Summary: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org This new Koha::Patron->first_valid_email_address already exists, it should be called directly. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19300] New: Move C4::Reserves:: OPACItemHoldsAllowed to the code namespace
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Bug ID: 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the code namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 25