January 2018 - Koha-bugs - lists.koha-community.org

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70685|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70736&action=ed… Bug 9634 [QA Followup] - Add new column to kohastructure.sql Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70592|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 70735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70735&action=ed… Bug 9634: Allow for combining same paraneters in SQL reports This patch set adds a new colum to saved_sql 'combine_params' If set, parameters that have the same name and data type will only be asked for once from the user To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <<cat>> AS one, <<dog|branches>> AS two, <<dog|YES_NO>> as three, <<cat>> as four, <<dog|branches>> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are still asked for five parameters 6 - Edit report, note the 'Combine params' options, say YES!!!!! 7 - Re-run the report, you shoudl be asked for three parameters 8 - Verify the results reflect the supplied parameters 9 - Create a new report (perhaps something more substantive) 10 - Save with 'combine params' checke 11 - View in saved reports and see the new 'combine params' column 12 - Verify it is correctly set 13 - Run the report and verify correct results 14 - prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #26 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- This patch doesn't really require unit tests in my opinion. But we didn't agree (explicitly) on the one exception per file approach, and since this patch was posted several exceptions have been added. This patch is of big value because Olli put a lot of time thinking about the exceptions we might need and also how to organize them. This should be used as a basis for new exceptions addition. Maybe organized by type or module as the ones we already have (which should be rearranged too, virtualshelves, etc) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #25 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Josef Moravec from comment #24) > (In reply to Olli-Antti Kivilahti from comment #23) > > Created attachment 60963 [details] [review] [review] > > Bug 13995 - Proper Exception handling > > Is it ready for testing again? What is the test plan? Nope. Because the test that Olli-Antti Kivilahti added was only for one of the exceptions added. Still Failed QA, because of inadequate test coverage. Jonathan Druart came across as rather particular on this point in a recent IRC meeting. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70730|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 70731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70731&action=ed… Bug 14272: [FOLLOW-UP] Show single news item This patch fixes merge conflicts, an error in the query, and changes the column name `new` to `content`. This patch is now ready to test. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59483|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 70730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70730&action=ed… Bug 14272: [FOLLOW-UP] Show single news item This patch fixes merge conflicts, an error in the query, and changes the column name `new` to `content`. This patch is now ready to test. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50559|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 70729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70729&action=ed… Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Fixing merge conflicts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50558|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 70728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70728&action=ed… Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Fixing merge conflicts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15595] Display Google Jacket image on staff client search list and detail page
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 --- Comment #2 from jwayway(a)hotmail.com --- Created attachment 70721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70721&action=ed… Bug-15595: Google cover staff search and detail Test plan: 1. Apply patch 2. In system preferences enable GoogleJacketsIntra 3. Cover images from Google should show in results page and detail page 4. If the record doesn't have a cover, it should display "No cover image available" 4. Disabling the GoogleJacketIntra will cause the cover images not to show 5. Without patch there is no GoogleJacketsIntra syspref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0