January 2018 - Koha-bugs - lists.koha-community.org

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #96 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 69028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028 Bug 11879: Add the "Main contact method" field in borrower informations. Review of attachment 69028: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=118…) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/borrowers_primary_contact_method.sql @@ +1,2 @@ > +ALTER TABLE `borrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `lastseen`; > +ALTER TABLE `deletedborrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `overdrive_auth_token`; deletedborrowers and borrowers should maintain the same field order. ::: installer/data/mysql/kohastructure.sql @@ +1682,4 @@ > `lang` varchar(25) NOT NULL default 'default', -- lang to use to send notices to this patron > `login_attempts` int(4) default 0, -- number of failed login attemps > `overdrive_auth_token` text default NULL, -- persist OverDrive auth token > + `lastseen` datetime default NULL, -- last time a patron has been seed (connected at the OPAC or staff interface) This adds lastseen, but the borrowers_primary_contact_method did not add it at all. ::: installer/data/mysql/updatedatabase.pl @@ +14968,4 @@ > } > } > > + Totally not necessary to touch this. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +538,5 @@ > > [% UNLESS nophone && nophonepro && nomobile && noemail && noemailpro && nofax %] > <fieldset class="rows" id="memberentry_contact"> > + <legend id="contact_lgd">Contact</legend> > +<ol> Keep whitespace changes separate. @@ +602,4 @@ > [% IF ( mandatoryemailpro ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] > + [% UNLESS nofax %] Keep whitespace changes separate. @@ +664,5 @@ > + [% END %] > + [% END %] > + </select> > + </li> > + </ol> This is the only place where you can really get away with these minor whitespace changes on the END and /ol. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +275,5 @@ > + [% ELSE %] > + [% guarantor.firstname | html %] [% guarantor.surname | html %] > + [% END %] > + </li> > + [% END %] Where did this ELSIF clause come from?! This has nothing to do with primary_contact_method. ::: opac/opac-memberentry.pl @@ +93,5 @@ > libraries => \@libraries, > OPACPatronDetails => C4::Context->preference('OPACPatronDetails'), > ); > +my $check_BorrowerMandatoryField=C4::Context->preference("BorrowerMandatoryField"); > + my @field_check=split(/\|/,$check_BorrowerMandatoryField); Something is strange about this indentation. I would expect the same indentation level. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11559] Professional cataloger's interface
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19788] New: Local preference with uppercase
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788 Bug ID: 19788 Summary: Local preference with uppercase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In Administration > System preferences, when adding a local preference, the 'variable' name is transformed in lowercase. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 19702] New: Basket not displaying correctly on home page
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702 Bug ID: 19702 Summary: Basket not displaying correctly on home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: david.bourgault(a)inlibro.com Reporter: david.bourgault(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: philippe.blouin(a)inlibro.com When viewing the "base url" of the OPAC catalog, the basket is not displayed correctly: Say your website is `opac.books.com`, the basket will be displayed correctly for all page under `opac.books.com/cgi-bin/koha/` but not on `opac.books.com/` -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 19840] New: Patron note is not displayed on checkin
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Bug ID: 19840 Summary: Patron note is not displayed on checkin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 14224 If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 [Bug 14224] patron notes about item shown at check in -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 18458] New: Merging authority record incorrectly orders subfields
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 Bug ID: 18458 Summary: Merging authority record incorrectly orders subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When merging two authorities and updating the linked biblios MARC::Field->new() is called with the tagnumber, indicators, and the new subfield $9 This causes this subfield to be the first in the field as a whole and is inconsistent with usualy ordering -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 19813] New: MarcItemFieldsToOrder cannot handle a tag not existing
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813 Bug ID: 19813 Summary: MarcItemFieldsToOrder cannot handle a tag not existing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org MarcItemFieldsToOrder defines how Koha looks at tags in order records to generate item data. Let's look at a simplified case: homebranch: 955$a holdingbranch: 956$a So, here we are looking at 955 for the home branch, and 956 for the holding branch. So, it should make sense that Koha requires that these fields exist in equal number in the record. That is, for each 955, there should be a corresponding 956. Let's look at a different case: homebranch: 946$a|975$a holdingbranch: 946$a|975$a In this case, we are using the fallback behavior. VendorA stores the branch data in 946, and VendorB stores it in 975. This seems like it would work, but it won't! That's because Koha is expecting there to be the same number of 946's as there are 975's! In reality, the VendorA records will have a number of 946's, and *zero* 975's. The inverse will be true for VendorB. Koha should be able to skip those tags that simply don't exist in the record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow correct handling of |Internationalization: |plural translation |plural forms, context, and | |more -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Well, it is kind of hard to separate. Maybe apart from this: +sub _bib_indicator2 { + my ( $code ) = @_; + my %thes_mapping = ( a => 0, b => 1, c => 2, d => 3, k => 5, n => 4, r => 7, s => 7, v => 6, z => 7, '|' => 4 ); + return $thes_mapping{ $code } // $code // '4'; +} + +sub _bib_subfield2 { + my ( $indicator2, $subject_headings, $conventions ) = @_; + return if $indicator2 ne '7'; + return 'aat' if $subject_headings eq 'r'; + return 'sears' if $subject_headings eq 's'; + return $conventions if $subject_headings eq 'z'; +} I noted that some fields still contain more exceptions. Like: 653, 654 ind2, 655 ind1, 656 and 657 only 7 in ind2, 658, 662, 69X I still feel more for an approach I originally had in mind by adding a conf file containing essentially a hash that tells you what to do like: 600, ind1 => authind1 | authind2 | bibind1 | bibind2 | [fixed_value] | thesaurus where thesaurus could trigger a call to bib_indicator2. The uniform title stuff would move to that config file. It would give people more flexibility to make changes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20025] New: Running of koha-* scripts should be logged
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '18

19 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025 Bug ID: 20025 Summary: Running of koha-* scripts should be logged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: black23(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: josef.moravec(a)gmail.com, katrin.fischer(a)bsz-bw.de, magnus(a)libriotech.no, paul.poulain(a)biblibre.com, rbit(a)rbit.cz, robin(a)catalyst.net.nz Blocks: 18081 GDPR related. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4