January 2018 - Koha-bugs - lists.koha-community.org

[Bug 17466] New: Show number of outstanding issues when checking in
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Bug ID: 17466 Summary: Show number of outstanding issues when checking in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 --- Comment #10 from Charlotte Cordwell <charlotte.cordwell123(a)gmail.com> --- Created attachment 70651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70651&action=ed… Bug 15283: Switch default ISSUEQSLIP notice to Template Toolkit Please test if changes are correct. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Charlotte Cordwell <charlotte.cordwell123(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9634] Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett <mtompset(a)hotmail.com> --- Failed to include update for fresh install, only upgrade alter table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20007] New: build_browser_and_cloud.pl contains hard-coded text in French
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20007 Bug ID: 20007 Summary: build_browser_and_cloud.pl contains hard-coded text in French Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr build_browser_and_cloud.pl is not translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #26 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #21) > + unless ($item) { carp "No item passed in!" && return } > Not our preferred coding style This was just copying others in this file, changed to "return unless $item" > + return () if (! $yaml =~ /\S/ ); > Just return here. Removed > + eval { > + $denyingrules = YAML::Load($yaml); > + }; > How much time are we spending on doing this? What is the performance effect? Was about .037 seconds (with 2 fields and 1000 values) Using split is about .014 seconds, okay, I switched > + return (); Yup > Why not in just one line: my $val = $item->{$field} // ''; Good point >Why not just provide an example as close as possible to the pref itself? Okay > Just curious too if this supports denying renewal on an empty string? If so, > the conversion from undef to empty string might not be what we want. Okay, can use "" or NULL for specific now (see the pref explanation) > Changing status. Please make some adjustments. Improved, squashed, sent back for SO -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #25 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 70632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70632&action=ed… Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #24 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 70631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70631&action=ed… Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #23 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 70630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70630&action=ed… Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68146|0 |1 is obsolete| | Attachment #68147|0 |1 is obsolete| | Attachment #68148|0 |1 is obsolete| | Attachment #68149|0 |1 is obsolete| | Attachment #70295|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 70629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70629&action=ed… Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

1 0