October 2018 - Koha-bugs - lists.koha-community.org

[Bug 16666] New: TagsExternalDictionary is a rather confusing preference name
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16666 Bug ID: 16666 Summary: TagsExternalDictionary is a rather confusing preference name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com You do not pass an external dictionary (file) into this syspref. You actually pass the location of ispell on your box. If you have ispell but do not enter its path here, the pref does not trigger the spell check. So it is also enable/disable ispell. Tags.pm requires the Ispell module; it is not a mandatory depends. Furthermore the pref description says: Allow tags in the dictionary of the ispell executable on the server to be approved without moderation. So I would not mind a better name :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 21436] New: Switch two-column templates to Bootstrap grid: Tools part 4
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21436 Bug ID: 21436 Summary: Switch two-column templates to Bootstrap grid: Tools part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 20654 These two-column tools templates can be updated to use the Bootstrap grid. - tools/scheduler.tt - tools/showdiffmarc.tt - tools/stage-marc-import.tt - tools/upload-images.tt - tools/upload.tt - tools/viewlog.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15899] New: Remove the use of recordpayment
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Bug ID: 15899 Summary: Remove the use of recordpayment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org With recordpayment now simply being a wrapper round Koha::Account::pay, we can remove the calls to recordpayment and replace them with direct calls to Koha::Account::pay. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 18580] New: Account-pay does not apply credits / clear old fines as did recordpayment
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580 Bug ID: 18580 Summary: Account-pay does not apply credits / clear old fines as did recordpayment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com the recordpayment routine in C4::Accounts cleared old paid fines and applied credit amounts as part of its pay routine. The behaviour was implicit and not signalled or commented in the code. The pay routine in Koha::Account which is now called by paycollect.pl instead of the old routine does not leaving these on the users fine display although they owe 0. Staff cannot manually remove these. For example a user has the following accountlines +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | +-----------+-------------+-------------------+ after recordpayment has been called with an amount of 0.65 the lines are +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ However now calling Account->pay for the same amount results in +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ leaving the credit and two fines with an amountoutstanding although the user has nothing to pay (the amountoutstanding columns sum to 0) and leading to misleading displays. The difference is driven by the line where @outstanding_fines is retrieved the selection is amountoutstanding > 0. In recordpayment it was amountoutstanding <> 0 so that negative amounts were included and processed as part of the payment, rather than ignored. The fact that this implicit behaviour was not commented made it easy to miss. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 21334] New: Add bibliographic content type definitions
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334 Bug ID: 21334 Summary: Add bibliographic content type definitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Biblio and authority records need some content-type definitions to be added to the Mojolicious startup code: - 'application/marcxml+xml' - 'application/marc-in-json' - 'application/marc' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 20572] New: Refactor AddIssuingCharges parameter to hashref
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20572 Bug ID: 20572 Summary: Refactor AddIssuingCharges parameter to hashref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Jonathan Druart requested no refactor patches on major+ bugs be done. This does a rework of the parameters in bug 20562. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 18531] New: REST api: Add an endpoint for use by GOBI
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '19

09 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Bug ID: 18531 Summary: REST api: Add an endpoint for use by GOBI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org GOBI (formely YBP) is an aquisitions management system. It handles most of the acquisitions workflow, and traditionally generated MARC files to be included on the institution's library systems. Those files were usually served on an FTP server, for the institution to download and import on their ILS. GOBI implemented what they call GOBIapi, which is a simple workflow for them to directly inject that acquisitions information and resulting records through the use of webservices. In Koha, this means having an endpoint accepting GOBI order messages (in their documented XML format) and have it follow the internal Koha workflow for baskets: - Create a basket - Fill it with the record and budget information, etc - Close the basket and mark it as received. - Deal with the received MARC data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 21407] New: Can't enter new macros in the advanced cataloging editor (rancor)
by bugzilla-daemon＠bugs.koha-community.org 08 Jan '19

08 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Bug ID: 21407 Summary: Can't enter new macros in the advanced cataloging editor (rancor) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Seems to be a styling issue - if I remove 'flex' from the css using the inspector the box appears to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 21686] New: Koha::Account->pay has no tests
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21686 Bug ID: 21686 Summary: Koha::Account->pay has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 15912] New: Correct JSHint errors in acq.js
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15912 Bug ID: 15912 Summary: Correct JSHint errors in acq.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: koha-bugs(a)lists.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in datatables.js koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 35, col 58, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 45, col 19, Use '===' to compare with 'true'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 50, col 33, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 56, col 26, Use '===' to compare with 'true'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 56, col 51, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 58, col 26, Use '===' to compare with 'true'. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 63, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 81, col 9, 'iDelay' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 113, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 136, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 454, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 460, col 2, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 548, col 23, Don't make functions within a loop. koha-tmpl/intranet-tmpl/prog/en/js/datatables.js: line 555, col 6, Unnecessary semicolon. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

1 2