October 2018 - Koha-bugs - lists.koha-community.org

[Bug 19753] New: Move template JavaScript to the footer: Acquisitions
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '18

12 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Bug ID: 19753 Summary: Move template JavaScript to the footer: Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some of the acquisitions templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 21615] New: "Stock rotation" is at the wrong place in the Tools left side menu
by bugzilla-daemon＠bugs.koha-community.org 08 Dec '18

08 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21615 Bug ID: 21615 Summary: "Stock rotation" is at the wrong place in the Tools left side menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org I noticed "Stock rotation" is in the "Patrons and circulation" section of the left-hand side menu when we are on the stock rotation page. To reproduce: 1) Activate the stock rotation module in system preferences 2) Go to Tools 3) Notice the "Stock rotation" link is in the "Catalog" section 4) Click on "Stock rotation" 5) Notice the "Stock rotation" link is in the "Patrons and circulation" section in the left-hand side menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 21675] New: Unable to add to a basket with ElasticSearch enabled
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '18

07 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21675 Bug ID: 21675 Summary: Unable to add to a basket with ElasticSearch enabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Found when testing Bug 16939. To reproduce: Set SearchEngine syspref to Elasticsearch Go to Acquisitions and find a basket Add an order to the basket from an existing record Confirm error Message in error logs: neworderbiblio.pl: [NoNodes] ** No nodes are available: [http://localhost:9200] called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/perl5/Catmandu/Store/ElasticSearch.pm line 27. at /home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch.pm line 437., referer: http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl neworderbiblio.pl: Unable to perform your search. Please try again., referer: http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 20157] New: Use group 'features' to decide which groups to use for group searching functionality
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Bug ID: 20157 Summary: Use group 'features' to decide which groups to use for group searching functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 16735, 20133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 [Bug 20133] "Hide patron information" feature should not affect all library groups -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 21581] New: Matching rules for authorities do not respect 'Search index' setting
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Bug ID: 21581 Summary: Matching rules for authorities do not respect 'Search index' setting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When 'Search index' is passed to C4/AuthoritiesMarc.pm it is matched against a preset list, then defaulted to all - we should allow to pass through arbitrary indexes To recreate: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 20261] New: No result in some page in authority search opac and pro (ES)
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Bug ID: 20261 Summary: No result in some page in authority search opac and pro (ES) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: claire.hernandez(a)biblibre.com How I reproduce this issue: * apply bug 17373 (auth unimarc mapping) * mappings.pl?op=reset&i_know_what_i_am_doing=1 * reindex autorities - ex: rebuild -a -v -d * authority search in opac or pro, looking for a term used * page 1 => OK, I see results * clic on page 2 => OK, I see results * clic on page 3 => KO, no result * clic on the lasty page displayed => KO (another), with an error ==> error.log <== [Wed Feb 21 10:30:11 2018] authorities-home.pl: [Request] ** [http://elastic:80]-[500] {"error":{"root_cause":[{"type":"query_phase_execution_exception","reason":"Result window is too large, from + size must be less than or equal to: [10000] but was [10020]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level setting."}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":"koha_maedi_authorities","node":"hhR2RjsnSye_jPUnySnMkQ","reason":{"type":"query_phase_execution_exception","reason":"Result window is too large, from + size must be less than or equal to: [10000] but was [10020]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level setting."}}]},"status":500}, called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/perl5/Catmandu/Store/ElasticSearch/Bag.pm line 167. With vars: {'status_code' => 500,'request' => {'method' => 'GET','path' => '/koha_maedi_authorities/data/_search','serialize' => 'std','body' => {'size' => 20,'from' => 10000,'sort' => [{'Heading__sort.phrase' => 'asc'}],'query' => {'bool' => {'should' => [{'match' => {'Heading-Main' => 'de'}}]}}},'qs' => {},'mime_type' => 'application/json','ignore' => []}} [Wed Feb 21 10:30:11 2018] authorities-home.pl: Unable to perform your search. Please try again. I don't know if it is a mapping problem or a page management issue in authority search. To be investigated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 18900] New: Receiving order with unitprice multiples by 1000
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Bug ID: 18900 Summary: Receiving order with unitprice multiples by 1000 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define , as decimal and so multiple price value by 1000. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 18471] New: Receiving order with unitprice greater than 1000 processing incorrectly
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Bug ID: 18471 Summary: Receiving order with unitprice greater than 1000 processing incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Two problems here really: Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total To recreate: 1 - Open a basket 2 - Place an order for an item with price > 1000, $4367.00 for example 3 - Close basket 4 - Receive order 5 - Note on orderreceive.pl the price is populate as "4,367.00" 6 - Receive/Save 7 - Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8 - Cancel receipt 9 - Receive again, this time enter price as "4367" 10 - Receive/save 11 - Note actual cost is correct 12 - Finish receiving 13 - Note invoice reads total as $4.00 14 - Check db - price in aqorders is correct but displaying incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 21186] New: Incorrect Bootstrap modal event name in multiple templates
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186 Bug ID: 21186 Summary: Incorrect Bootstrap modal event name in multiple templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org When we upgraded Bootstrap in the staff client we missed updating some references to Bootstrap's "hidden" event. It should now be "hidden.bs.modal." $("#marcPreview").on("hidden.bs.modal", function(){ // Action triggered when modal is closed }); -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 19933] New: Move C4::Members:: patronflags to the Koha namespace - part 1
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Bug ID: 19933 Summary: Move C4::Members::patronflags to the Koha namespace - part 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org C4::Members::patronflags does a lot of things and most of the time they are not even used by the callers. We should split this subroutine and fetch only the data we need. -- You are receiving this mail because: You are watching all bug changes.

1 46