November 2018 - Koha-bugs - lists.koha-community.org

[Bug 21490] New: Disambiguation of "Order"
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21490 Bug ID: 21490 Summary: Disambiguation of "Order" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr "Order" is translatable in different ways in French * "Order" as in "Rank" (noun) * "Order" as in "To rank" (verb) * "Order" as in "To place an order with a vendor" (verb) * "Order" as in "Order with a vendor" (noun) in the *-staff-prog.po file, there are three instances where "Order" is used in different contexts #: intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt:89 #: intranet-tmpl/prog/en/modules/acqui/transferorder.tt:68 #: intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt:58 #: intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt:60 #: intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:112 #: intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:118 #: intranet-tmpl/prog/en/modules/acqui/spent.tt:30 #: intranet-tmpl/prog/en/modules/acqui/basket.tt:355 #: intranet-tmpl/prog/en/modules/acqui/basket.tt:538 #: intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt:81 #, c-format msgid "Order" msgstr "Ordre" #: intranet-tmpl/prog/en/modules/acqui/ordered.tt:30 #: intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt:73 #: intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt:74 #, c-format msgid "Order " msgstr "Commande" #: intranet-tmpl/prog/en/modules/acqui/transferorder.tt:16 #, c-format msgid "Order: " msgstr "Commande :" These should be "Order" as in "Rank" (noun) * marc_modification_templates.tt These should be "Order" as in "To place an order with a vendor" (verb) * newordersuggestion.tt * z3950_search.tt * newordersubscription.tt * neworderbiblio.tt These should be "Order" as in "Order with a vendor" (noun) * transferorder.tt * spent.tt * basket.tt * uncertainprice.tt * ordered.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 21583] New: Novelist Select staff client not working in staff client - ns2init.js not loading
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Bug ID: 21583 Summary: Novelist Select staff client not working in staff client - ns2init.js not loading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 21552] New: RoutingListNote should use raw filter and display HTML unescaped
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Bug ID: 21552 Summary: RoutingListNote should use raw filter and display HTML unescaped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com The routing list note as visible on the routing list preview is supposed to work like other HTML notes and display rendered unescaped HTML. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 21749] New: Importing MARC frameworks from pre-9701 fails
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Bug ID: 21749 Summary: Importing MARC frameworks from pre-9701 fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If you import a MARC framework that has been exported from a previous version of Koha (17.11 and below) results in an empty MARC framework, without any error reporting to the end user. This is because of the added columns in 'marc_tag_structure' (ind1_defaultvalue and ind2_defaultvalue) and the fact that we don't have a fallback behaviour when they are not present on the uploaded file. My opinion is we should check the table header (from CSV or whatever format) and let the DB use the default values if a column is missing. I mark it as Major, because there's no possible data recovery after the failed import. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #434 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #433) > Created attachment 82704 [details] [review] > Bug 7143: Update Fridolin Somers in about page > > OpenHub link was wrong and add 17.11 Release Maintainer. Fridolin: Correct OpenHub separately please. The changes for the release teams are done in batch. Do not change individually. You are listed as 17.11 rmaint in the release team section. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 21282] New: Ordered lists should use ecost tax incl for calculations
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 Bug ID: 21282 Summary: Ordered lists should use ecost tax incl for calculations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The order list for each fund calculates using the ecost tax excl., but it should be tax incl. At the moment this means that the sum on the start page table and the order list don't match up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #433 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Created attachment 82704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82704&action=ed… Bug 7143: Update Fridolin Somers in about page OpenHub link was wrong and add 17.11 Release Maintainer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 17597] New: Outdated translation credits
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17597 Bug ID: 17597 Summary: Outdated translation credits Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: nengard(a)gmail.com Reporter: dimantonak(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It seems that the translation credits are outdated. I was wondering if I have to post an email asking for the names of the recent contributors or is there another procedure that has to be done. Furthermore, as far as I understand, changes should take place to the following file: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/about.tt plus to every language's po file at /usr/share/koha/misc/translator/po/. Is that correct? -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 21787] New: GetHardDueDate.t has a silly test
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21787 Bug ID: 21787 Summary: GetHardDueDate.t has a silly test Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org When a new column is added to the issuingrules table, one of the test from GetHardDueDate.t is failing. As it does not test anything useful we should remove it instead of fixing it. See commit face7819393b17a3fb4bab6f8c2ff26cc9a450d8 Author: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Date: Thu Nov 8 11:15:04 2018 -0300 Bug 12365: Fix GetHardDueDate.t test diff --git a/t/db_dependent/Circulation/GetHardDueDate.t b/t/db_dependent/Circulation/GetHardDueDate.t index a50e06b..bfb624d 100644 --- a/t/db_dependent/Circulation/GetHardDueDate.t +++ b/t/db_dependent/Circulation/GetHardDueDate.t @@ -148,6 +148,7 @@ my $sampleissuingrule1 = { no_auto_renewal_after_hard_limit => undef, suspension_chargeperiod => 1, holds_per_day => undef, + note => undef, }; my $sampleissuingrule2 = { branchcode => $samplebranch2->{branchcode}, commit 1ce984ea1dd12391d39507cd21c4d3813eab9754 Author: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Date: Wed Oct 24 17:08:05 2018 -0300 Bug 15486: Fix failing test in GetHardDueDate.t Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> diff --git a/t/db_dependent/Circulation/GetHardDueDate.t b/t/db_dependent/Circulation/GetHardDueDate.t index b39c32c..a50e06b 100644 --- a/t/db_dependent/Circulation/GetHardDueDate.t +++ b/t/db_dependent/Circulation/GetHardDueDate.t @@ -147,6 +147,7 @@ my $sampleissuingrule1 = { no_auto_renewal_after => undef, no_auto_renewal_after_hard_limit => undef, suspension_chargeperiod => 1, + holds_per_day => undef, }; my $sampleissuingrule2 = { branchcode => $samplebranch2->{branchcode}, commit f32cf00e132c747a008163e5f40810d4a47bff58 Author: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Date: Mon Apr 9 17:33:37 2018 -0300 Bug 19804: Fix test in GetHardDueDate.t Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> diff --git a/t/db_dependent/Circulation/GetHardDueDate.t b/t/db_dependent/Circulation/GetHardDueDate.t index b5a571b..b39c32c 100644 --- a/t/db_dependent/Circulation/GetHardDueDate.t +++ b/t/db_dependent/Circulation/GetHardDueDate.t @@ -146,6 +146,7 @@ my $sampleissuingrule1 = { article_requests => 'yes', no_auto_renewal_after => undef, no_auto_renewal_after_hard_limit => undef, + suspension_chargeperiod => 1, }; my $sampleissuingrule2 = { branchcode => $samplebranch2->{branchcode}, -- You are receiving this mail because: You are watching all bug changes.

1 8