February 2018 - Koha-bugs - lists.koha-community.org

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #59 from Charles Farmer <charles.farmer(a)inlibro.com> --- Freshly rebased. To facilitate future git apply, Z3950Server.pm was regenerated. Field `attributes` now sits under `sru_fields` and `add_xslt` with longtext, instead of the previous mediumtext that conflicted with the master's version of the Schema. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70196|0 |1 is obsolete| | --- Comment #58 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71994&action=ed… Bug 11297: QA follow-up - Avoid carrying server attributes As it was pointed out, concatenating server attributes on a variable above the foreach loop meant carrying those attributes through every other queries. With a variable local to the loop, we can now send each server its specific zquery. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70195|0 |1 is obsolete| | --- Comment #57 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71993&action=ed… Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70194|0 |1 is obsolete| | --- Comment #56 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71992&action=ed… Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> New sign-off, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #27 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71988&action=ed… Bug 12001: (QA follow-up) Fix showing links to items on boraccount page Test plan: Go to the Fines -> Account page of a patron with fees linked to items --> without patch there is no link to related item --> with patch the link is presented in description column Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #26 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71987&action=ed… Bug 12001: (QA follow-up) Fix patron account summary print Test plan: Try to print patron account summary --> without patch it explodes --> with patch it works, and if there is a fee related to item, the title should be printed out Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #25 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71986&action=ed… Bug 12001: (QA follow-up) Add test for Koha::Account::Lines object Test plan prove t/db_dependent/Koha/Account/Lines.t --> should be green Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #24 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71985&action=ed… Bug 12001: (QA follow-up) Fix printinvoice page Test plan: Try to print a fee --> without patch it explodes --> with patch it works and the date is formatted according to system wide date format setting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #23 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71984&action=ed… Bug 12001: (QA follow-up) Explicit return Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #22 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71983&action=ed… Bug 12001: Format DEBT correctly Before this patchset, DEBT was formatted in the module, now it should be done template-side. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0