February 2018 - Koha-bugs - lists.koha-community.org

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #21 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71982&action=ed… Bug 12001: Prove that result are the same \o/ Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #20 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71981&action=ed… Bug 12001: Move GetMemberAccountBalance to Koha::Account->non_issues_charges As said previously, GetMemberAccountBalance returns ( the balance, the non issues charges, the other charges) The other charges are the balance - the non issues charges. In this patch we remove the subroutine from C4::Members and use the new Koha::Account->non_issues_charges subroutine instead Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #19 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71980&action=ed… Bug 12001: Add tests Yes, we need tests to make sure we understand what is going on in this subroutine. The different combination of HoldsInNoissuesCharge, RentalsInNoissuesCharge and ManInvInNoissuesCharge are tested here with the subroutine we are going to remove (GetMemberAccountBalance). In one of the next patches the new methods will be used to make sure we are not modifying the calculated values (except the formatting). Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71852|0 |1 is obsolete| | Attachment #71853|0 |1 is obsolete| | Attachment #71854|0 |1 is obsolete| | Attachment #71855|0 |1 is obsolete| | Attachment #71856|0 |1 is obsolete| | Attachment #71857|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71979&action=ed… Bug 12001: Move GetMemberAccountRecords to the Koha namespace The GetMemberAccountRecords may be a perf killer, it retrieves all the account lines of a patron and then the related item and biblio information. Most of the time we only want to know how much the patron owns to the library (sum of amountoutstanding). We already have this information in Koha::Patron->account->balance. This patch replaces the occurrences of this subroutine by fetching only the information we need, either the balance, the detail, or both. It removes the formatting done in the module, to use the TT plugin 'Price' instead. There is a very weird and error-prone behavior/feature in GetMemberAccountBalance (FIXME): as the accountlines.accounttype is a varchar(5), the value of the authorised value used for the ManInvInNoissuesCharge pref (category MANUAL_INV) is truncated to the 5 first characters. That could lead to unexpected behaviors. On the way, this patchset also replace the GetMemberAccountBalance subroutine, which returns the balance, the non issues charges and the other charges. We only need to have the balance and the non issues charges to calcul the third one. Test plan: Add several fees for a patron and play with HoldsInNoissuesCharge, RentalsInNoissuesCharge and ManInvInNoissuesCharge. The information (biblio and item info, as well as the account line) must be correctly displayed on the different screens: 'Fines' module, fine slips, circulation module Note that this patchset could introduce regression on price formatting, but will be easy to fix using the TT plugin. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '18

20 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #58 from Roch D'Amour <roch.damour(a)inlibro.com> --- (In reply to Jonathan Druart from comment #57) > You are re-adding subroutines that have been removed from the codebase, this > is definitely the wrong way. Use the new methods added to the Koha modules > instead. Do you mean removing GetNoticeEmailAddress from C4 Members entirely and applying the same changes somewhere else? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Amit Gupta <amitddng135(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Amit Gupta <amitddng135(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #7 from Amit Gupta <amitddng135(a)gmail.com> --- (In reply to Vinod from comment #6) > My idea is: > > 1. At the time of creating category a option " Can place purchase suggesion" > Yes/No > > 2. While login on OPAC member should not see purchase suggesion option if he > can see than while clicking the message it should display "you are not > authorised to place purchage suggesion" > > 3. Any direct link to purchase suggesion should not work for concern > category through opac > > 4. Staff can still place order on his behalf as usual through koha staff > client > > 5. Any other impact we have to see if any Seems good idea but main concern how current purchase suggestion preference will handle. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Charles Farmer <charles.farmer(a)inlibro.com> --- Hi Katrin, Following your comments, I made cosmetic adjustments to the previous patch: - <span> no longer present in alert dialog - I also toned down from 'exclamation mark' to a simple period - removed the dangling space before ':' - server side formatting was changed from sprintf to $Price - I also removed the formatting in the <input> fields. It made no sense to me that formatting was used for data traveling between the page and the server, unbeknown to the user. About the behavior of the form: I agree with you, the UX should definitely be more user-friendly. Now, I'm open to changes, but I'd rather implement everything once we reach a consensus on how it should behave than doing "flavors" of the same patch just for QA. Nothing personal ;) I'll put this back to 'Needs signoff', for now, just to make it clear that I want people testing this patch, but feel free to dial it back to "Failed QA" or "In discussion". I'll be keeping a close eye on this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #32 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 71976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71976&action=ed… Bug 11373: Follow-up after code review -- You are receiving this mail because: You are watching all bug changes.

1 0