April 2018 - Koha-bugs - lists.koha-community.org

[Bug 18900] New: Receiving order with unitprice multiples by 1000
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Bug ID: 18900 Summary: Receiving order with unitprice multiples by 1000 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define , as decimal and so multiple price value by 1000. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 18471] New: Receiving order with unitprice greater than 1000 processing incorrectly
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Bug ID: 18471 Summary: Receiving order with unitprice greater than 1000 processing incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Two problems here really: Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total To recreate: 1 - Open a basket 2 - Place an order for an item with price > 1000, $4367.00 for example 3 - Close basket 4 - Receive order 5 - Note on orderreceive.pl the price is populate as "4,367.00" 6 - Receive/Save 7 - Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8 - Cancel receipt 9 - Receive again, this time enter price as "4367" 10 - Receive/save 11 - Note actual cost is correct 12 - Finish receiving 13 - Note invoice reads total as $4.00 14 - Check db - price in aqorders is correct but displaying incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 19933] New: Move C4::Members:: patronflags to the Koha namespace - part 1
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Bug ID: 19933 Summary: Move C4::Members::patronflags to the Koha namespace - part 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org C4::Members::patronflags does a lot of things and most of the time they are not even used by the callers. We should split this subroutine and fetch only the data we need. -- You are receiving this mail because: You are watching all bug changes.

1 46

[Bug 15754] New: html tags displayed when editing frameworks
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Bug ID: 15754 Summary: html tags displayed when editing frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618 When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 15733] New: Audio Alerts issues in master
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Bug ID: 15733 Summary: Audio Alerts issues in master Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In master there is a JSON error thrown when AudioAlerts are enabled. When checking in I get: SyntaxError: JSON.parse: expected property name or '}' at line 1 column 3 of the JSON data This does not happen in 3.22 Also (in master and 3.22) single quotes audio selector break ability to edit an alert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 19574] New: Wrong itemtype can be chosen when placing holds
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19574 Bug ID: 19574 Summary: Wrong itemtype can be chosen when placing holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.hedstrom.mace(a)sub.su.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com With the syspref AllowHoldItemTypeSelection set to Allow, it is possible to add a hold for an itemtype that doesn’t actually exist at a specific branch. Say that branch A has two itemtypes: books and map, while branch B has three: books, map and audio book. It is possible to add a hold for branch A with itemtype audio book although there is no item with such an itemtype at this branch. This will cause an internal server error if you try to delete this faulty hold. To recreate: 1) Enable AllowHoldItemTypeSelection 2) Add, or find, a bibliographic record with at least two branches and at least two items with two different itemtypes. Branch B should not have all itemtypes. 3) Add a hold for branch B, and choose an itemtype not available at this branch (there are no such items) 4) Try deleting the hold, note the internal server error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 20351] New: Subscription detail page with non-existent subscriptionid shows empty subscription
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351 Bug ID: 20351 Summary: Subscription detail page with non-existent subscriptionid shows empty subscription Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: mbugz2(a)yahoo.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When you go to subscription details, like cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=108 and use a subscriptionid which is not in the subscriptions table you get an empty subscription item, but should get a page telling you the subscription doesn't exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 17597] New: Outdated translation credits
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17597 Bug ID: 17597 Summary: Outdated translation credits Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: nengard(a)gmail.com Reporter: dimantonak(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It seems that the translation credits are outdated. I was wondering if I have to post an email asking for the names of the recent contributors or is there another procedure that has to be done. Furthermore, as far as I understand, changes should take place to the following file: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/about.tt plus to every language's po file at /usr/share/koha/misc/translator/po/. Is that correct? -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 18720] New: Get rid of "die" in favor of exceptions in C4:: Acquisition::GetBasketAsCsv
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 Bug ID: 18720 Summary: Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org See bug 8612: (Marcel de Rooy from comment #110) > And: > die "There is no valid csv profile given" unless $csv_profile; > Being liberal now. But we should actually use Koha::Exceptions now according > to a new rule in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 20592] New: updateitem.pl causes database errors when empty non-public item notes updated
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Bug ID: 20592 Summary: updateitem.pl causes database errors when empty non-public item notes updated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If you go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1&itemnumber=1#item1, and click "Update" next to an empty "Non-public note" field, it will generate a database error. Typically, this is hidden in your Apache logs, but if you have DEBUG turned on, the database error will be fatal. Example logs: [Tue Apr 17 12:43:48.607368 2018] [cgi:error] [pid 1992] [client ...:22158] AH01215: [Tue Apr 17 12:43:48 2018] updateitem.pl: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE itemnumber='1'' at line 1 [for Statement "UPDATE items SET WHERE itemnumber=?" with ParamValues: 0="1"] at ../git/C4/Items.pm line 2038.: ../git/catalogue/updateitem.pl, referer: http://koha/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1&itemnumber=1 [Tue Apr 17 12:43:48.607852 2018] [cgi:error] [pid 1992] [client ...:22158] AH01215: [Tue Apr 17 12:43:48 2018] updateitem.pl: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE itemnumber='1'' at line 1 [for Statement "UPDATE items SET WHERE itemnumber=?" with ParamValues: 0="1"] at ../git/C4/Items.pm line 2038.: ../git/catalogue/updateitem.pl, referer: http://koha/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1&itemnumber=1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27