July 2018 - Koha-bugs - lists.koha-community.org

[Bug 20975] New: Improve auto escaping performance
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975 Bug ID: 20975 Summary: Improve auto escaping performance Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618 On bug 13618 we are trying to get rid of XSS issues with a global solution. Using Template::Stash::AutoEscaping we are going to apply a html filter to all of our template variables. The problem is that we can have thousands of variables displayed (and so escaped). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 15733] New: Audio Alerts issues in master
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Bug ID: 15733 Summary: Audio Alerts issues in master Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In master there is a JSON error thrown when AudioAlerts are enabled. When checking in I get: SyntaxError: JSON.parse: expected property name or '}' at line 1 column 3 of the JSON data This does not happen in 3.22 Also (in master and 3.22) single quotes audio selector break ability to edit an alert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 19574] New: Wrong itemtype can be chosen when placing holds
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19574 Bug ID: 19574 Summary: Wrong itemtype can be chosen when placing holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.hedstrom.mace(a)sub.su.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com With the syspref AllowHoldItemTypeSelection set to Allow, it is possible to add a hold for an itemtype that doesn’t actually exist at a specific branch. Say that branch A has two itemtypes: books and map, while branch B has three: books, map and audio book. It is possible to add a hold for branch A with itemtype audio book although there is no item with such an itemtype at this branch. This will cause an internal server error if you try to delete this faulty hold. To recreate: 1) Enable AllowHoldItemTypeSelection 2) Add, or find, a bibliographic record with at least two branches and at least two items with two different itemtypes. Branch B should not have all itemtypes. 3) Add a hold for branch B, and choose an itemtype not available at this branch (there are no such items) 4) Try deleting the hold, note the internal server error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 20990] New: Add Koha::Account::outstanding_credits
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Bug ID: 20990 Summary: Add Koha::Account::outstanding_credits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This will be handy for the /patrons/{patron_id}/account endpoint. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 30

[Bug 20968] New: Plugins: Add hooks to enable plugin integration into catalogue
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Bug ID: 20968 Summary: Plugins: Add hooks to enable plugin integration into catalogue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org This bug will add Koha Plugin hooks into catalogue related code allowing integration into areas such as koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 75

[Bug 20351] New: Subscription detail page with non-existent subscriptionid shows empty subscription
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351 Bug ID: 20351 Summary: Subscription detail page with non-existent subscriptionid shows empty subscription Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: mbugz2(a)yahoo.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When you go to subscription details, like cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=108 and use a subscriptionid which is not in the subscriptions table you get an empty subscription item, but should get a page telling you the subscription doesn't exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 17597] New: Outdated translation credits
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17597 Bug ID: 17597 Summary: Outdated translation credits Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: nengard(a)gmail.com Reporter: dimantonak(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It seems that the translation credits are outdated. I was wondering if I have to post an email asking for the names of the recent contributors or is there another procedure that has to be done. Furthermore, as far as I understand, changes should take place to the following file: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/about.tt plus to every language's po file at /usr/share/koha/misc/translator/po/. Is that correct? -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 21015] New: Members.pm slow because it loads twice Koha::Schema
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Bug ID: 21015 Summary: Members.pm slow because it loads twice Koha::Schema Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: j.kylmala(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Koha/C4/Members.pm currently loads by itself Koha::Schema using "use Koha::Schema" even though this is not required as we could use Koha::Database that has already done that (another further issue is why does Koha::Database load all the classes in Koha/Schema/Result/ when it could just load the ones that are needed). Loading the Koha::Schema takes for me around 2 seconds on my machine so it would be quite a big performance boost to remove it. I got a 30% faster load time on cgi-bin/koha/members/moremember.pl with a patch I made. I will attach it here but be warned: I have not run any tests and I don't know if it has even syntax errors because I'm doing the patch on a machine without a proper development environment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 20710] New: Update MARC21 frameworks to Update 26 (April 2018)
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Bug ID: 20710 Summary: Update MARC21 frameworks to Update 26 (April 2018) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: bgkriegel(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org New update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 18720] New: Get rid of "die" in favor of exceptions in C4:: Acquisition::GetBasketAsCsv
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 Bug ID: 18720 Summary: Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org See bug 8612: (Marcel de Rooy from comment #110) > And: > die "There is no valid csv profile given" unless $csv_profile; > Being liberal now. But we should actually use Koha::Exceptions now according > to a new rule in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 12