April 2019 - Koha-bugs - lists.koha-community.org

[Bug 21964] New: Switch two-column templates to Bootstrap grid: Patrons part 2
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 Bug ID: 21964 Summary: Switch two-column templates to Bootstrap grid: Patrons part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 20654 These two-column patron templates can be updated to use the Bootstrap grid. - modules/members/maninvoice.tt - modules/members/member-flags.tt - modules/members/member-password.tt - modules/members/member.tt - modules/members/memberentrygen.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 22461] New: Regression in #20287: LDAP user replication broken with mapped extended patron attributes
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Bug ID: 22461 Summary: Regression in #20287: LDAP user replication broken with mapped extended patron attributes Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: oliver.behnke(a)aei.mpg.de QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Reproduce: 1) Use LDAP authentication with user replication 2) Add a field mapping for an extended patron attribute (e.g. MYATTRIB) 3) Try to log in for the first time (new Koha user) 4) Error: "opac-user.pl: DBIx::Class::Row::store_column(): No such column 'MYATTRIB' on Koha::Schema::Result::Borrower at /usr/share/koha/lib/Koha/Object.pm line 75" Presumed cause: Commit [1] changed the way new patrons are created during LDAP replication (first login). The previous implementation (C4::Members::AddMember) took into account extended patron attributes by filtering them out before instantiating the new patron DB object [2]. The current implementation lacks this vital step. I chose a severity of critical because after upgrading from 18.05 to 18.11 no new users are able to log in anymore. Cheers [1] https://github.com/Koha-Community/Koha/commit/a6059c4d2d43e43aa021069ce97d6… [2] https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd38… -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 36

[Bug 22644] New: Some tests in Upload.t are not testing the right thing
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 Bug ID: 22644 Summary: Some tests in Upload.t are not testing the right thing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17501 Target Milestone: --- Wondering if there is not something wrong or missing in t/db_dependent/Upload.t, the keep_file flag is not testing if the file is really kept. Also we are not testing if the files have been correctly created. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 [Bug 17501] Koha Objects for uploaded files -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 16966] New: Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Bug ID: 16966 Summary: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16961, 16965 Blocks: 16846 The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. The patches provided will refactor the code and fix these 2 issues. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 [Bug 16961] Add the Koha::Objects->update method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 [Bug 16965] Add the Koha::Objects->search_related method -- You are receiving this mail because: You are watching all bug changes.

1 79

[Bug 22184] New: Move payment note out of payments table and into payment form
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22184 Bug ID: 22184 Summary: Move payment note out of payments table and into payment form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- >From Comment 14 on Bug 21918: I got confused about the payment note feature. I am wondering, do we need it to be on the payments table? It seems a little confusing as you seem to only be able to save it actually paying a fine. Wouldn't it be enough if the field appeared editable on the actual form? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 19781] New: Make a xt test that checks all themes for missing includes, to avoid fallback
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19781 Bug ID: 19781 Summary: Make a xt test that checks all themes for missing includes, to avoid fallback Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org The fallback functionality of the themes is good, but it is resource intensive if something is really really missing from a theme. For example, a user might make a custom theme for their OPAC, specify a TT include, but not include it in their theme (intentionally, or accidentally). The process of looking through all of the themes to find the fallback causes very slow page loads for that page, we should have a test that theme creators can run to check for this circumstance. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 21547] New: Use update_password in opac-passwd and remove sub goodkey
by bugzilla-daemon＠bugs.koha-community.org 18 May '19

18 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 Bug ID: 21547 Summary: Use update_password in opac-passwd and remove sub goodkey Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 21502] New: Add checks for YAML formatted system preferences to about page
by bugzilla-daemon＠bugs.koha-community.org 18 May '19

18 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Bug ID: 21502 Summary: Add checks for YAML formatted system preferences to about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 22541] New: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl
by bugzilla-daemon＠bugs.koha-community.org 18 May '19

18 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Bug ID: 22541 Summary: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- On ordered.pl and spent.pl, invoice adjustments are shown with a label that gives the invoiceid rather than the invoicenumber. For consistency and clarity, these should show the invoicenumber and link to the invoice page, just like the entries in the Invoice column in the table on these pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 36

[Bug 21308] New: Results from order search do not show the search parameters.
by bugzilla-daemon＠bugs.koha-community.org 18 May '19

18 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Bug ID: 21308 Summary: Results from order search do not show the search parameters. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org A report from one of our partner libraries: "It would be nice if the system told us what our search was. We are often interrupted and then come back and have to get back into our previous work flow. ... it would be nice to see the search parameter explicitly shown in the breadcrumb trail - or somewhere" The breadcrumb trail showed Home › Acquisitions › Orders search › Search results ... and there was no indication of what had been searched for in the URL, or anywhare on the page (aside from implicitly in the returned results). I ran several searches from cgi-bin/koha/acqui/histsearch.pl myself, and confirmed this. To re-create: 1) Navigate to Home › Acquisitions 2) Click on 'Orders Search' under the masthead search bar 3) Search for a title and click 'Submit' 4) Run a browser search for the the title, note that it appears only in the results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18