May 2019 - Koha-bugs - lists.koha-community.org

[Bug 21219] New: NULL values in updated_on field break the Patrons REST API
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21219 Bug ID: 21219 Summary: NULL values in updated_on field break the Patrons REST API Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)jsense.co.uk The swagger definition does not allow for updated_on to be NULL but the database does allow this. If a patron has a null value then the REST service call fails. The history of this is as follows: Bug #10459 (released in 16.05.01) - updated_on field added to borrowers table, NULL allowed Bug #17651 (released in 16.11) - fix swagger definition to allow for NULL "updated_on": { - "type": "string", + "type": ["string", "null"], "description": "time of last change could be useful for synchronization with external systems (among others)" }, Bug #16330 (released in 18.05) - removes the null option from the definition "updated_on": { - "type": ["string", "null"], + "type": "string", "format": "date-time", "description": "time of last change could be useful for synchronization with external systems (among others)" }, You can see that the last push undid the previous bug fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 22575] New: Item type administration uses invalid error class for dialog
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Bug ID: 22575 Summary: Item type administration uses invalid error class for dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- If you try to delete an item type which is in use, the error message you get is displayed in a white dialog with red text. This happens because the message "type" passed from the script is "error," a CSS class which is undefined. The script should send "alert" instead. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 22444] New: currencies_manage permission doesn't provide link to manage currencies when selected alone
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Bug ID: 22444 Summary: currencies_manage permission doesn't provide link to manage currencies when selected alone Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Bug 7651 added the permission currencies_manage within the acquisitions permission subgroup. Giving a borrower just this permission and catalogue does make them technically able to load /currency.pl, but it doesn't provide them any link to get there. To Test: - create a patron - give them currencies_manage and catalogue permissions - log in as this patron - observe that there is no Currencies link out of Acquisitions and Administration doesn't appear on the home page or the More menu - give the patron any other admin permission - observe that the Currencies link now shows in Acquisitions - take away admin permissions and give the patron full acquisitions permissions - observe that a link to Currencies still appears in Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 21089] New: Bad floats in Ordering information on acqui/supplier.pl
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089 Bug ID: 21089 Summary: Bad floats in Ordering information on acqui/supplier.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org I haven’t checked master yet, but in the 17.xx versions, I’m noticing it is really difficult to click the dropdown for “List prices are:” in “Ordering information” on /cgi-bin/koha/acqui/supplier.pl. When I look using the F12 tools in Chrome, I see that later “ol” elements are overlapping earlier “li” elements. So the “ol” for the tax options is sitting on top of the “li” for “List prices are:”. Only a tiny part of the “li” is clickable underneath that “ol”. It looks like the floats in the “li” element are causing the sizing of the “ol” to be no good. See https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_con…. There are a number of strategies for fixing this but I’m not sure what the best one would be here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 22560] New: Forgotten password "token expired" page still shows boxes to reset password
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Bug ID: 22560 Summary: Forgotten password "token expired" page still shows boxes to reset password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: wizzyrea(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- To replicate: Create a user with a username, password, and email defined Attempt to do a forgotten password recovery Munge your token link in whatever way you like (?uniqueKey=$2a$08$B9szbC5lwJd.mh.QznRHZu for example - this one should be invalid in your DB) Note that a yellow "This link is expired" box is shown, but the two password boxes are still there. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 18011] New: Categories.pl allows users to set the enrolementperioddate to before the current date without any error /warning messages
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Bug ID: 18011 Summary: Categories.pl allows users to set the enrolementperioddate to before the current date without any error/warning messages Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P3 Component: System Administration Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com At present when creating a patron category the user can select a date from the date picker which is earlier than the current date, meaning patrons created from the patron category have a dateexpire before they were even created. The fix of this bug is to implement a javascript message informing the user that the date they selected from the datepicker is invalid and forcing them to choose a new date before they can submit the form. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 22680] New: OPAC language footer not positioned correctly
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Bug ID: 22680 Summary: OPAC language footer not positioned correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 87727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87727&action=ed… Screenshot showing the desired layout The language footer in the OPAC is supposed to appear at the bottom of the screen if there is not enough content to require scrolling to reach the bottom. Instead the language footer is always just below the visible area. I will submit a patch to correct this. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 22561] New: Forgotten password "password requirements" box doesn't list all of the rules that are in effect for new passwords
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Bug ID: 22561 Summary: Forgotten password "password requirements" box doesn't list all of the rules that are in effect for new passwords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: wizzyrea(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The blue box on the password recovery page that tells users what requirements new passwords must have doesn't show all of the rules that might be in effect. The infobox currently only shows the length requirements and should show the requirements enacted by RequireStrongPassword, if that is set. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 16231] New: Correct permission handling in subscription edit menu
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Bug ID: 16231 Summary: Correct permission handling in subscription edit menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-detail.pl?subscript ionid=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com The "Edit" toolbar menu for serials contains three items, "Edit subscription," "Edit as new (duplicate)" and "Delete subscription." Each item should be wrapped in its own check for the "CAN_user_serials_*" permission. -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 22716] New: Use gender-neutral pronouns in system preference descriptions
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22716 Bug ID: 22716 Summary: Use gender-neutral pronouns in system preference descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 18432 Target Milestone: --- In Bug 18432 we standardized on using gender-neutral "they/them" pronouns in Koha. We missed a couple of instances in system preference descriptions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 [Bug 18432] Most code comments assume male gender -- You are receiving this mail because: You are watching all bug changes.

1 11