May 2019 - Koha-bugs - lists.koha-community.org

[Bug 22679] New: circulation_rules are not deleted when accompanying issuingrules are deleted
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22679 Bug ID: 22679 Summary: circulation_rules are not deleted when accompanying issuingrules are deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- To recreate: 1 - Browse to Administration ->Circulation and fines 2 - Add a rule with a number for 'Total checkouts allowed' 3 - check the db: select * from circulation_rules 4 - The rule should be there 5 - Delete the rule from the staff interface 6 - Check the DB 7 - The rule is not deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 22759] New: Circulation rules for maxissueqty are applied per branch even for defaults
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 Bug ID: 22759 Summary: Circulation rules for maxissueqty are applied per branch even for defaults Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- To test: 1 - Find a title in the catalog, add 8 items, all of a single itemtype, 4 for branch A, four for branch B 2 - Remove any specific circ rules 3 - Set a default circ rule for the itemtype used above, limiting the max issue quantity to 3 4 - Find a patron and checkout the items from branch A 5 - You should be allowed ot checkout 3, but the fourth should trigger 'too many' 6 - Now checkout the items from branch B, again you can checkout 3 and not four 7 - You shouldn't be allowed 3 from each library :-( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 22619] New: Adding a new circ rule with unlimited checkouts is broken
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Bug ID: 22619 Summary: Adding a new circ rule with unlimited checkouts is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- On bug 18925 we missed a case of fixing null/empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 22489] New: Onboarding tool fails due to inserting maxissueqty into IssuingRule
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Bug ID: 22489 Summary: Onboarding tool fails due to inserting maxissueqty into IssuingRule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: hayleymapley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- When going through the onboarding process, the tool fails on submit of Step 5 - creating an issuing rule. This is due to the maxissueqty column having been removed from the IssuingRules table and added to the CirculationRules table but redundant code still exists in onboarding.pl. As you can see below the maxissueqty variable is being added to the params hash which is used to make the new issuing rule. if ( $step == 5 ) { if ( $op eq 'add_validate_circ_rule' ) { #If no libraries exist then set the $branch value to * my $branch = $input->param('branch') || '*'; my $type = $input->param('type'); my $branchcode = $input->param('branch'); my $categorycode = $input->param('categorycode'); my $itemtype = $input->param('itemtype'); my $maxissueqty = $input->param('maxissueqty'); my $issuelength = $input->param('issuelength'); my $lengthunit = $input->param('lengthunit'); my $renewalsallowed = $input->param('renewalsallowed'); my $renewalperiod = $input->param('renewalperiod'); my $onshelfholds = $input->param('onshelfholds') || 0; $maxissueqty =~ s/\s//g; $maxissueqty = undef if $maxissueqty !~ /^\d+/; $issuelength = $issuelength eq q{} ? undef : $issuelength; my $params = { branchcode => $branchcode, categorycode => $categorycode, itemtype => $itemtype, maxissueqty => $maxissueqty, renewalsallowed => $renewalsallowed, renewalperiod => $renewalperiod, issuelength => $issuelength, lengthunit => $lengthunit, onshelfholds => $onshelfholds, }; my $issuingrule = Koha::IssuingRule->new($params); eval { $issuingrule->store; }; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 22954] New: Minor markup error in OPAC messaging template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Bug ID: 22954 Summary: Minor markup error in OPAC messaging template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- There is a minor markup error in the OPAC's "your messaging" template (opac-messaging.tt). This triggers an error in the HTML validator: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 22952] New: Markup error in OPAC suggestions template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Bug ID: 22952 Summary: Markup error in OPAC suggestions template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Target Milestone: --- There is a markup error in the OPAC suggestions template (opac-suggestions.tt) which is causing a validation errors: - "End tag div seen, but there were open elements." - "Unclosed element span." -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 22948] New: Markup error in OPAC bibliographic detail template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Bug ID: 22948 Summary: Markup error in OPAC bibliographic detail template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- There are quite a few validation errors coming from the OPAC detail template (opac-detail.tt), but I would like to address one with this patch: - "The aria-labelledby attribute must point to an element in the same document." -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 22099] New: "List requests" button displays when listing requests
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Bug ID: 22099 Summary: "List requests" button displays when listing requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Target Milestone: --- On the main ILL Requests page that lists all requests ("illlist" action), the "List request" button is displayed, which makes no sense since we're already listing requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 22955] New: Markup error in OPAC lists template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Bug ID: 22955 Summary: Markup error in OPAC lists template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Target Milestone: --- There is a minor markup error in the OPAC lists template: A missing "alt" attribute. It triggers this error: - "An img element must have an alt attribute, except under certain conditions." -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 22947] New: Markup error in OPAC preferences file
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Bug ID: 22947 Summary: Markup error in OPAC preferences file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- opac.pref contains a markup error which can cause errors in the display. On line 124: <code>OpenURLText<code> Should be: <code>OpenURLText</code> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13