October 2020 - Koha-bugs - lists.koha-community.org

[Bug 26186] New: Remove "subroutine redefined" warnings from tests
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '25

23 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26186 Bug ID: 26186 Summary: Remove "subroutine redefined" warnings from tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/cronjobs/advance_notices_digest.t t/db_dependent/cronjobs/advance_notices_digest.t .. No circulation PREDUEDGST letter transported by phone at /kohadevbox/koha/C4/Letters.pm line 605. Use of uninitialized value in concatenation (.) or string at (eval 1565) line 587. no letter of type '' found for borrowernumber 58. Please see sample_notices.sql at (eval 1565) line 587. t/db_dependent/cronjobs/advance_notices_digest.t .. 1/2 Subroutine parse_letter redefined at (eval 1572) line 444. Subroutine get_branch_info redefined at (eval 1572) line 481. Subroutine send_digests redefined at (eval 1572) line 532. No circulation PREDUEDGST letter transported by phone at /kohadevbox/koha/C4/Letters.pm line 605. Use of uninitialized value in concatenation (.) or string at (eval 1572) line 587. no letter of type '' found for borrowernumber 59. Please see sample_notices.sql at (eval 1572) line 587. No circulation PREDUEDGST letter transported by phone at /kohadevbox/koha/C4/Letters.pm line 605. Use of uninitialized value in concatenation (.) or string at (eval 1572) line 587. no letter of type '' found for borrowernumber 59. Please see sample_notices.sql at (eval 1572) line 587. t/db_dependent/cronjobs/advance_notices_digest.t .. ok All tests successful. Files=1, Tests=2, 5 wallclock secs ( 0.02 usr 0.01 sys + 3.34 cusr 1.38 csys = 4.75 CPU) Result: PASS kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Auth_with_ldap.t t/db_dependent/Auth_with_ldap.t .. 1/4 Subroutine ldapserver_error redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 48. Subroutine description redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 80. Subroutine search_method redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 87. Subroutine checkpw_ldap redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 111. Subroutine ldap_entry_2_hash redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 261. Subroutine exists_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 312. Subroutine _do_changepassword redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 338. Subroutine update_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 369. Subroutine ldapserver_error redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 48. Subroutine description redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 80. Subroutine search_method redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 87. Subroutine checkpw_ldap redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 111. Subroutine ldap_entry_2_hash redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 261. Subroutine exists_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 312. Subroutine _do_changepassword redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 338. Subroutine update_local redefined at /kohadevbox/koha/C4/Auth_with_ldap.pm line 369. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 26157] New: Redirect expected DBI warnings
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '25

23 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26157 Bug ID: 26157 Summary: Redirect expected DBI warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org We should not display DBI warnings from tests when they are expected. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 26417] New: Remove warn in Koha::Patron is_valid_age
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '25

23 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26417 Bug ID: 26417 Summary: Remove warn in Koha::Patron is_valid_age Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In Koha::Patron is_valid_age the is a compare : $age < $low But $low may be undef. It generates a warn : Use of uninitialized value $low in numeric lt (<) Needs a test like for $high. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 23685] New: Exporting report may consume unlimited memory
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '25

23 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Bug ID: 23685 Summary: Exporting report may consume unlimited memory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul(a)flo.org QA Contact: testopia(a)bugs.koha-community.org In guided_reports.pl, when exporting report results ($phase eq 'Export') all rows of data are fetched and then converted to the desired format. This may consume an unlimited amount of memory; when report results are particularly large, it may consume all available memory, leading to timed-out HTTP requests, crashes, and potentially data loss. (We have experienced Zebra index corruption as a result.) In master, reports/guided_reports.pl supports three export types -- tab-delimited, CSV, or *.ods. In each case, all data are loaded into memory and held there before any output is produced: 891 $sql = get_prepped_report( $sql, \@param_names, \@sql_params ); 892 my ($sth, $q_errors) = execute_query($sql); ... 895 if ($format eq 'tab') { 896 $type = 'application/octet-stream'; 897 $content .= join("\t", header_cell_values($sth)) . "\n"; 898 $content = Encode::decode('UTF-8', $content); 899 while (my $row = $sth->fetchrow_arrayref()) { 900 $content .= join("\t", @$row) . "\n"; 901 } 902 } else { 903 my $delimiter = C4::Context->preference('delimiter') || ','; 904 if ( $format eq 'csv' ) { ... 914 while (my $row = $sth->fetchrow_arrayref()) { 915 if ($csv->combine(@$row)) { 916 $content .= $csv->string() . "\n"; 917 } else { 918 push @$q_errors, { combine => $csv->error_diag() } ; 919 } 920 } 921 } 922 elsif ( $format eq 'ods' ) { ... 932 # Other line in Unicode 933 my $sql_rows = $sth->fetchall_arrayref(); 934 foreach my $sql_row ( @$sql_rows ) { 935 my @content_row; 936 foreach my $sql_cell ( @$sql_row ) { 937 push @content_row, Encode::encode( 'UTF8', $sql_cell ); 938 } 939 push @$ods_content, \@content_row; 940 } 941 942 # Process 943 generate_ods($ods_filepath, $ods_content); 944 945 # Output 946 binmode(STDOUT); 947 open $ods_fh, '<', $ods_filepath; 948 $content .= $_ while <$ods_fh>; 949 unlink $ods_filepath; 950 } The *.ods case is particularly problematic, because before any data is sent back to the user's browser, *three* copies of the full results are sitting in memory simultaneously -- @$sql_row, @$ods_content, and $content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 78

[Bug 20472] New: Working title
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '25

21 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Bug ID: 20472 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 90

[Bug 23771] New: CAS/Shib Authentication can fail when multiple users with no userid/cardnumber defined and one of them is locked
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '25

21 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23771 Bug ID: 23771 Summary: CAS/Shib Authentication can fail when multiple users with no userid/cardnumber defined and one of them is locked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: nick(a)bywatersolutions.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org When logging in via cas no userid is passed to checkpw, however, we still seek out users with a null userid/cardnumber. If one of those users has a locked account and it happens to be the one chosen, we won't continue to CAS/Shib login (or LDAP, but LDAP shouldn't get a blank userid) -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 24976] New: Guided report - "Save" button on last step is misleading
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '25

17 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24976 Bug ID: 24976 Summary: Guided report - "Save" button on last step is misleading Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org "Save" button on last step does not save (!) It should be renamed "Next" instead https://snipboard.io/gXntf8.jpg Next step has a "Save report" button that actually saves. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 25127] New: Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '25

16 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Bug ID: 25127 Summary: Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1 - Set maxFine to 7.50 2 - Manually create some overdues for a patron in the amounts of: 6.99, .1, .1, .1, .1, .1, .01 (create a manual debits then 'UPDATE accountlines SET debit_type_code = "OVERDUE";' 3 - Set fines for an item type to .1 4 - Checkout an item of that type to patron and backdate so it is overdue 5 - Run fines.pl 6 - Check the DB, they have a new fine of "0" 7 - Checkin the item, checking 'forgive fines' option 8 - ISE "Debit amount passed is not positive" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 47

[Bug 25498] New: Cannot change owner of list
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '25

14 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Bug ID: 25498 Summary: Cannot change owner of list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Once someone owns a list, there is no way to change the owner. This problem often arises when a library staff member uses an individual account to create a public list, and then they leave their job. A superlibrarian (or otherwise privileged user) should be able to change the owner of a list on demand. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 89

[Bug 21469] New: Add useControlNumberIdentifier preference to allow (003)001 constructions in $w links.
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '25

12 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Bug ID: 21469 Summary: Add useControlNumberIdentifier preference to allow (003)001 constructions in $w links. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Whilst working through bug 11175 I was reminded of our inconsistent use of useControlNumber and it's lack of accounting for 003 fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41