October 2020 - Koha-bugs - lists.koha-community.org

[Bug 23981] New: Inconsistencies with the different prices
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 Bug ID: 23981 Summary: Inconsistencies with the different prices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org I was investigating bug 18639 and I came across some inconsistencies in the prices, where they are used, the calculations, etc. To reproduce : (Note: my vendor setting is "tax excluded" for both list and invoice price, I tried with different settings and as far as I can tell, the result is the same) 1- Create a new basket 2- Add an order 3- In the financial details, enter the following informations (I know it doesn't make sense IRL, but we are entering different prices just to see what goes where): - Vendor price: 10.99 - Tax rate: 0% - Discount: 0% - Retail price: 12.99 - Replacement cost: 15.99 - Actual cost: 18.99 4- Note that Budgeted cost and Total are based on *vendor* price (10.99) 5- Save your order 6- If you have access to your database, check the info that is entered (if you don't have access to your database, you can do an SQL report with the following query SELECT * from aqorders where basketno = X; Substitute de X for your basket number My db shows the following: listprice: 10.990000 unitprice: 18.990000 rrp: 12.99 replacementprice: 15.990000 rrp_tax_excluded: 12.990000 rrp_tax_included: 12.990000 ecost: 10.99 ecost_tax_excluded: 12.990000 ecost_tax_included: 12.990000 Note that the ecost_tax_excluded and ecost_tax_included are not based on ecost, but on rrp. 7- Go back to acquisitions home page and click on the amount ordered in your budget 8- Find your order and note that the estimated cost per unit is the retail price (12.99), not the vendor price (10.99) and not the budgeted cost as calculated during the order (10.99). 9- Close the basket 10- Receive the order 11- On the receipt summary page (which lists all the items yet to be received), the unit cost is the retail price (12.99) and the replacement cost is correct 12- On the item receiving page, the retail price is correct, the replacement price is correct, the budgeted cost is the retail price not the vendor price (listprice) nor the budgeted cost calculated during the order (ecost), the actual price is correct. 13- In the already received page, the prices are correct 14- In the "Spent column" of the budget, the price taken out of the fund is the actual price, which is correct. Summary: - The vendor price/listprice is not used anywhere else than during the first step of the order - The budgeted cost (ecost) is based on the retail price, the order form needs to reflect that Propositions: - Unless there is a good reason to keep it (like someone wanting to discriminate between how much the vendor sells it vs how much another vendor might sell it), I would remove the vendor price completely and replace it with the retail price - Correct the order form to show the real estimated price, based on the retail price - Correct the db calculations to make sure the ecost is based on the rrp and that the tax are calculated on the ecost I'm sorry if this is all over the place, hopefully by following the steps, you will see what I mean. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 24342] New: Self check needs on screen keyboard for login
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24342 Bug ID: 24342 Summary: Self check needs on screen keyboard for login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org For those of us using touch screens, the option to have an on screen keyboard (either numeric pad, full keyboard, or definable) would be a great asset. Not everyone carries their card. Some have the number written down or memorized. I've done a workaround with jquery and css using http://keith-wood.name/keypad.html, but it took a while to get just right. This would be a great permanent addition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 22632] New: Add logging of merged patrons
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Bug ID: 22632 Summary: Add logging of merged patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- When patrons are merged, we don't retain any record of that merging. One patron is retained and the other goes into deletedborrowers and that's it. It's be great to be able to somehow identify if a current patron was previously merged and which deleted patron they were merged with. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 123

[Bug 22639] New: Elasticsearc ability export/import mappings and facets settings
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Bug ID: 22639 Summary: Elasticsearc ability export/import mappings and facets settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: black23(a)gmail.com Target Milestone: --- For easier maintance export/import of settings will be great feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 85

[Bug 20324] New: Fund Warnings do not occur when importing records from a staged file
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Bug ID: 20324 Summary: Fund Warnings do not occur when importing records from a staged file Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When using the Warning feature on funds (whether that is a $ amount of percentage) in the Acquisition module - these warnings do not display a warning when importing records from a staged file. Koha does warn the user when using other avenues upon adding items to an order, just not with staged files. /addorderiso -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 17418] New: Move staff client home page JavaScript to the footer
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bug ID: 17418 Summary: Move staff client home page JavaScript to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org This patch will do two things: 1. Update the header and footer include files in order to be able to manage JavaScript either in the header or the footer. 2. Modify the staff client home page as a proof of concept, moving global and in-page JavaScript assets to the footer. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 17859] New: Move JavaScript to the footer on about and auth pages
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Bug ID: 17859 Summary: Move JavaScript to the footer on about and auth pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17418 Blocks: 17858 Two "standalone" templates which can have the JavaScript moved to the footer: The about page and the login page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 17893] New: Move JavaScript to the footer on staff client catalog pages
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Bug ID: 17893 Summary: Move JavaScript to the footer on staff client catalog pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: claire_gravely(a)hotmail.com, jonathan.druart(a)bugs.koha-community.org, testopia(a)bugs.koha-community.org Depends on: 17870, 17418 Blocks: 17858 This patch will move JavaScript to the footer on a number of pages in the catalog module of the staff client: basket/basket.tt catalogue/ISBDdetail.tt catalogue/MARCdetail.tt catalogue/advsearch.tt catalogue/detail.tt catalogue/imageviewer.tt catalogue/issuehistory.tt catalogue/itemsearch.tt catalogue/labeledMARCdetail.tt catalogue/moredetail.tt catalogue/results.tt catalogue/search-history.tt In the process I will be consolidating JS from several of those templates into one separate JavaScript file. Other modifications will be required in order for JavaScript to be able to be called from catalog-related include files. Since include files are parsed before jQuery is loaded in the footer, jQuery-specific code will have to be adapted or moved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 17416] New: Move javascript in doc-head-close.inc into a separate include
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Bug ID: 17416 Summary: Move javascript in doc-head-close.inc into a separate include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I would like to move the staff client JavaScript assets from the header to the footer. This is a best practice for speed because pages can begin rendering before all JavaScript is loaded. This bug is a first step which shouldn't affect any JS behavior. It will move the parts of doc-head-close.inc which relate to JavaScript into a separate file, js_includes.inc. A later patch will move the include into the footer. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 17870] New: Call to include file incorrectly moved into the footer
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Bug ID: 17870 Summary: Call to include file incorrectly moved into the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: bouzid.fergani(a)inlibro.com, jonathan.druart(a)bugs.koha-community.org, katrin.fischer(a)bsz-bw.de, kyle(a)bywatersolutions.com, philippe.blouin(a)inlibro.com, testopia(a)bugs.koha-community.org Depends on: 17416, 17418 Blocks: 17858, 17859 In Bug 17418 I moved a line from doc-head-close.inc to js_includes.inc which I shouldn't have: -[% PROCESS 'html_helpers.inc' %] That file isn't JS and many pages depend on it being defined at the top of the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 [Bug 17416] Move javascript in doc-head-close.inc into a separate include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 [Bug 17859] Move JavaScript to the footer on about and auth pages -- You are receiving this mail because: You are watching all bug changes.

1 11