November 2020 - Koha-bugs - lists.koha-community.org

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112131|0 |1 is obsolete| | --- Comment #180 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 113563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113563&action=e… Bug 11299: (QA follow-up) Fix tests, spaces, and CSS update Removed my from variables in test Undid stray line deletions Undid adding 1; to test file Fix CSS replace command Update license Fix spelling Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112130|0 |1 is obsolete| | --- Comment #179 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 113562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113562&action=e… Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : 1 - In your system preferences set: AutoCreateAuthorities: Don't generate BiblioAddsAuthorities: Allow 2 - Go to the Cataloging -> New record (koha/cataloguing/addbiblio.pl) Ensure you are using the basic editor 3 - Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." 4 - Add random informations in field 600$a of the biblio record. 5 - Click the "Link authorities automatically" button. the message box should now show "600 - No matching authority found.". the 9 subfield is red Above the 9 subfield is a red X with a blue plus next to it Hover on the plus, see it is titled 'Create authority' 6 - Click the 'Create authority' link 7 - A new authroity form pops up, the info from the cataloging editor is prefilled Click the 100 field heading to expand and confirm info is transferred 8 - Fill in necessary fields and save the new authority 9 - The cataloging screen now has the 9 subfield populated and is green 10 - Click "Link authorities automatically" again Dialog says "No authority link was changed" 11 - In another tab go to System preferences and set AutoCreateAuthorities to 'Generate' 12 - Add random information to the 650 field 13 - Click 'Link authorities' button 14 - Dialog says:650 - No matching authority found. A new authority was created automatically. 15 - The subfield 9 is green and has the id of the new authority record 16 - In another tab search authorities and find an existing subject heading 17 - Add a new 650 with the info from the existing record 18 - Click 'Link authorities' 19 - The new field is correctly linked to existing authority Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22509] New: Add a script to generate MARC fields containing date formatted strings
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Bug ID: 22509 Summary: Add a script to generate MARC fields containing date formatted strings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Target Milestone: --- This will add a simple script to add MARC fields to bibliographic records with date information. -- You are receiving this mail because: You are watching all bug changes.

1 39

[Bug 21582] New: Use CodeMirror for *UserJS & *UserCSS
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Bug ID: 21582 Summary: Use CodeMirror for *UserJS & *UserCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com CodeMirror is already in use, most recently for the SQL reports editor (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260) It would be a substantial UX improvement to add it to the editors for the *UserJS & *UserCSS sysprefs, in additional to providing syntax highlighting, features such as smart indenting and bracket matching would be welcome additions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 40

[Bug 19474] New: Convert staff client CSS to SCSS
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Bug ID: 19474 Summary: Convert staff client CSS to SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I propose a new workflow for handling CSS in the staff client based on the work in Bug 15522 which adds a client-side asset processing workflow. My patch will be designed to work independently from that bug but use the same framework so that the two can be merged easily. - Uses yarn (https://yarnpkg.com) to manage installation of npm dependencies - Uses gulp (https://gulpjs.com) to process client-side assets. In this case, conversion of SCSS to CSS, auto-prefixing of CSS, minification of CSS. This patch will add a configuration file for sass-lint (https://github.com/sasstools/sass-lint) to help standardize how we write SCSS. The version I'm working with is pretty much the default, and I hope it won't be controversial. I'm using this configuration file in conjunction with my editor's linting plugin. We might later plug sass-lint into the gulp build process. The patch will include a conversion of staff-global.css to SCSS and remove staff-global.css from git. -- You are receiving this mail because: You are watching all bug changes.

1 101

[Bug 17140] New: Incorrect rounding in total fines calculations, part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Bug ID: 17140 Summary: Incorrect rounding in total fines calculations, part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: larit(a)student.uef.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 15741 fixes some rounding issues but not all, for example trying to paying a fine of 1.14 still does not work (also 1.39). To replicate bug: 1. Go to patron's fines tab, make sure there are no outstanding payments. 2. Via "Create manual invoice" tab, create one fine of 1.14 3. Go to Pay fines tab 4. Click "Pay amount" and confirm. 5. Observe error message "You must pay a value less than or equal to 1.14." 6. Go to Pay fines tab 7. Click "Pay selected" and confirm 8. Observe error message "You must pay a value less than or equal to 1.14." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 77

[Bug 25855] New: Add post_renewal_hook in circulation
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Bug ID: 25855 Summary: Add post_renewal_hook in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We need a hook to trigger plugin actions after renweals take place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 50

[Bug 23893] New: Add ->new_from_api and ->set_from_api methods to Koha::Object
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Bug ID: 23893 Summary: Add ->new_from_api and ->set_from_api methods to Koha::Object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Now we have ->to_api, we need to add the opposite operation, so: POST -> my $object = Koha::Class->new_from_api( $c->validation->param('body') )->store; PUT/PATCH -> my $object = Koha::Class->find( $c->validation->param('object_id') ); $object->set_from_api( $c->validation->param('body') )->store; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 77

[Bug 23517] New: Incorrect permission requirements for holds operations via the API
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Bug ID: 23517 Summary: Incorrect permission requirements for holds operations via the API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org CC: tomascohen(a)gmail.com When using the staff client, the holds modification page requires "reserveforothers => 'place_holds'" permission. This is the minimum required permission to modify a hold's pickup location, suspended status, or to delete it. The API requires "reserveforothers" permission (both "place_holds" AND "modify_holds_priority") to delete a hold. This means that operations which a user could perform in the staff client are forbidden by the API. Add and update operations are also problematic because of the granularity of the sub-permissions: - Someone with only "place_holds" permission should be able to add holds and modify every aspect of the hold EXCEPT priority. - Someone with only "modify_holds_priority" permission should be able to modify only the priority of a hold (I guess??). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 42