December 2020 - Koha-bugs - lists.koha-community.org

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '20

28 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '20

28 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25189 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '20

28 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #31 from Magnus Enger <magnus(a)libriotech.no> --- Relevat code: C4/SIP/ILS/Patron.pm: 476 =head2 update_lastseen 477 478 $patron->update_lastseen(); 479 480 Patron method to update lastseen field in borrower 481 to record that patron has been seen via sip connection 482 483 =cut 484 485 sub update_lastseen { 486 my $self = shift; 487 my $kohaobj = Koha::Patrons->find( $self->{borrowernumber} ); 488 $kohaobj->track_login if $kohaobj; # track_login checks the pref 489 } Koha/Patron.pm: 910 =head3 track_login 911 912 $patron->track_login; 913 $patron->track_login({ force => 1 }); 914 915 Tracks a (successful) login attempt. 916 The preference TrackLastPatronActivity must be enabled. Or you 917 should pass the force parameter. 918 919 =cut 920 921 sub track_login { 922 my ( $self, $params ) = @_; 923 return if 924 !$params->{force} && 925 !C4::Context->preference('TrackLastPatronActivity'); 926 $self->lastseen( dt_from_string() )->store; 927 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 20885] New: Transferring an item on hold results in bypassing restrictions, actually doing the transfer and can be piled up if repeated
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '20

26 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20885 Bug ID: 20885 Summary: Transferring an item on hold results in bypassing restrictions, actually doing the transfer and can be piled up if repeated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The first name was «Transferring an item on hold results in chaos» Disclaimer: I'm not sure if what I did makes sense from a functional point of view. == Test plan == 1. Add transfer restrictions staff:/cgi-bin/koha/admin/branch_transfer_limits.pl For all item types => clear all 2. Place a hold on a record 3. go to the transfer page staff:/cgi-bin/koha/circ/branchtransfers.pl 4. Try to transfer the item 5. You should see the message «Transfer is not allowed for [...]» OR retry with another site to fall into your restrictions 6. But you also see the "Transferred items" table showing the transfer This is a bug. The transfer shouldn't have been scheduled. 7. On the same page: redo a transfer 8. You should see "Item is already at destination library." This is a bug. This is even worst. The transfer shouldn't have been actually done! 9. But wait there is more, the transfer has been add to the table. This is a bug. It's still scheduled anyway. A transfer to the same branch! 10. Redo it again and it will pile up! 11. Raise your hands and ask loudly: Why! Tried on master the 24 of April and on version 16.11.15 To ensure that bug 19530 hadn't an influence on this. Might be related to bug 20344 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 24 Dec '20

24 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #275 from David Cook <dcook(a)prosentient.com.au> --- Ugh, "holds group" is already being used by Bug 22284. That's already confusing me when I read Bugzilla reports... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27304] New: Show subtitle in Claims tab of patron record
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '20

23 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27304 Bug ID: 27304 Summary: Show subtitle in Claims tab of patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We should show the subtitle in the Claims tab on circulation.pl and moremember.pl. Title alone is often insufficient to identify a specific work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '20

23 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #36 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 114691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114691&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '20

23 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #35 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 114690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114690&action=e… Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '20

23 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #34 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 114689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114689&action=e… Bug 8179: Add syspref to database This patch adds the AcqReceiveMultipleOrderLines syspref by atomicupdate and in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '20

23 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112744|0 |1 is obsolete| | Attachment #112745|0 |1 is obsolete| | Attachment #112746|0 |1 is obsolete| | Attachment #112747|0 |1 is obsolete| | --- Comment #33 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 114688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114688&action=e… Bug 8179: Add tests This patch adds tests in: * t/db_dependent/Koha/Acquisition/Fund.t * t/db_dependent/Koha/Acquisitoin/Order.t * t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.

1 0