January 2021 - Koha-bugs - lists.koha-community.org

[Bug 27154] New: Koha/Util/SystemPreferences.pm must be removed
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 Bug ID: 27154 Summary: Koha/Util/SystemPreferences.pm must be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nick(a)bywatersolutions.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm? Koha/Config/SysPref.pm:sub get_yaml_pref_hash { Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { We should remove the whole Koha/Util/SystemPreferences.pm package. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 18146] New: C4:: Circulation CanBookBeRenewed lacks full test coverage.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146 Bug ID: 18146 Summary: C4::Circulation CanBookBeRenewed lacks full test coverage. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com While testing bug 17941, I discovered two cases where test coverage was lacking from t/db_dependent/Circulation.t Around line 2725: if ( $restricted and $restrictionblockrenewing ) { return ( 0, 'restriction'); } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($itemissue->{overdue} and $overduesblockrenewing eq 'blockitem') ) { return ( 0, 'overdue'); } The elseif is never triggered. Around line 2759: if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) ) { return ( 0, "auto_too_soon" ) if $itemissue->{auto_renew}; return ( 0, "too_soon" ); } elsif ( $itemissue->{auto_renew} ) { return ( 0, "auto_renew" ); } There is no else, but the code never attempts something that would trigger one. To reproduce add: print STDERR "CHECK!\n"; just before the return ( 0, 'overdue') in the first case, and after the elsif's curly brace in the second case. running t/db_dependent/Circulation should not generate the CHECK points. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 27440] New: Improve structure and style of result toolbars in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Bug ID: 27440 Summary: Improve structure and style of result toolbars in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Several pages in the OPAC follow a similar pattern: Above the table of records (search results, lists, suggestions, etc) is a toolbar with various controls: Highlight, select all, place hold, etc. I think some improvements can be made to the markup and style of these areas of the template to make them work better and look more consistent. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 27289] New: Template tweaks for point of sale page
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '21

18 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Bug ID: 27289 Summary: Template tweaks for point of sale page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23354 I have a couple of minor updates for the point of sale page: - buttons inside tables should use "btn-xs" to be a consistent size - required fields in the "Collect payment" form should be styled as required Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 27466] New: Error "Configuration not defined at /usr/share/perl5/Log/Log4perl/Config.pm line 579" while upgrading to koha 20.11.00-1
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27466 Bug ID: 27466 Summary: Error "Configuration not defined at /usr/share/perl5/Log/Log4perl/Config.pm line 579" while upgrading to koha 20.11.00-1 Change sponsored?: --- Product: Koha Version: 20.11 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: egpetridis(a)yahoo.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 115295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115295&action=e… A partial log of commands and errors encountered On Debian GNU/Linux 9.13 (stretch) with Linux 4.9.0-14-amd64 kernel. Tried to upgrade koha to the latest release, using "apt-get upgrade". As koha was held back, I tried "apt-get --with-new-pkgs upgrade". System then proceeded to the upgrade, installing any packages that were not originally required. However upgrade stops producing message "Configuration not defined at /usr/share/perl5/Log/Log4perl/Config.pm line 579." ... Upgrade to 20.06.00.022 done [20:11:08]: Bug 21946 - Add parent type to itemtypes Configuration not defined at /usr/share/perl5/Log/Log4perl/Config.pm line 579. dpkg: error processing package koha-common (--configure): subprocess installed post-installation script returned error exit status 11 Processing triggers for systemd (232-25+deb9u12) ... Errors were encountered while processing: koha-common E: Sub-process /usr/bin/dpkg returned an error code (1) Fuller details attached, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 22713] New: Replacement price removed when receiving if using MarcItemFieldstoOrder
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '21

17 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Bug ID: 22713 Summary: Replacement price removed when receiving if using MarcItemFieldstoOrder Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: nick(a)bywatersolutions.com Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88048&action=ed… replacement price in item record acq process In 18.11 the wording and functionality changed in Acquisitions with the field Replacement price. This allowed libraries to have their replacement price set in the Acquisitions order and also in the item record. However, if a library is using MarcItemFieldstoOrder system preference and setting their replacement price in the marc record upon Importing. The replacement price only stays on the Item Record and will not be included into the Acquisitions order and it won't populate into the receiving process- and therefore making it $0. It would be nice if the item record had the replacement price from the MarcItemFieldstoOrder, and this would follow it through the process and since it is there in the item, it be used in the Order. Process currently: 1. Set marcitemfieldstorder to have a $v replacement price (975$v) 2. Create a basket 3. Upload a marc file that has a replacement price in the record 4. Add this file to your basket. 5. The item record will display the replacement price. 6. The basket.pl will not display the replacement price of this item 7. CLose the basket 8. When receiving the item in Acquisitions, the replacement price is zeroed out 9. The item will not have a replacement price once it is received. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 25954] New: Header search forms should be labeled
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '21

16 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Bug ID: 25954 Summary: Header search forms should be labeled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The markup for the header search forms in the staff interface use a <p> tag to show descriptive text about the form. For instance: <p class="tip">Enter patron card number or partial name:</p> In most cases this can be replaced with a label: <label class="tip" for="findborrower">Enter patron card number or partial name:</label> This will improve accessibility and eliminate errors raised by WCAG checks. -- You are receiving this mail because: You are watching all bug changes.

1 45

[Bug 22838] New: Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous'
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '21

16 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 Bug ID: 22838 Summary: Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Target Milestone: --- Explicitly setting a MIME header field (content-type) is dangerous: use the attr() method instead. at misc/cronjobs/runreport.pl line 312. It seems the error comes from Koha/Email.pm: 72 $mail{'Content-Type'} = $params->{contenttype} if $params->{contenttype}; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 24692] New: OpacBrowseSearch: enable navigating result list with arrow keys
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '21

16 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 Bug ID: 24692 Summary: OpacBrowseSearch: enable navigating result list with arrow keys Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org With the new OpacBrowseSearch feature from bug 14567 a list of authors, titles or subjects will show. When clicking on an entry, the records linked to it will show on the right of the list. It would be nice if jumping between entries was possible using the arrow keys (up and down). -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 24691] New: OpacBrowseSearch: Show number of results behind each list entry
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '21

16 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24691 Bug ID: 24691 Summary: OpacBrowseSearch: Show number of results behind each list entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de Depends on: 14567 When using the new OpacBrowseSearch feature from bug 14567 it would be great if the number of results showed behind each list entry when browsing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 [Bug 14567] Browse interface for OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2