January 2021 - Koha-bugs - lists.koha-community.org

[Bug 27508] New: Can't duplicate the MARC field tag with JavaScript if option "advancedMARCeditor" is set to "Don't display"
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27508 Bug ID: 27508 Summary: Can't duplicate the MARC field tag with JavaScript if option "advancedMARCeditor" is set to "Don't display" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Cataloging Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, nugged(a)gmail.com, slavashishkin(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 27446] New: Markup errors in suggestion/suggestion.tt
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Bug ID: 27446 Summary: Markup errors in suggestion/suggestion.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org While working on a separate issue I notices there are several markup errors in suggestion/suggestion.tt. 1. <h2> tag closes with an </h3> 2. Some button elements are using the self-closing syntax when they should not 3. <div id="limits> does not close 4. There are some stray </div>'s 5. Indentation/white could be better -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 27034] New: $c->objects->search shouldn't use path parameters
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 Bug ID: 27034 Summary: $c->objects->search shouldn't use path parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com The objects.search Mojolicious helper incorrectly adds path parameters to the query for filtering. This works, trivially for plat routes like: GET /patrons/:patron_id or for routes that really have links like (fictional example): GET /patrons/:patron_id/holds In the latter, we already know there's a link borrowers<->reserves so searching holds and filtering by the borrowernumber will work. About this there are two things to consider: - That's not how we are coding, we are actually picking the patron_id manually and using object methods to access the resultset: my $patron = Koha::Patrons->find( $c->validation->param('patron_id') ); ... my $holds_rs = $patron->holds; my $holds = $c->objects->search({ resultset => $holds_rs }); - If we have more tricky examples like: GET /holds/:hold_id/pickup_locations it is obvious that hold_id doesn't make any sense for Koha::Libraries, so filtering on it actually causes an exception. One option is to manually remove the problematic path parameters in the controller: my $hold_id = $c->validation->param('hold_id'); my $hold = Koha::Holds->find( $hold_id ); delete $c->validation->output->{'hold_id'}; my $pickup_locations_rs = $hold->pickup_locations; my $pickup_locations = $c->objects->search( $pickup_locations_rs ); My feeling is that we should be following the current pattern, and not really use the path parameters in objects.search. If we later need some handling in the generic objects->search helper, we can reintroduce it, but we need a real use case, which cannot be found in the codebase yet. It all points towards not needing them there, and just getting in the middle with no gain (just the opposite). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 27352] New: Add GET /biblios/:biblio_id/items
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Bug ID: 27352 Summary: Add GET /biblios/:biblio_id/items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com It would be helpful to have that route. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 24810] New: French SQL files for "news" contain "Welcome into Koha 3!"
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24810 Bug ID: 24810 Summary: French SQL files for "news" contain "Welcome into Koha 3!" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com installer/data/mysql/fr-CA/facultatif/sample_news.sql installer/data/mysql/fr-FR/2-Optionel/sample_news.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 24811] New: French SQL files for "news" contain broken link to the wiki
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24811 Bug ID: 24811 Summary: French SQL files for "news" contain broken link to the wiki Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com installer/data/mysql/fr-CA/facultatif/sample_news.sql installer/data/mysql/fr-FR/2-Optionel/sample_news.sql http://wiki.koha-community.org/doku.php?id=en:development:git_usage returns 404 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 27179] New: Misspelling of Method in REST API files
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27179 Bug ID: 27179 Summary: Misspelling of Method in REST API files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org git grep -i mehtod -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 27327] New: Indirect object notation in Koha::Club::Hold
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Bug ID: 27327 Summary: Indirect object notation in Koha::Club::Hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 27333] New: Wrong exception thrown in Koha::Club::Hold::add
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27333 Bug ID: 27333 Summary: Wrong exception thrown in Koha::Club::Hold::add Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It should be returning Koha::Exceptions::MissingParameter. And is returning a generic Koha::Exceptions::ClubHold exception. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 26578] New: OverDrive results can return false positives when searches contain CCL syntax
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578 Bug ID: 26578 Summary: OverDrive results can return false positives when searches contain CCL syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This problem is from the ':' and '=' signs, along with field codes, that can be passed to overdrive when forming queries or clicking links. Depending on the overdrive catalog, these can match records causing inaccurate results To recreate: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' -- You are receiving this mail because: You are watching all bug changes.

1 15