February 2021 - Koha-bugs - lists.koha-community.org

[Bug 27799] New: Add ability to override system preferences in the koha-conf
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27799 Bug ID: 27799 Summary: Add ability to override system preferences in the koha-conf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com While we can override preferences for individual hosts in the apache config it would be nice to have a system wide swtich in the koha-conf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #22) > Thanks for QAing this Marcel, your right, I should have detailed my testing > :(.. I basically looked at where the code changed and tried to trigger those > actions via the UI to check things weren't broken. Great. This will build up more confidence for pushing it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Can't call method "subtract" on an undefined value at /usr/share/koha/Koha/Patron.pm line 770 When dateexpiry == 0000-00-00 But I did put it in explicitly ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27804 [Bug 27804] Convert register transactions table to a single ajax driven datatable -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- 142 when I reduce the query to only those fields that are nullable: SELECT Concat(col.table_name, '.', col.column_name), col.data_type FROM information_schema.columns col JOIN information_schema.tables tab ON tab.table_schema = col.table_schema AND tab.table_name = col.table_name AND tab.table_type = 'BASE TABLE' WHERE col.data_type IN ( 'date', 'time', 'datetime', 'year', 'timestamp' ) AND col.is_nullable = 'YES' AND col.table_schema NOT IN ( 'information_schema', 'sys', 'performance_schema', 'mysql' ) AND col.table_schema = 'koha_demo1' ORDER BY col.table_schema, col.table_name, col.ordinal_position; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #22 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #19) > Although this looks quite good to me, it is really hard to be convinced that > all appearances of 0000-00-00 in the data now are caught correctly by the > codebase. > > I found at least one issue (no blocker): > select count(*) from items where dateaccessioned= '0000-00-00'; > +----------+ > | count(*) | > +----------+ > | 335 | > +----------+ > 1 row in set (0.12 sec) > This comes from a production database. > So I tested with an item. Set dateaccessioned to 0*. Open item editor. You > see the 0* on the form. Tab thru the field so that the date gets FOCUS. This > will update the 0* in the old situation, but not in the new one (obviously). > Note that the CLICK event uses the force parameter and will set the date. > > Could you add this one to the atomicupdate too? > And please provide me some evidence that we found the last case ;) For > instance by checking date columns in a larger production database being used > for a longer time.. > > PQA for now. Thanks for QAing this Marcel, your right, I should have detailed my testing :(.. I basically looked at where the code changed and tried to trigger those actions via the UI to check things weren't broken. As for this comment, I'm pretty sure we'll have left behind some bad data, but it should get picked up by upgrades now that we throw errors in the updatedatabase script. We could I suppose write a one off atomicupdate to check and fix all possible datefields at this point in time.. I used the following to get a list of such fields.... we have 210! ''' SELECT col.table_schema AS database_name, col.table_name, col.ordinal_position AS column_id, col.column_name, col.data_type, col.datetime_precision FROM information_schema.columns col JOIN information_schema.tables tab ON tab.table_schema = col.table_schema AND tab.table_name = col.table_name AND tab.table_type = 'BASE TABLE' WHERE col.data_type IN ( 'date', 'time', 'datetime', 'year', 'timestamp' ) AND col.table_schema NOT IN ( 'information_schema', 'sys', 'performance_schema', 'mysql' ) AND col.table_schema = 'database_name' ORDER BY col.table_schema, col.table_name, col.ordinal_position; ''' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0