February 2021 - Koha-bugs - lists.koha-community.org

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117267|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 117362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117362&action=e… Bug 7806: (follow-up) Update to use sanitize_zero_date Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117266|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 117361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117361&action=e… Bug 7806: Fix remaining occurrences of 0000-00-00 We should remove all SQL queries that contain 0000-00-00 and finally assume we do not longer have such value in our DB (for date type) We already dealt with such values in previous update DB entries. The 2 added by this one haven't been replaced already. The code will now assume that either a valid date exist, or NULL/undef. Test plan: QA review is needed and test of the different places where code is modified. Not sure about the change from reports/issues_avg_stats.pl Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Although this looks quite good to me, it is really hard to be convinced that all appearances of 0000-00-00 in the data now are caught correctly by the codebase. I found at least one issue (no blocker): select count(*) from items where dateaccessioned= '0000-00-00'; +----------+ | count(*) | +----------+ | 335 | +----------+ 1 row in set (0.12 sec) This comes from a production database. So I tested with an item. Set dateaccessioned to 0*. Open item editor. You see the 0* on the form. Tab thru the field so that the date gets FOCUS. This will update the 0* in the old situation, but not in the new one (obviously). Note that the CLICK event uses the force parameter and will set the date. Could you add this one to the atomicupdate too? And please provide me some evidence that we found the last case ;) For instance by checking date columns in a larger production database being used for a longer time.. PQA for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9) > Not sure about the change from reports/issues_avg_stats.pl Since returndate comes from oldissues and you sanitize the field in the atomic update, we should be fine imo. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #13) > These patches appear to work as expected for me so signing off. Since there is no test plan, it would be beneficial for us to know what you exactly tested and why you conclude that they appear to work? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9) > Test plan: > QA review is needed and test of the different places where code is > modified. Hahaha, good plan ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27118] New: Typo in manual: If allowed, the patron chan choose the specific item to request.
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27118 Bug ID: 27118 Summary: Typo in manual: If allowed, the patron chan choose the specific item to request. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org See bug title: If allowed, the patron chan choose the specific item to request. chan > can -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 27506] New: Manual typo: accessed both by your organisations Koha instance
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27506 Bug ID: 27506 Summary: Manual typo: accessed both by your organisations Koha instance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: chris(a)bigballofwax.co.nz, ellawipatene(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 27401 This is in the chapter about setting up LDAP. I think we are missing a ' here? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27401 [Bug 27401] Manual typo: OCLC Connextion Gateway -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 27563] New: Remove check-url.pl in favor of check-url-quick.pl
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '21

26 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27563 Bug ID: 27563 Summary: Remove check-url.pl in favor of check-url-quick.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz In bug 7693 we added a new 'check-url-quick.pl' script and added a deprecation note to check-url.pl, that was pushed to Koha 3.8 I believe maybe we have waited long enough to remove the deprecated script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14