February 2021 - Koha-bugs - lists.koha-community.org

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #60 from David Nind <david(a)davidnind.com> --- Thanks Martin for all the follow ups and the responses to questions! I've retested (and Kelly has just signed off!), there is one more thing I noticed: - I added a notice, made some changes, then deleted. - These all show up in the log. - After deleting a notice, the Object column 'name' is changed to the ID (which makes sense, as it is deleted and doesn't know the name). - If I click on compare for a deleted item it doesn't filter down to all the items with the same ID. The 'Message Log' in the browser shows 'Showing results for' and after that it is blank, with a non-deleted item it shows as 'Showing results for <object name>' with the name of the object showing up in the search box. - I can still compare by put the ID in the data table search box, then the compare works as expected. David -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117304|0 |1 is obsolete| | --- Comment #59 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117321&action=e… Bug 14233: [DO NOT PUSH] DBIC Schema File Update Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117303|0 |1 is obsolete| | --- Comment #58 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117320&action=e… Bug 14233: (follow-up) Add NoticesLog preference This patch adds a preference to enable/disable the notice template logging. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117302|0 |1 is obsolete| | --- Comment #57 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117319&action=e… Bug 14233: (follow-up) Clarify 'LetterLog' The LetterLog logging wasn't clear as to what it was logging, it actually logs aquisitions related notices being sent.. mostly 'Claims'. This patch updates LetterLog to ClaimsLog to more clearly reflect what it means. (I also discovered that there was a bug in the MODULE these were being logged as.. they were in fact being logged as 'ACQUISITION' and not 'LETTER' in the first place.. and as such not filtering correctly on the viewlog page). Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117301|0 |1 is obsolete| | --- Comment #56 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117318&action=e… Bug 14233: (follow-up) Add notice code to log viewer Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117300|0 |1 is obsolete| | --- Comment #55 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117317&action=e… Bug 14233: (QA follow-up) Record updated content We should record the updated template, not the content prior to the update.. That way we can properly compare between versions to see the changes made. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117299|0 |1 is obsolete| | --- Comment #54 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117316&action=e… Bug 14233: (QA follow-up) Fix typo in viewlog.tt We had a double ?? in the object link.. Thanks for spotting that David :) Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117298|0 |1 is obsolete| | --- Comment #53 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117315&action=e… Bug 14233: (follow-up) Fix for delete entire notice This fixes the overall notice delete option. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117297|0 |1 is obsolete| | --- Comment #52 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117314&action=e… Bug 14233: Allow comparing notice changes This patch adds the 'compare' option to the Notices logs. Test plan 1/ Make some changes to at least two different notices to trigger logs 2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices' 3/ Note, you can now see the 'Compare' checkbox option for these logs 4/ Select the checkbox on one of the notices and note that the results are now filtered by that specific notice. 5/ Select a second checkbox to expose the option to 'View comparison' 6/ Click 'View comparison' to see the 'Diff view' of the two notices. 7/ Signoff Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117296|0 |1 is obsolete| | --- Comment #51 from Kelly McElligott <kelly(a)bywatersolutions.com> --- Created attachment 117313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117313&action=e… Bug 14233: Add filtering of NOTICES type action logs to the logviewer This patch adds handling for the new 'NOTICES' type action_logs to the logviewer page. Test plan 1/ Add some 'Notice' action logs by adding a new notice or updateing an existing notice 2/ Go to the 'Log viewer' under 'Tools' 3/ Note you can filter by 'Notices' 4/ Confirm the changes you made appear in the logs and that the 'Object' field links back to the updated notice ready for editing. 5/ Signoff Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0