February 2021 - Koha-bugs - lists.koha-community.org

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117258|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117301&action=e… Bug 14233: (follow-up) Add notice code to log viewer -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117257|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117300&action=e… Bug 14233: (QA follow-up) Record updated content We should record the updated template, not the content prior to the update.. That way we can properly compare between versions to see the changes made. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117256|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117299&action=e… Bug 14233: (QA follow-up) Fix typo in viewlog.tt We had a double ?? in the object link.. Thanks for spotting that David :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117255|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117298&action=e… Bug 14233: (follow-up) Fix for delete entire notice This fixes the overall notice delete option. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117254|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117297&action=e… Bug 14233: Allow comparing notice changes This patch adds the 'compare' option to the Notices logs. Test plan 1/ Make some changes to at least two different notices to trigger logs 2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices' 3/ Note, you can now see the 'Compare' checkbox option for these logs 4/ Select the checkbox on one of the notices and note that the results are now filtered by that specific notice. 5/ Select a second checkbox to expose the option to 'View comparison' 6/ Click 'View comparison' to see the 'Diff view' of the two notices. 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117253|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117296&action=e… Bug 14233: Add filtering of NOTICES type action logs to the logviewer This patch adds handling for the new 'NOTICES' type action_logs to the logviewer page. Test plan 1/ Add some 'Notice' action logs by adding a new notice or updateing an existing notice 2/ Go to the 'Log viewer' under 'Tools' 3/ Note you can filter by 'Notices' 4/ Confirm the changes you made appear in the logs and that the 'Object' field links back to the updated notice ready for editing. 5/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117252|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117295&action=e… Bug 14233: Add logging to notice create/update/delete This patch adds the call to logaction to record when a notice is added or changed. Test plan 1/ Add a new notice and check a corresponding line appears in the action_logs table. 2/ Update a notice and check that a corresponding line appears in the action_logs table. 3/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117251|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117294&action=e… Bug 14233: Add 'id' field to `letter` table to allow linking To allow for 'object' linking from the action_logs table we need an int(11) identifier. This patch updates the letter table to add such a field as a replacement for the multi-field primary key and moves that key to a unique constraint. Test plan 1/ Run the database update 2/ Check that the 'letter' table now includes an 'id' primary key and 'letter_uniq_1' multi-field unique key 3/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27733] New: Sort pickup locations by library name instead of branchcode
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Bug ID: 27733 Summary: Sort pickup locations by library name instead of branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 27732 When you start the process of placing a hold in the staff interface for a title which already has holds, the table showing information about those holds has controls for changing the existing holds' pickup location. That dropdown queries the API to get available pickup locations, but the list of libraries is returned in order by branchcode. It should be ordered by library name instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27732 [Bug 27732] JavaScript error on place hold page in the staff interface -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 27732] New: JavaScript error on place hold page in the staff interface
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '21

25 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27732 Bug ID: 27732 Summary: JavaScript error on place hold page in the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 27016 If you begin the process of placing a hold on a title which has existing holds, there is an error in the console: Uncaught ReferenceError: $ is not defined The "select2.defaults" script block comes before jQuery is loaded. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 [Bug 27016] Make the pickup locations dropdowns use Select2 -- You are receiving this mail because: You are watching all bug changes.

1 12