April 2021 - Koha-bugs - lists.koha-community.org

[Bug 25189] New: Make AutoCreateAuthorities less of a footgun with LinkerModule: Default
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '21

07 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Bug ID: 25189 Summary: Make AutoCreateAuthorities less of a footgun with LinkerModule: Default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If you read every word of the description of AutoCreateAuthorities in the system prefs page, and then read every word about it in the manual, even if you also read every word in the description and in the manual about LinkerModule, you'll have no idea that by turning on AutoCreateAuthorities without changing LinkerModule from its default value of Default, you've just given yourself infinite authority duplicates. The behavior of LinkerModule: Default is to link a field in a bib to an authority when there is one and only one matching authority record. Without AutoCreateAuthorities, that means if you have zero matches or two or more matches, the field is unlinked. Fine, no problem. With AutoCreateAuthorities on, the behavior is that if there are zero matches, an authority record is created, if there is one match, the field is linked to that existing authority record, if there are two matches a third duplicate authority is created, and if there are three matches, a fourth duplicate match is created, and if there are 2661 matches, a 2662nd duplicate match is created (that being how many authority records my system had for the genre Thrillers (Fiction) when I noticed this behavior). Two ways to not create infinite duplicates occur to me: Change what a LinkerModule returns, so it returns the match, whether it was a fuzzy match, and also whether more than one match was found, so that in the AutoCreateAuthorities case when more than one was found it can be left unlinked rather than creating another duplicate, or, Have C4/Linker/Default.pm check whether AutoCreateAuthorities is on, and if it is and $behavior isn't either first or last, just force it to first rather than creating infinite duplicates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 22880] New: Convert opacheader system preference to news block
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '21

06 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Bug ID: 22880 Summary: Convert opacheader system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 22318 Target Milestone: --- Building on 22318, the opacheader system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes.

1 99

[Bug 21325] New: Should we still allow user and password via GET parameters?
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '21

06 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 Bug ID: 21325 Summary: Should we still allow user and password via GET parameters? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org In testing bug 13779, I just noticed that an URL like this works: https://[your_domain]/cgi-bin/koha/opac-reserve.pl?biblionumber=[some_bibli… Obviously, we should not expose credentials like that. But it raises the question: should we allow it then? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 32

[Bug 24813] New: api/v1/holds.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '21

06 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Bug ID: 24813 Summary: api/v1/holds.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org t/db_dependent/api/v1/holds.t .. 3/8 # Failed test 'Hold suspension created' # at t/db_dependent/api/v1/holds.t line 400. # got: '400' # expected: '201' # Failed test 'Hold is suspended' # at t/db_dependent/api/v1/holds.t line 405. # Failed test 'Hold is suspended' # at t/db_dependent/api/v1/holds.t line 418. # Failed test 'Hold suspension has correct end date' # at t/db_dependent/api/v1/holds.t line 419. # got: undef # expected: '2020-03-05' # Failed test 'Hold suspension created' # at t/db_dependent/api/v1/holds.t line 435. # got: '400' # expected: '201' # Failed test 'exact match for JSON Pointer "/end_date"' # at t/db_dependent/api/v1/holds.t line 435. # got: undef # expected: '2020-03-10' # Failed test 'The Location header is set' # at t/db_dependent/api/v1/holds.t line 435. # got: undef # expected: '/api/v1/holds/287/suspension' # Looks like you failed 7 tests of 24. t/db_dependent/api/v1/holds.t .. 7/8 # Failed test 'suspend and resume tests' # at t/db_dependent/api/v1/holds.t line 464. t/db_dependent/api/v1/holds.t .. 8/8 # Looks like you failed 1 test of 8. t/db_dependent/api/v1/holds.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 21877] New: Show authorized value description for withdrawn in checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '21

06 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Bug ID: 21877 Summary: Show authorized value description for withdrawn in checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com During checkout the withdrawn information is displayed in a message : "Item has been withdrawn". Like in other pages and like notforloan, we should display the withdrawn authorized value description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 35

[Bug 15788] New: Split borrowers permission into create/edit
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Bug ID: 15788 Summary: Split borrowers permission into create/edit Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/patron-edit- permission/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Goal : Add ability to control if a staff user can create new patrons vs editing existing patrons Work to be done: 1) Add new borrowers sub-permission ‘modify’ 2) Add new borrowers sub-permission ‘create’ 3) Implement new permissions for patron editor/creator Looking for sponsors here: http://devs.bywatersolutions.com/projects/patron-edit-permission/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 40

[Bug 22286] New: ILL, OpacHiddenItems and 404
by bugzilla-daemon＠bugs.koha-community.org 29 Jun '21

29 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22286 Bug ID: 22286 Summary: ILL, OpacHiddenItems and 404 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no Target Milestone: --- For some kinds of ILL you need to create records and items for materials the library receives through ILL, so they ca be lent to patrons in the regular way. Normally, you do not want these records to display or be searchable in the OPAC, because they are not part of the collection of the library. My guess is most libraries will solve this by creating an itemtype called something like ILL, and use OpacHiddenItems to hide these records from browsing and searching in the OPAC. When such an item is on loan to the patron it does show up in "my summary" in the OPAC, but the link from the title leads to a 404, which is not ideal. A couple of different solutions come to mind: 1. Detect that the item on loan is hidden and don't display the link 2. Detect that the item on loan is hidden and display the record in some other way than through a link to the regular OPAC detail view, for example in a pop-up. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 16154] New: Replace CGI->param with CGI->multi_param in list context
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '21

25 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Bug ID: 16154 Summary: Replace CGI->param with CGI->multi_param in list context Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15809 Bug 15809 is now pushed, we are able to replace the occurrences of CGI->param with CGI->multi_param when needed (in list context). my @foo = $cgi->param('foo'); must be replaced with my @foo = $cgi->multi_param('foo'); and $template->param( foo => $cgi->param('foo') ); must be replaced with $template->param( foo => scalar $cgi->param('foo') ); Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 [Bug 15809] versions of CGI < 4.08 do not have multi_param -- You are receiving this mail because: You are watching all bug changes.

1 55

[Bug 18625] New: update borrower last seen from SIP
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '21

25 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Bug ID: 18625 Summary: update borrower last seen from SIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Bug 16276 added a syspref and field for last seen. In addition to the places there it should also be updated from SIP. The rationale is this in addition to the self check functions handled by sip an increasing number of packages are available which use sip to authenticate users as being valid library patrons to access various resources e.g. computer equipment, ebooks or services via a proxy. Some library patrons may only be using the library to access the internet (validated by sip) and never borrower items or sign in via the opac. The proposal is to update last seen if the borrower is a subject of a 63 (Patron Information request) from sip. We have a number of sites currently maintaining this in a patron attribute. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 36

[Bug 15758] New: Move the C4::Branch related code to Koha::Libraries - part 4
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Bug ID: 15758 Summary: Move the C4::Branch related code to Koha::Libraries - part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15629 Blocks: 15293 This fourth and last part will remove: - GetBranchName - GetBranchesLoop - GetBranches - GetBranch will move mybranch and onlymine to C4::Context and finally remove all occurrences of C4::Branch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes.

1 169