June 2021 - Koha-bugs - lists.koha-community.org

[Bug 21472] New: Links in Additional Formats section of bib details do not work
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '23

18 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Bug ID: 21472 Summary: Links in Additional Formats section of bib details do not work Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul(a)flo.org QA Contact: testopia(a)bugs.koha-community.org The links that appear under the heading Additional Formats, built using data from 776 fields, are hardcoded to be like this in the OPAC: /cgi-bin/koha/opac-search.pl?q=control-number:__________ And like this in the staff interface: /cgi-bin/koha/catalogue/search.pl?q=control-number:__________ The blanks are filled in with the contents of the 776 field, subfield $w, with any parenthesized organization code stripped. Thus, for example, a 776 field like this: 776 08 $i Online version: [...] $z 9781938168000 $w (OCoLC)895896190 Would yield a staff URL like this: /cgi-bin/koha/opac-search.pl?q=control-number:895896190 But that link won't work, at least not in our case; control numbers found in 035 $a are indexed as other-control-number, not control-number, and the organization code is not stripped when indexing. However, a link like this does retrieve the bib record with the 776 field given above: /cgi-bin/koha/catalogue/search.pl?idx=other-control-number,phr&q=(OCoLC)895896190 These links are built in /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl (lines 808 ff.) and /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl (lines 756 ff.); for example, the latter looks like this:  <xsl:if test="marc:datafield[@tag=776]"> <span class="results_summary add_physical_form"> <span class="label">Additional physical formats: </span> <xsl:for-each select="marc:datafield[@tag=776]"> <xsl:variable name="linktext"> <xsl:choose> <xsl:when test="marc:subfield[@code='t']"> <xsl:value-of select="marc:subfield[@code='t']"/> </xsl:when> <xsl:when test="marc:subfield[@code='a']"> <xsl:value-of select="marc:subfield[@code='a']"/> </xsl:when> <xsl:otherwise> <xsl:text>No title</xsl:text> </xsl:otherwise> </xsl:choose> </xsl:variable> <xsl:if test="@ind2=8 and marc:subfield[@code='i']"> <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">i</xsl:with-param> </xsl:call-template> <xsl:text>: </xsl:text> </xsl:if> <xsl:choose> <xsl:when test="marc:subfield[@code='w']"> <a> <xsl:attribute name="href"> <xsl:text>/cgi-bin/koha/catalogue/search.pl?q=control-number:</xsl:text> <xsl:call-template name="extractControlNumber"> <xsl:with-param name="subfieldW"> <xsl:value-of select="marc:subfield[@code='w']"/> </xsl:with-param> </xsl:call-template> </xsl:attribute> <xsl:value-of select="$linktext"/> </a> </xsl:when> <xsl:otherwise> <xsl:value-of select="$linktext"/> </xsl:otherwise> </xsl:choose> <xsl:if test="position() != last()"> <xsl:text>; </xsl:text> </xsl:if> </xsl:for-each> </span> </xsl:if> The template "extractControlNumber" extracts the control number (minus parenthesized prefix) from the value in 776 $w. Unfortunately, this template is used elsewhere so I'm not sure it's safe to change it so that it does *not* strip the parenthesized prefix. Perhaps we could add a second parameter to it that specifies whether or not to strip it, with the default set to true. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 18186] New: Amounts with decimal comma instead of decimal dot breaking payments
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '23

16 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Bug ID: 18186 Summary: Amounts with decimal comma instead of decimal dot breaking payments Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In our current installations running under Plack, the amounts on the pay and paycollect pages suddenly started showing with a decimal comma instead of a decimal point. This causes quite a bit of trouble, as Koha expects a . and amounts entered didn't result in the expected payments. We got several reports about payments being broken in Koha. Test plan: - Add manual invoice - View the "fines" tag - Verify that individual fees and totals display with , instead of . - Pay selected or any amount - Verify that the input field for the amount is also showing the , - Verify that paying something like 1,10 doesn't work as expected. The problem with the test plan is, that you might not see the ,. This appears only on our productions servers, but not in my development environment. We tested: - different language settings in Koha - different language settings in the browser - verified that CurrencyFormat isn't used in the code on those page - verified that all the formatting done was using the TT filter format('%.2f') In the end the problem turned out to be related to Plack. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 21809] New: Deleting a request does not delete its log entries
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21809 Bug ID: 21809 Summary: Deleting a request does not delete its log entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Bug 20750 adds the ability for events on ILL requests to be logged in the action logs. Currently changes to request status can be logged. However, when a request is deleted, the logs associated with that request are not. Since the request ID then becomes available, the next time a request is created, it will re-use the ID of the deleted request and instantly be associated with the log entries for that request. It's not currently possible to fix this since C4::Log doesn't provide any methods to delete log entries. So I'm going to add an enhancement bug for that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 22528] New: Add tab with current/active ILL requests to patron circulation page
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 Bug ID: 22528 Summary: Add tab with current/active ILL requests to patron circulation page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com Target Milestone: --- Bug 18589 added ILL requests history page to patron account, it would be great to have access to current (not completed) ILL requests on circulation page as another tab - the same way we have access to holds and relatives checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 23559] New: REST API: Overwrite an ILL request
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23559 Bug ID: 23559 Summary: REST API: Overwrite an ILL request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: black23(a)gmail.com Method OUT /ill_requests/{ill_request_id} https://wiki.koha-community.org/wiki/Illrequests_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 23561] New: REST API: Partially update an ILL request
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23561 Bug ID: 23561 Summary: REST API: Partially update an ILL request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: black23(a)gmail.com Method PATCH /ill_requests/{ill_request_id} -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 24258] New: Sending partner request doesn't fall back to KohaAdminEmailAddress
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24258 Bug ID: 24258 Summary: Sending partner request doesn't fall back to KohaAdminEmailAddress Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com The code only looks for the branchemail, and if there is none, it doesn't fall back to KohaAdminEmailAddress. To reproduce : - If your branches have emails, remove them - Make sure KohaAdminEmailAddress is filled - Go to ILL module - Create a request - Click on 'Place request with partners' - Click 'Send email' I get an error message 'Your library has no usable email address. Please set it.' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 28634] New: ILL partner request notices are attached to the request creator rather than the partner recipient
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Bug ID: 28634 Summary: ILL partner request notices are attached to the request creator rather than the partner recipient Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com When send an ILL request to a partner, the borrowernumber of the entry in message_queue should be the ID of the recipient of the notices, instead the ID of the user who created the ILL request is used instead. The upshot of this is that although the notice goes to the correct recipient, it is attached to the wrong user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 23714] New: Problem with ILLModuleUnmediated
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23714 Bug ID: 23714 Summary: Problem with ILLModuleUnmediated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no If you run this: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev you get this: Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/Illrequest.pm line 857. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/Illrequest.pm line 859 (Among some other warnings that are fixed on bug 23712.) Lines 857 and 859 look like this: my $intra_tmpl = join "/", $backend_tmpl, "intra-includes", $params->{method} . ".inc"; my $opac_tmpl = join "/", $backend_tmpl, "opac-includes", $params->{method} . ".inc"; $params->{method} is uninitialized because of these lines in Koha::Illrequest::backend_create(): if ( C4::Context->preference("ILLModuleUnmediated") && $permitted ) { my $unmediated_result = $self->_backend_capability( 'unmediated_ill', $args ); $result = $unmediated_result if $unmediated_result; } This replaces whatever was in $result. So before this code you can have a $result that looks like this: $VAR1 = { 'stage' => 'commit', 'method' => 'create', 'permitted' => 1 }; and after the code it looks like this: $VAR1 = { 'unmediated_ill' => 1 }; Is this the intended behaviour? If no, we should fix it (add 'unmediated_ill' => 1 to the existing data instead of replacing it?). If yes, we should make expandTemplate() handle a missing method more gracefully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 23032] New: Add 264 to Alternate Graphic Representation (MARC21 880)
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '23

13 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 Bug ID: 23032 Summary: Add 264 to Alternate Graphic Representation (MARC21 880) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 3567 Target Milestone: --- The 880 field containing information from 264 is not displayed in the OPAC and intranet detail pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3567 [Bug 3567] Display Alternate Graphic Representation (MARC21 880) in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22