September 2021 - Koha-bugs - lists.koha-community.org

[Bug 26587] New: detail.pl is very slow for records with many items
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '22

14 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Bug ID: 26587 Summary: detail.pl is very slow for records with many items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Using Plack Koha, it took about 10 seconds to load detail.pl for a page with 350 items. Looking at the code, we loop through order, subscriptions, and items. I haven't done any benchmarking, but my guess would be the slowdown comes when looping through the items, as there are lots of database calls made in that loop. I think optimizations come down to the following (which are not mutually exclusive): 1. Get the full count of items but only lookup/render a subset using an AJAX call 2. Use fewer database calls in the loop by fetching all the data needed from the database and then processing it as necessary in the loop 3. Use fewer external cache lookups by doing things like C4::Context->preference('UseCourseReserves') outside of the loop rather than inside the loop -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 47

[Bug 23713] New: Subscription add form broken for translations
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '22

14 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Bug ID: 23713 Summary: Subscription add form broken for translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com It's not possible to add a new subscription using translated templates. What I see is: English template: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %]0[% END %]; de-DE template: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %][% END %]; We are also missing a semicolon in one of the lines, but this doesn't seem to effect the page functionality: var MSG_PATTERN_IRREG = _("Warning! Present pattern has planned irregularities. Click on 'Test prediction pattern' to check if it's still valid") Thx to Michael Hoffert and Alexander Arlt from koha-de for reporting it initially and figuring out the root of the issue! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 32

[Bug 27212] New: Add column configuration to the acquisitions home page
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '22

10 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Bug ID: 27212 Summary: Add column configuration to the acquisitions home page Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: barbara.johnson(a)bedfordtx.gov QA Contact: testopia(a)bugs.koha-community.org It would be helpful to be able to hide columns from the accounts table when viewing available funds on acqui-home.pl We're a single site library so we don't need the library column and we don't use the owner column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 22630] New: Allow to change homebranch in course reserves
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Bug ID: 22630 Summary: Allow to change homebranch in course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 91

[Bug 29004] New: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 Bug ID: 29004 Summary: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 10988 GoogleOpenIDConnect and related system preferences only affect the OPAC, but the system preference descriptions don't make that explicit. The description should be modified to mention that it only applies to the OPAC. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 16258] New: Add a preference to turn EDIFACT off
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Bug ID: 16258 Summary: Add a preference to turn EDIFACT off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Acq is a complicated module and the new EDIFACT related options and features add another layer of complexity. It would be good if the feature could be turned off for libraries not interested in the functionality to help simplify working with acq a bit again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 76

[Bug 24153] New: Add a confirm flag to the cleanup_database.pl cronjob
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Bug ID: 24153 Summary: Add a confirm flag to the cleanup_database.pl cronjob Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz That will allow to make it run in dry-run mode with a useful verbose output -- You are receiving this mail because: You are watching all bug changes.

1 56

[Bug 23407] New: XSLT Details pages don't use items, we shouldn't pass them
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Bug ID: 23407 Summary: XSLT Details pages don't use items, we shouldn't pass them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org C4::XSLT::XSLTParse4Display calls buildKohaItemsNamespace() for all displays For IntranetDetails and OPACDetails there is no item processing. Removing this call can save us time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 26979] New: Show correctly-pluralized labels on checkouts page tabs
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '22

07 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Bug ID: 26979 Summary: Show correctly-pluralized labels on checkouts page tabs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 21156 I suggest we modify the way we display counts on the checkouts page tabs (checkouts, holds, claims, etc). I suggest we use the new pluralization template syntax (Bug 21156) to show counts on the tabs. Example screenshot: https://zivotdesign.com/p/#1/15980387474009 Besides avoiding parentheses in labels like "10 Checkout(s)," this change would show the count of only unresolved claims and enrolled clubs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 23166] New: Simplify code related to orders in catalogue/*detail.pl
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '22

07 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Bug ID: 23166 Summary: Simplify code related to orders in catalogue/*detail.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23084, 9780 Target Milestone: --- Since bug 9780 we are the ability to alert the librarian when a record which has been ordered will be deleted. Then the code to handle the alert has been copied to other catalogue/*detail.pl script, as the JS check is in the toolbar. This code is really unnecessary complicated and sometime simply not necessary. It could be replaced with Koha::Acquisition::Orders->search and make it more readable. (found it working on bug 23084, so writing it on top of it). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 [Bug 9780] Restrict the right to suppress a record used in some order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} -- You are receiving this mail because: You are watching all bug changes.

1 77