March 2022 - Koha-bugs - lists.koha-community.org

[Bug 30414] New: Inconsistent (duplicated) FK constraint name: aqbudgets.aqbudgetperiods_ibfk_1
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30414 Bug ID: 30414 Summary: Inconsistent (duplicated) FK constraint name: aqbudgets.aqbudgetperiods_ibfk_1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CREATE TABLE `aqbudgets` ( [etc] CONSTRAINT `aqbudgetperiods_ibfk_1` FOREIGN KEY (`budget_period_id`) REFERENCES `aqbudgetperiods` (`budget_period_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; Normally, our constraints have the prefix showing the source table not the destination (aqbudgetperiods) like here. DBrev20.06.00.055 contained this: if ( !foreign_key_exists( 'aqbudgets', 'aqbudgetperiods_ibfk_1' ) ) { $dbh->do(q| ALTER TABLE aqbudgets ADD CONSTRAINT `aqbudgetperiods_ibfk_1` FOREIGN KEY (`budget_period_id`) REFERENCES `aqbudgetperiods` (`budget_period_id`) ON UPDATE CASCADE ON DELETE CASCADE |); This created aqbudgetperiods_ibfk_1 next to aqbudgets_ifbk_1 that we already had in our production table. Note that DBrev 3.01.00.077 already contained that one: ALTER TABLE `aqbudgets` ADD CONSTRAINT `aqbudgets_ifbk_1` FOREIGN KEY (`budget_period_id`) REFERENCES `aqbudgetperiods` (`budget_period_id`) ON DELETE CASCADE ON UPDATE CASCADE Conclusion: Older Koha database may contain a duplicated FK constraint. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 26381] New: Koha should provide Koha plugins with a template to use with Template::Toolkit WRAPPER
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26381 Bug ID: 26381 Summary: Koha should provide Koha plugins with a template to use with Template::Toolkit WRAPPER Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org At the moment, Koha plugins have to built their own templates from scratch. I'm proposing that Koha provides a BLOCK or a template file that Koha plugins can then use with the Template::Toolkit WRAPPER directive to minimize the amount of boiler plate they have to use. Here is an example of a very simple "plugin_wrapper" [% BLOCK plugin_wrapper %] [% INCLUDE 'doc-head-open.inc' %] <title>Koha: [% name %]</title> [% INCLUDE 'doc-head-close.inc' %] </head> <body> [% INCLUDE 'header.inc' %] [% INCLUDE 'cat-search.inc' %] <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/plugins/plugins-home.pl">Plugins</a> &rsaquo; [% breadcrumb %]</div> <div id="doc3"> [% content %] [% INCLUDE 'intranet-bottom.inc' %] [% END %] Then, in my report-step1.tt file, all I need to include is the following: [% WRAPPER plugin_wrapper name = 'My Plugin' breadcrumb = 'My Plugin' %] <div>Plugin content</div> [% END %] I've already tested this a little bit, and it's beautiful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 23330] New: deleteditemsstocknumberidx should not be a unique index
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '22

07 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23330 Bug ID: 23330 Summary: deleteditemsstocknumberidx should not be a unique index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org At the moment, deleteditemsstocknumberidx is a unique index, which means that an item will fail to delete if its "Inventory number" already exists in the deleteditems table. Its counterpart itemsstocknumberidx was renamed to itemstocknumberidx in version 3.03.00.042 (dating from April/May 2011) and made non-unique. I've worked on Koha since early 2012 and only today have I had someone stung by this problem. They've been storing "Copy number" in "Inventory number" for some reason, and it's caught them out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 28758] New: Undefined subroutines in C4/ImportBatch.pm (bug 17600)
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '22

06 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28758 Bug ID: 28758 Summary: Undefined subroutines in C4/ImportBatch.pm (bug 17600) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 20421] New: Inform staff that patron does have the title checked out during placing hold
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '22

06 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Bug ID: 20421 Summary: Inform staff that patron does have the title checked out during placing hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 30155] New: We shouldn't calculate get_items_that_can_fill when we don't have any holds
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '22

05 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30155 Bug ID: 30155 Summary: We shouldn't calculate get_items_that_can_fill when we don't have any holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com This breaks the 'Holds to pull' report in 21.05.09 if there are no holds "Fixed" by bug 3142 in 21.05.11 and master The problem is essentially that calculation of @bibs_or_items can be empty if no holds are passed, so our SQL Abstract call ends up with an emptpy -or block, which in turn leads to our where beginning with "AND" DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'AND `itemlost` = '0' AND `itemnumber` NOT IN ( '156269' ) AND 1=1 AND `notforloa' at line 1 [for Statement "SELECT `me`.`itemnumber`, `me`.`biblionumber`, `me`.`biblioitemnumber`, `me`.`barcode`, `me`.`dateaccessioned`, `me`.`booksellerid`, `me`.`homebranch`, `me`.`price`, `me`.`replacementprice`, `me`.`replacementpricedate`, `me`.`datelastborrowed`, `me`.`datelastseen`, `me`.`stack`, `me`.`notforloan`, `me`.`damaged`, `me`.`damaged_on`, `me`.`itemlost`, `me`.`itemlost_on`, `me`.`withdrawn`, `me`.`withdrawn_on`, `me`.`itemcallnumber`, `me`.`coded_location_qualifier`, `me`.`issues`, `me`.`renewals`, `me`.`reserves`, `me`.`restricted`, `me`.`itemnotes`, `me`.`itemnotes_nonpublic`, `me`.`holdingbranch`, `me`.`timestamp`, `me`.`location`, `me`.`permanent_location`, `me`.`onloan`, `me`.`cn_source`, `me`.`cn_sort`, `me`.`ccode`, `me`.`materials`, `me`.`uri`, `me`.`itype`, `me`.`more_subfields_xml`, `me`.`enumchron`, `me`.`copynumber`, `me`.`stocknumber`, `me`.`new_status`, `me`.`exclude_from_local_holds_priority` FROM `items` `me` WHERE ( ( AND `itemlost` = ? AND `itemnumber` NOT IN ( ? ) AND 1=1 AND `notforloan` = ? AND `onloan` IS NULL AND `withdrawn` = ? ) )" with ParamValues: 0=0, 1=156269, 2=0, 3=0] at /usr/share/koha/lib/Koha/Objects.pm line 145 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 28200] New: Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '22

05 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Bug ID: 28200 Summary: Net::Netmask 1.9104-2 requires constructor change for backwards compatibility Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org As Jonathan and David noted in Bug 25950, Net::Netmask needs a constructor change from 1.9104-2 in order to accept abbreviated formats. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 54

[Bug 26055] New: Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '22

05 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055 Bug ID: 26055 Summary: Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl The Advanced Editor (Rancor) uses a tag's mandatory flag to decide whether to show in the UI when showing an editor for a new record. This doesn't make 100% sense, since often a cataloguer will also want to see optional fields (like 500) by default to serve as a prompt. In systems like Horizon, one refers to these as "templates". You have a separate set of typical fields for books, journals, DVDs, etc. You don't have to fill in all those fields, but they're the typical fields that you would use for them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 25523] New: Address lintian warnings when packaging Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '22

05 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25523 Bug ID: 25523 Summary: Address lintian warnings when packaging Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net I notice that lintian raises a lot of warnings when building Koha packages. Some of these like the following can be safely ignored: W: koha-common: embedded-javascript-library usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min.js please use libjs-jquery-cookie W: koha-common: embedded-javascript-library usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.metadata.min.js please use libjs-jquery-metadata But then there are others that would be easy wins: W: koha-common: executable-not-elf-or-script usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/admin/additional-fields.tt W: koha-common: executable-not-elf-or-script usr/share/koha/lib/C4/HoldsQueue.pm W: koha-common: executable-not-elf-or-script usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/subtag_registry.sql I'm thinking about slowly tackling these... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 22344] New: Limits cannot contain parentheses
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '22

05 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22344 Bug ID: 22344 Summary: Limits cannot contain parentheses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au Target Milestone: --- I've noticed an authorised value of category LOC can't have parentheses in it. If it does, the search silently fails... I'm guessing it doesn't even make it from the ZOOM library in Koha over the connection to Zebra. I'm going to explore in a moment, but people have noticed this and kind of worked around it with #5693 and #7031. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9