April 2022 - Koha-bugs - lists.koha-community.org

[Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 134354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134354&action=e… Bug 10517: (QA follow-up) No need to remove second true This is just theoretical, but by removing the second true you could end the script on another error. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133758|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 134353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134353&action=e… Bug 10517: Use `DROP USER IF EXISTS` and remove ` || true`. When restoring a Koha instance, and the database user does not exist, an error is shown, although it is prevented from stopping the script by ` || true`. This patch removes the ` || true` guard, and rather uses `DROP USER IF EXISTS` which does exactly what one would expect, without confusing error messages, whether the user existed or not. To test: 1) Assume your Koha instance is called `asdf`. 1) Export the Koha instance using `koha-dump`. 2) Remove the instance completely using `koha-remove`. 3) Import it again using `koha-restore`. 4) No error should be shown, and the import should work. There was NO user to drop, therefore `DROP USER IF EXISTS` did nothing. 5) A database user called `koha_asdf` should exist, and have all privileges on the database of the same name. 6) Remove the instance again using `koha-remove`. 7) Now create a database user in MySQL called `koha_instance` where instance is the name of your dumped koha instance. 8) Import your koha instance again using `koha-restore`. 9) Again, no error should be shown, and the import should work. There WAS a user to drop, therefore `DROP USER IF EXISTS` dropped the user before creating a new one. 10) Again, a database user called `koha_asdf` should exist, and have all privileges on the database of the same name. Sponsored-by: Reformational Study Centre Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30527] New: Limits are not correctly parsed when query contains CCL
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30527 Bug ID: 30527 Summary: Limits are not correctly parsed when query contains CCL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com This was made more apparent by bug 17170 - when a special limit that needs parsing is passed along witha query containing CCL indexes then the limits are not parsed (with exception of 'available' which is handled) This is due to a clause the prevents the normal parsing in C4::Search::buildQuery To test: 1 - Perform advanced search in staff client 2 - Select 'More options' 3 - In first box with keyword as index type 'ti:a' 4 - Enter a year into Limits 5 - Search 6 - You see only 'ti:a' in description, and search fails with bug 17170 1 - Save a search filter visible in staff client 2 - Perform a search like 'ti:a' 3 - Attempt to filter using custom filter 4 - In plack intranet error log: [2022/04/13 14:14:51] [WARN] WARNING: query problem with ti=a and search_filter=94 ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 352. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 9097] Add option to trigger 'Welcome mail' manually
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30611 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30611 [Bug 30611] Add ability to send passwordreseturl from the staff client -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #13 from Hayley Pelham <hayleypelham(a)catalyst.net.nz> --- Created attachment 134327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134327&action=e… Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #12 from Hayley Pelham <hayleypelham(a)catalyst.net.nz> --- Created attachment 134326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134326&action=e… Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #11 from Hayley Pelham <hayleypelham(a)catalyst.net.nz> --- Created attachment 134325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134325&action=e… Bug 6796: ConsiderLibraryHoursWhenIssuing system preference -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Hayley Pelham <hayleypelham(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124669|0 |1 is obsolete| | Attachment #124670|0 |1 is obsolete| | Attachment #124671|0 |1 is obsolete| | Attachment #124672|0 |1 is obsolete| | --- Comment #10 from Hayley Pelham <hayleypelham(a)catalyst.net.nz> --- Created attachment 134324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134324&action=e… Bug 6796: Updated schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '22

29 Apr '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #9 from Hayley Pelham <hayleypelham(a)catalyst.net.nz> --- Created attachment 134323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134323&action=e… Bug 6796: Add branch_hours table and set opening hours for library -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0