May 2022 - Koha-bugs - lists.koha-community.org

[Bug 29796] New: Cannot create new patron accounts
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 Bug ID: 29796 Summary: Cannot create new patron accounts Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: jhenderson(a)nsd.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Hello, My Koha installation suddenly will no longer allow me to create patron accounts. The first prompt I receive is: "Something went wrong when creating the patron. Check the logs." When I open the plack-intranet-log I see this: [2022/01/04 20:42:19] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 354 I am honestly stumped, I was not having this problem before and I haven't changed any settings that would have caused this. Thankfully, I can use the self-registration feature as a workaround right now until this can get fixed. I can provide additional details if needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 28301] New: Add ability to force re-run of a particular DB update
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28301 Bug ID: 28301 Summary: Add ability to force re-run of a particular DB update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When there are errors in the updates it would be nice to have a way to execute a single DB update easily -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #204 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- (In reply to Jonathan Druart from comment #196) > Can you please review the whole patch set carefully to make it ready for QA? > > It took me 3 min to catch trivial errors: > * merge marker > +<<<<<<< HEAD > > * installer/data/mysql/nb-NO/2-Valgfritt/patron_categories.sql > has been removed, this patch set reintroduce it > > * in members/memberentry.pl there are 2 calls to search_with_library_limits > > * still memberentry.pl > You are adding yet another fetch of the patron category: > Koha::Patron::Categories->find > It's fetched several times already in the same script > > * t/db_dependent/Patrons.t l.206: extra spaces Fixed mentioned errors except "Koha::Patron::Categories->find". It would require a new variable near the beginning of the script (after "my $categorycode ...") that stores "Koha::Patron::Categories->find($categorycode)" and would also require changing every place where the script uses it for consistency. I don't know if it's a good idea to do it here. Maybe a separate bug? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135509|0 |1 is obsolete| | --- Comment #203 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 135512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135512&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134936|0 |1 is obsolete| | --- Comment #202 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 135511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135511&action=e… Bug 12446: Fixing QA tool's tests This patch fixes tests that fails by the QA test tool. I removed the debug variable, since it is not used. I also got a few spelling check errors when I ran the QA test tool. I corrected them too. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass 17) Run the QA test tool. All tests should say OK Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134935|0 |1 is obsolete| | --- Comment #201 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 135510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135510&action=e… Bug 12446: Any patron categories can have guarantors Rebase of previous patches This patch allows adult patrons to have guarantors. It adds the field "Can be guarantee" to patron categories, so it becomes possible for any category type to have a guarantor. NOTE: Attachment "Bug 12446: Adult can now have guarantors" created a sha1 error. I marked it as obsolete and put it's content into a new commit. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134934|0 |1 is obsolete| | --- Comment #200 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 135509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135509&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134933|0 |1 is obsolete| | --- Comment #199 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 135508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135508&action=e… Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134932|0 |1 is obsolete| | --- Comment #198 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 135507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135507&action=e… Bug 12446: Schema update Category.pm Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134931|0 |1 is obsolete| | --- Comment #197 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 135506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135506&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0