July 2022 - Koha-bugs - lists.koha-community.org

[Bug 30920] New: Add caching to C4::Biblio::GetAuthorisedValueDesc
by bugzilla-daemon＠bugs.koha-community.org 04 May '23

04 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 Bug ID: 30920 Summary: Add caching to C4::Biblio::GetAuthorisedValueDesc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Whilst working on bug 30848 inspired by bug 28371 it became apparent we're using this function a huge amount inside of various loops. We should cache the data to allow for performance improvements. The patches submitted here have been pulled out of the submission for bug 30848 as they have a much wider effect and need proper independent testing. In benchmarking I found that enabling the caching in the way here gave me very significant performance improvements as compared to bug 28371. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 66

[Bug 29303] New: quick add form duplicates HTML ID's
by bugzilla-daemon＠bugs.koha-community.org 04 May '23

04 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Bug ID: 29303 Summary: quick add form duplicates HTML ID's Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We noticed while trying to add some jQuery to the quick add from that there are duplicate id's on the page for each input. The jQuery on memberentrygen.tt checks to see what fields should be present on the quick_add_form and then uses jQuery clone() to add them to the quick_add_form. The problem is this creates duplicate ID's which is invalid HTML. We should change those cloned ID's so they are not duplicates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 30978] New: Potential data loss when using Quick add new patron
by bugzilla-daemon＠bugs.koha-community.org 04 May '23

04 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30978 Bug ID: 30978 Summary: Potential data loss when using Quick add new patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When using the Quick add new patron form with mandatory fields, if a mistake is made, data can be lost. To replicate: - In System Preferences, go to: BorrowerMandatoryField - Put in some mandatory fields - e.g. firstname, surname, cardnumber - Go to Patrons - Press +Quick add new patron - Choose patron as a category type - Note that firstname, surname and cardnumber are all mandatory fields - Put data into firstname and cardnumber - Do not put any data in surname - Press Save The form will not submit because surname is a required field - and a prompt is shown: "This field is required." - Now correct your mistake and fill in the surname - Press Save - The form now submits and creates an account - but the corrected surname field is still blank I've tested this with a range of fields - and I've added 10 mandatory fields and submitted a form with 2, then corrected 4, then submitted again etc - and the form always sends the very first version and disregards any amendments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 30590] New: Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module
by bugzilla-daemon＠bugs.koha-community.org 04 May '23

04 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 Bug ID: 30590 Summary: Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It would be useful if all patrons, regardless of whether they have the self_checkin_module sub-permission enabled, could check items in using the OPAC self check-in module. This could be achieved by adding a syspref allowing libraries to choose if the Koha patron defined in the AutoSelfCheckID and AutoSelfCheckPassw sysprefs can log into the self check-in module. We want this so that it can be an option to add behaviour that mirrors the self check-out. Currently, the patron in the AutoSelfCheckID and AutoSelfCheckPass sysprefs can only be used to log into the self check-out module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 30472] New: Field borrower_relationships.guarantor_id should be marked as NOT NULL
by bugzilla-daemon＠bugs.koha-community.org 04 May '23

04 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Bug ID: 30472 Summary: Field borrower_relationships.guarantor_id should be marked as NOT NULL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org See also $DBversion = '19.06.00.022'; CREATE TABLE `borrower_relationships` [...] guarantor_id INT(11) NOT NULL, guarantee_id INT(11) NOT NULL, Many production db's will have both fields already NOT NULL. We need to adjust kohastructure and DBIx Note that non-patron guarantors are NOT saved in this table but in the borrowers table itself IIUC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 31259] New: Downloading patron card PDF hangs the server
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 Bug ID: 31259 Summary: Downloading patron card PDF hangs the server Change sponsored?: --- Product: Koha Version: 21.11 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: jake.deery(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Hi, One of our customers is having an issue with their patron card creator, that we have been able to replicate on our support server. Both installations are Debian package installations, and both installations run atop Debian 10. When one goes to create a 'patron card' using the build-in patron card creator found under Tools > Patron card creator, the download process loops endlessly and eventually returns a Proxy Timeout (we have tried without Plack). Steps to reproduce: 1. Create printer profile with: * 0mm x 0mm offset * 0mm x 0mm creep 2. Create card template with: * 297mm x 210mm page * 99.1mm x 38.1 card * 15mm top page margin * 5mm left page margin * 2 columns * 7 rows * 3mm gap between columns * 0mm gap between rows 3. Create layout with: * Guide box on * Guide grid off * Field 1 text to 'Name: <firstname> <surname>' * Font to 'Courier' * Font size to 14pt * Text alignment to left * Lower left X co-ord to 20mm * Lower left Y co-ord to 25mm * Print card number as barcode: yes * Lower left X co-ord: 30 * Lower left Y co-ord: 10 * Barcode type: CODE39 * Print card number as text under barcode: yes 4. Add two patrons to a new card batch, and use the previously created printer profile, card template, and layout. 5. Export the entire batch as a PDF. 6. The software will hang, and a 'create-ptf.pl' process will run indefinitely koha@demo1:~$ sudo ps aux | grep perl support+ 30344 93.1 5.2 287880 210820 ? R 10:06 0:05 /usr/bin/perl /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl The create-ptf.pl script eats the CPU, and also appears to leak memory indefinitely, until the OOM killer is forced to step in. I have tried changing a few different values, including the font (as I thought maybe it was Courier being missing in Linux), all to no avail. If anyone has the time to take a look at this, or has a vague idea of what lines to look at so I can see if I can fix it myself, that would be hugely appreciated. Many thanks, Jake -- You are receiving this mail because: You are watching all bug changes.

1 32

[Bug 28641] New: ILLHiddenRequestStatuses does not consider custom statuses
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Bug ID: 28641 Summary: ILLHiddenRequestStatuses does not consider custom statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com The ILLHiddenRequestStatuses syspref does a good job of filtering out requests that have statuses matching the specified values, but it doesn't take into account custom statuses. To demonstrate this, create a custom ILL status authorised value, give a request that value, then specify the status code in ILLHiddenRequestStatuses. Then view the list of requests, the list will contain the request with the custom status. Additional filtering needs to be added to filter out requests with a custom status code matching the specified values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 29173] New: Button "replace authority record via Z39/50/SRU" doesn't work
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Bug ID: 29173 Summary: Button "replace authority record via Z39/50/SRU" doesn't work Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: marion.durand(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl To replace an authority record via Z39.50/SRU there are two buttons on differents pages but their behaviour is not the same. One pre-fill the search form but the other don't. If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Replace record via Z39.50/SRU" Then: "Z39.50 authority search points" pop up but all field are empty. But If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Edit record" 3- Click on the button "Replace record via Z39.50/SRU search" Then: "Z39.50 authority search points" pop up with usefull values already filled (for example the Author) There is the same two button for bibliographic record and both of them pre-fill the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 78

[Bug 29942] New: Spurious commit in mysql session storage
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29942 Bug ID: 29942 Summary: Spurious commit in mysql session storage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se QA Contact: testopia(a)bugs.koha-community.org The DBI storage driver for CGI::Session commits any on-going transactions in its destructor subroutine. Consequently if SessionStorage is set to mysql, instantiating a session and assigning it to a local variable inside a transaction will unexpectedly cause the transaction to be committed as illustrated by the below script. I have reported this issue upstream and created pull requests but it is unclear if anyone is maintaining CGI::Session. https://rt.cpan.org/Ticket/Display.html?id=140855 https://github.com/cromedome/cgi-session/pull/5 We should maybe consider maintaining our own fork of CGI::Session. #!/usr/bin/perl -w use DBI; use C4::Auth; use Koha::Database; use strict; my $dbh = C4::Context->dbh; my $schema = Koha::Database->schema; print "SessionStorage: '" . C4::Context->preference('SessionStorage') . "'\n"; sub test { my $session = C4::Auth::get_session(""); } $dbh->do("CREATE TABLE IF NOT EXISTS `tmp_test_cgi_session` (foo TINYTEXT)"); eval { $schema->txn_do(sub { my $sth = $dbh->prepare("INSERT INTO `tmp_test_cgi_session` VALUES ('foo')"); $sth->execute(); test(); die "error"; }); }; if ($@) { print $@, "\n"; } my $sth = $dbh->prepare("SELECT * FROM `tmp_test_cgi_session`;"); $sth->execute(); # The INSERT of the foo row should have been rolled back, but isn't when # SessionStorage is 'mysql'. while (my $row = $sth->fetchrow_arrayref) { print $row->[0], "\n"; } $dbh->do("DROP TABLE `tmp_test_cgi_session`"); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 22718] New: Authorized value for not for loan not showed in cataloging search results
by bugzilla-daemon＠bugs.koha-community.org 02 May '23

02 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22718 Bug ID: 22718 Summary: Authorized value for not for loan not showed in cataloging search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: alexandre.breton(a)ccsr.qc.ca QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Target Milestone: --- In the search results in cataloging module (staff client interface), the reason why an item is "not for loan" isn't showed (in the Location column) and can create some confusing situation. For example, some schools put the authorized values for online items and they can't be available for a physical loan but are always available. Are we able to add in the authorized value for the "not for loan" status, something like "not for loan (authorized value)" ? In the same manner as it appears in a normal search in the catalog. In the cataloging module, the info only appears in the detailed view of the item. Thanks, Alexandre -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4