October 2023 - Koha-bugs - lists.koha-community.org

[Bug 3007] Remove untranslated unimarc_field_700-4 value builder
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|koha-bugs(a)lists.koha-commun |katrin.fischer(a)bsz-bw.de |ity.org | --- Comment #59 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Trying to do a first run through here, but I feel like we might want another set of eyes maybe on the date calculations later on: 1) QA Test Tools FAIL C4/Circulation.pm FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). WARN tidiness The file is less tidy than before (bad/messy lines before: 1100, now: 1106) WARN Koha/Schema/Result/Branch.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 222, now: 226) FAIL Koha/Schema/Result/BranchHour.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 18) WARN admin/branches.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 47, now: 58) WARN installer/data/mysql/atomicupdate/bug_6796_-_add_ConsiderLibraryHoursWhenIssuing_syspref.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) WARN installer/data/mysql/atomicupdate/bug_6796_-_add_branch_hours_table.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 8) FAIL t/db_dependent/Circulation/CalcDateDue.t WARN tidiness The file is less tidy than before (bad/messy lines before: 138, now: 164) FAIL valid Global symbol "$categorycode" requires explicit package name (did you forget to declare "my $categorycode"?) Global symbol "$categorycode" requires explicit package name (did you forget to declare "my $categorycode"?) t/db_dependent/Circulation/CalcDateDue.t had compilation errors. The last one I believe might be responsible for the unit tests not passing. Please make always sure to run QA tests and unit tests on rebase: Global symbol "$categorycode" requires explicit package name (did you forget to declare "my $categorycode"?) at t/db_dependent/Circulation/CalcDateDue.t line 414. Execution of t/db_dependent/Circulation/CalcDateDue.t aborted due to compilation errors. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Circulation/CalcDateDue.t .. Dubious, test returned 255 (wstat 65280, 0xff00) 2) Terminology a) ConsiderLibraryHoursWhenIssuing = instead of issue we usually use checkout, but maybe ConsiderLibraryHoursInCirculation would be a good fit? b) We have Koha::Library::Hours.pm, but Koha::Schema::Results::BranchHour - why not use LibraryHour and also library_hours for the table name? c) Issuing should be 'checking out' in system preference description: Take library opening hours into consideration to calculate due date when issuing. 3) Database update The 2 separate database updates for adding the pref and the table could have been combined (not blocker). a) The code comments should be removed form the kohastructure.sql file. +/*!40101 SET @saved_cs_client = @@character_set_client */; +/*!40101 SET character_set_client = utf8 */; +/*!40101 SET character_set_client = @saved_cs_client */; 4) Translatability Our scripts always look for strings inside of HTML tags. Wrapping these in spans will make it much easier on translators and possibly allow to 'reuse' the existing translations for week days from other parts of Koha. +[% BLOCK dayname %] + [% IF day == 0 %] + Monday + [% ELSIF day == 1 %] + Tuesday + [% ELSIF day == 2 %] + Wednesday + [% ELSIF day == 3 %] + Thursday + [% ELSIF day == 4 %] + Friday + [% ELSIF day == 5 %] + Saturday + [% ELSE %] + Sunday + [% END %] +[% END %] 4) Library administration a) The opening and closing times should also appear in the 'summary' table of all libraries. (Don't forget to add to add to column configuration as well!) b) It should also be present in the library 'view' page, that is accessible if you don't have admin permissions. http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL c) TimeFormat is set to 24h format, but I still get presented with AM/PM on data entry. It also doesn't follow CalendarFirstDayOfWeek. I'd think the first would be more important. Maybe the curbside pickup GUI could give some ideas here as I think we did fix the TimeFormat issue there. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 23439] New: Barcode number with serveral users
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23439 Bug ID: 23439 Summary: Barcode number with serveral users Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: lmoisesrojas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Hello, everybody, When two or more users are trying to add a new item, the barcode field get the same numnber, so when they save the item and with have an error. This is happing since 19.05. Now only just one user can add item. Any help? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 23393] New: Add Requestor to PO when basket created via Quotes
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23393 Bug ID: 23393 Summary: Add Requestor to PO when basket created via Quotes Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: maura.stephens(a)gmit.ie QA Contact: testopia(a)bugs.koha-community.org When something comes in as a suggestion but we use Vendor Quotes, can the suggestion / requestor be linked with the PO#? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 23359] New: Problem with batch operations
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23359 Bug ID: 23359 Summary: Problem with batch operations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: vitorfernandes87(a)gmail.com Using ElasticSearch when you do a batch operation, like adding items or removing items, the record is reindexed every time that one item is changed (added or removed). Operations with this problem: - Add mutiple copies to one record - Remove all record items - Edit some or all record items Test plan 1: - Create a record - Add mutiple copies to that record (1000 for example) - Record will be at least reindexed 1000 times (one for each item) Test plan 2: - Create a record with mutiple copies (1000 for example) - Remove all items - Record will be at least reindexed 1000 times (one for each item) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 23244] New: Sort order in basket to default to title
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244 Bug ID: 23244 Summary: Sort order in basket to default to title Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul.thornton(a)educampus.ie QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 23182] New: Invoice does not completely print in Acq 18.11 Firefox
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23182 Bug ID: 23182 Summary: Invoice does not completely print in Acq 18.11 Firefox Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: bwsdonna(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- It appears that due to the addition of the "Adjustments" section on an invoice, the entire invoice will no longer print. Using the print function in Firefox, only the first six titles in an invoice print out, followed by a blank page 3. Chrome prints the entire invoice. Verified that in 18.05 Firefox prints the entire invoice. To test: create and invoice with more than six title.s . Using the browser print function in Firefox, note that only six titles and a blank page three print. View the same invoice in Chrome and notice that it prints as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 23155] New: Tidy up the status's
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23155 Bug ID: 23155 Summary: Tidy up the status's Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com Target Milestone: --- We've discussed this at a couple of dev meetings now, and I've raised it again to ensure a consensus at the next meeting.. It would be nice to clear up some of our superflous status's and clarify a few of those in use. My proposal was: * Add 'Pushed to oldstable' * Add 'Pushed to oldoldstable' * Remove 'Pushed for QA' * Remove 'Pushed by Module Maintainer' -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 23147] New: changes made by bug 20044 to addbiblio.pl causing issues for some catalogers
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23147 Bug ID: 23147 Summary: changes made by bug 20044 to addbiblio.pl causing issues for some catalogers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- some catalogers are frustrated by the UI changes brought about by Bug 20044. On smaller screen sizes the the page looks too cluttered and catalogers are unable to scan the information within this layout. A common complaint is subfield headings, and the duplicate/delete buttons are no longer in line with input fields. It is causing interruptions in workflow. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 23139] New: Koha::SharedContent->get_sharing_url is not used
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '23

08 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Bug ID: 23139 Summary: Koha::SharedContent->get_sharing_url is not used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Mana-kb Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com Target Milestone: --- The `get_sharing_url` method in Koha::SharedContent is currently only used in the unit tests. We should either convert code to use this routine or remove it. Personally, I think it could perhaps serve a similar use to shib_ok in C4::Auth_with_shibboleth in that we could add a cached config check (which would hit the Mana server to test it's actually there) and then return undef for failure or pass through the mana base url otherwise. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3