October 2023 - Koha-bugs - lists.koha-community.org

[Bug 12532] Copy guarantee email to guarantor (or redirect if guarantee has no email set)
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10498] Place a hold at time of ordering
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 34300 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #87 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- This is cached in L2 (memcached) but L1 will be populated (memory). So the retrieval of the syspref should be fast. But here we are talking about caching the split of a very short string, and we are in perl, I am not sure it makes a lot of sense. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34515] New: MARCXML output of OAI-PMH may be badly encoded (UNIMARC)
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Bug ID: 34515 Summary: MARCXML output of OAI-PMH may be badly encoded (UNIMARC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Like fixed for REST API, OAI-PMH output should be fixed to use metadata schema when building MARCXML. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 32336] New: MARCXML output of REST API may be badly encoded (UNIMARC)
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336 Bug ID: 32336 Summary: MARCXML output of REST API may be badly encoded (UNIMARC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: REST API Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com CC: tomascohen(a)gmail.com In Koha/REST/V1/Biblios.pm (methods get and get_public), MARC::Record::as_xml_record is called without a $format parameter, which means it relies on the package variable $MARC::File::XML::RecordFormat to be correctly set, which may or may not be the case depending on what the current starman/mojo worker has done before. We should pass the format explicitly to avoid problems. This is only a problem for UNIMARC, because $MARC::File::XML::RecordFormat defaults to 'USMARC'. -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #69 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- The attached patchset addresses the QA test tools and fixes the erroring test. I could not fix the POD and perltidy warnings about Koha/Schema/Result/Library.pm, Koha/Schema/Result/LibraryHour.pm, and Koha/Library/Hour.pm - any guidance on that would be appreciated. (In reply to Katrin Fischer from comment #59) > > 2) Terminology > > a) ConsiderLibraryHoursWhenIssuing = instead of issue we usually use > checkout, but maybe ConsiderLibraryHoursInCirculation would be a good fit? done > > b) We have Koha::Library::Hours.pm, but Koha::Schema::Results::BranchHour - > why not use LibraryHour and also library_hours for the table name? done > > c) Issuing should be 'checking out' in system preference description: > Take library opening hours into consideration to calculate due date when > issuing. changed to 'when circulating' to match the syspref name > > 3) Database update > > The 2 separate database updates for adding the pref and the table could have > been combined (not blocker). Done, QA tools complained about this too > > a) The code comments should be removed form the kohastructure.sql file. > > +/*!40101 SET @saved_cs_client = @@character_set_client */; > +/*!40101 SET character_set_client = utf8 */; > +/*!40101 SET character_set_client = @saved_cs_client */; done > > 4) Translatability > > Our scripts always look for strings inside of HTML tags. Wrapping these in > spans will make it much easier on translators and possibly allow to 'reuse' > the existing translations for week days from other parts of Koha. > > +[% BLOCK dayname %] > + [% IF day == 0 %] > + Monday > + [% ELSIF day == 1 %] > + Tuesday > + [% ELSIF day == 2 %] > + Wednesday > + [% ELSIF day == 3 %] > + Thursday > + [% ELSIF day == 4 %] > + Friday > + [% ELSIF day == 5 %] > + Saturday > + [% ELSE %] > + Sunday > + [% END %] > +[% END %] > done ... still WIP for the libraries summary page > > 5) Library administration > > b) It should also be present in the library 'view' page, that is accessible > if you don't have admin permissions. > http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL > Done > > a) The opening and closing times should also appear in the 'summary' table > of all libraries. (Don't forget to add to add to column configuration as > well!) > c) TimeFormat is set to 24h format, but I still get presented with AM/PM on > data entry. It also doesn't follow CalendarFirstDayOfWeek. I'd think the > first would be more important. Maybe the curbside pickup GUI could give some > ideas here as I think we did fix the TimeFormat issue there. These two requests have added a lot of complexity to this - adding new columns to an API generated table is not documented anywhere. I don't have capacity to work on this for a while, but maybe someone can build upon what I've done in the most recent patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #68 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 156780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156780&action=e… Bug 6796: [WIP] (follow-up) Displaying library hours This patch shows the set library hours on a library's view page. Still to be done: - show on the Libraries summary page - write tests - consider time format settings - fix translateability of day names in Libraries summary page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #67 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 156779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156779&action=e… Bug 6796: (follow-up) QA test tool fixes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153275|0 |1 is obsolete| | --- Comment #66 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 156778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156778&action=e… Bug 6796: Updated schema files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153280|0 |1 is obsolete| | --- Comment #65 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 156777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156777&action=e… Bug 6796: Don't add a day if hourly loan period pushes due date If ConsiderLibraryHoursWhenIssuing is set to shorten the loan period to the closing time, if the loan period initially pushes the due date to the following day, the day still gets added when calculating the due date. We simply need to hardcode the due time here as the due day is the same as the issue day. We only need to calculate a due date if ConsiderLibraryHoursWhenIssuing is set to extend the loan period to the next opening day, as we'll need to consider holidays/closed days. Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0