January 2024 - Koha-bugs - lists.koha-community.org

[Bug 35026] New: Refactor addorderiso2709.pl to use object methods
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Bug ID: 35026 Summary: Refactor addorderiso2709.pl to use object methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: matt.blenkinsop(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org As part of the process to be added in bug 34355, the addorderiso2709.pl script should be refactored to make use of object methods that can then be re-used in a cron script for bug 34355 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 141

[Bug 35518] New: Call to C4::Context->userenv happens before it's gets populated breaks code logic
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 Bug ID: 35518 Summary: Call to C4::Context->userenv happens before it's gets populated breaks code logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com, nugged(a)gmail.com Depends on: 17798 We getting results from `C4::Context->userenv` on line 72: my $userenv = C4::Context->userenv; but `C4::Context->userenv` gets populated only far below in `get_template_and_user` call, line 142, this means that everything that we getting further from `$userenv` is empty. And more, because autovivification occurs for the `$userenv` at line 73: my $branch = $userenv->{'branch'} // ''; that does not cause any visible errors, but it causes malfunctions at places where $branch, $desk_id is used, and also where $userenv is accessed, at line 153: if (!C4::Auth::haspermission( $userenv->{id} , { circulate => 'force_checkout' } ) ). To check that we have undef and it gets autovivificated, let's add some dumps into code when we open any borrower, e.g. /cgi-bin/koha/circ/circulation.pl?borrowernumber=19, Let's dump $userenv before and after `$branch = $userenv->{'branch'} // '';` line: 72 my $userenv = C4::Context->userenv; 73 use Data::Dumper; 74 warn __LINE__, ' ', Dumper($userenv); 75 my $branch = $userenv->{'branch'} // ''; 76 warn __LINE__, ' ', Dumper($userenv); this gives in server logs: 74 $VAR1 = undef; 76 $VAR1 = {}; and also to check when `C4::Context->userenv` gets its real values, let's dump before and after the `get_template_and_user()` call at line 142 (line 145 if to continue above dumps code): 145 warn __LINE__, ' ', Dumper([C4::Context->userenv]); 146 my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( ... 153 ); 154 warn __LINE__, ' ', Dumper([C4::Context->userenv]); this gives in server logs: 145 $VAR1 = []; 154 $VAR1 = [ { ... 'id' => 'admin', ... } ]; what depicts the whole bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 39

[Bug 34608] New: Add sort1 and sort2 to patron search results
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 Bug ID: 34608 Summary: Add sort1 and sort2 to patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Some libraries would like the option of showing columns for sort1 and sort2 to patron search results. -- You are receiving this mail because: You are watching all bug changes.

1 53

[Bug 22780] New: MarkLostItemsAsReturned - map to Lost-sttaus instead of context where the transaction took place
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22780 Bug ID: 22780 Summary: MarkLostItemsAsReturned - map to Lost-sttaus instead of context where the transaction took place Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: klas.blomberg(a)skovde.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- Syspref MarkLostItemsAsReturned is mapped to the context where you make the transaction - Holds to pull list, longoverdue cronjob et.c. I can't see any logical reason for this! I think it would be better to map to Lost-statuses: Lost = don't mark as returned Longoverdue = don't mark as returned Lost and paid for = mark as returned et.c. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 34346] New: Adding duplicate tag to a framework leads to error page, should give user readable error message
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34346 Bug ID: 34346 Summary: Adding duplicate tag to a framework leads to error page, should give user readable error message Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I tried adding a tag to the default framework and got a 500 error. It was because the tag already existed. Elsewhere in Koha, we get a user readable message saying something like "An error occurred when inserting this patron category. The patron category might already exist." To replicate: 1. In the staff interface, go to Administration > MARC bibliographic framework 2. Click the Actions button next to the default framework and choose MARC structure 3. Click New tag 4. Fill out the form to add an already existing tag number Tag: 699 Label for lib: Local subject Label for OPAC: Local subject 5. Click Save changes --> 500 error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 35792] New: Quiet warning: Use of uninitialized value $sub6
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35792 Bug ID: 35792 Summary: Quiet warning: Use of uninitialized value $sub6 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no When reindexing Elasticsearch, this warning can sometimes be seen: Use of uninitialized value $sub6 in pattern match (m//) at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch.pm line 601. This warning is from 23.05.06. In master it looks like the relevant line is now line 603. I think it could be silenced by changing the line from this: if ($sub6 =~ /^(...)-\d+/) { to this: if ($sub6 && $sub6 =~ /^(...)-\d+/) { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 35232] New: Misspelled ID breaks label on patron lists form
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35232 Bug ID: 35232 Summary: Misspelled ID breaks label on patron lists form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org - Go to Patron lists and add patrons to a list. - Click the "Add multiple patrons" link - Clicking the "Borrowernumbers" label doesn't trigger the corresponding radio button The input's id attribute is "add_by_borrwernumbers" instead of "add_by_borrowernumbers" -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 35238] New: Incorrect label markup in patron card creator printer profile edit form
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 Bug ID: 35238 Summary: Incorrect label markup in patron card creator printer profile edit form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy, accessibility Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Tools -> Patron card creator -> Edit printer profile: [% IF ( label_template ) %] <label for="template_name">Template name:</label> [% label_template | html %] [% ELSE %] <span class="label">Template name:</span> Profile unassigned [% END %] The label for "template_name" doesn't match any form field, so it should be a span with "label" class. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 35257] New: Only admin start page uses "circulation desks"
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Bug ID: 35257 Summary: Only admin start page uses "circulation desks" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In the sidebar and on the desk admin page, we only use "Desks". The administration start page seems to be the only place that uses the term "circulation desk". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 35239] New: Missing form field ids in batch patron modification template
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35239 Bug ID: 35239 Summary: Missing form field ids in batch patron modification template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy, accessibility Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Tools -> Batch patron modification -> Modifications (after submitting a batch of patrons): The edit form already has valid labels but not all the form fields have matching ids. There is also a markup error, a missing "=" in this tag: <input type"hidden" name="patron_attributes_value" /> -- You are receiving this mail because: You are watching all bug changes.

1 16