November 2024 - Koha-bugs - lists.koha-community.org

[Bug 36954] New: SIP server logging needs an overhaul...
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36954 Bug ID: 36954 Summary: SIP server logging needs an overhaul... Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org The log_file for the SIP server configuration needs some review I think. Obviously, Sys::Syslog isn't going to work in koha-testing-docker. However, lately, it seems like it doesn't work in production anymore either, although maybe that's configuration related. Here's how the SIP server is launched at the moment: kohadev+ 8622 1 0 02:45 ? 00:00:00 daemon --name=kohadev-koha-sip --errlog=/var/log/koha/kohadev/sip-error.log --stdout=/var/log/koha/kohadev/sip.log --output=/var/log/koha/kohadev/sip-output.log --verbose=1 --respawn --dela y=30 --pidfiles=/var/run/koha/kohadev --user=kohadev-koha.kohadev-koha -- perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml I'm not sure about these options... considering the following from the 'daemon(1)' manpage: -l, --errlog=spec - Send daemon's error output to syslog or file -b, --dbglog=spec - Send daemon's debug output to syslog or file -o, --output=spec - Send client's output to syslog or file -O, --stdout=spec - Send client's stdout to syslog or file -E, --stderr=spec - Send client's stderr to syslog or file If you look through the man page, it's pointless to output both "--stdout" and "--output", because "--output" is both stdout and stderr combined. So we are capturing the same error in different files. It seems that the "warn @_" in C4::SIP::Trapper is going out to the real STDERR. I don't know. It's a mess. C4::SIP::Trapper tries to take over STDERR but I'm not convinced it succeeds. As Nick points out in bug 36948, it seems like we're not capturing all the output we should be. Maybe that's because we're using Sys::Syslog in Docker, but I'm not convinced. Something is very weird in SIP logging town. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 34

[Bug 36833] New: Update German translations for new languages added
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36833 Bug ID: 36833 Summary: Update German translations for new languages added Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 33134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 [Bug 33134] Add some missing languages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 38307] New: Make overdue_notices.pl quiet if there are no branches with active overdue rules
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Bug ID: 38307 Summary: Make overdue_notices.pl quiet if there are no branches with active overdue rules Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 38227] New: Collapse authority popup search form when showing results
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Bug ID: 38227 Summary: Collapse authority popup search form when showing results Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 38221 I propose to convert the authority popup search form to a collapsible panel like we have on the patron entry form. It would be expanded when the popup is initially triggered but collapsed when displaying search results. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38221 [Bug 38221] Add Bootstrap styling to pagination in authority plugin search results -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 32890] New: Add DataTables to curbside pickups
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Bug ID: 32890 Summary: Add DataTables to curbside pickups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org This comes from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883#c2 I'm creating a new bug report as it was outside the scope of the other one. I suggested adding Datatables to the curbside pickup module, to be able to manage the ordering and the columns in table settings. - "To be staged" tab - "Staged & ready" tab - "Patron is outside" tab - "Delivered today" tab -- You are receiving this mail because: You are watching all bug changes.

1 28

[Bug 36585] New: Patrons with the most checkouts Report when outputting to csv doesn't have the total
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585 Bug ID: 36585 Summary: Patrons with the most checkouts Report when outputting to csv doesn't have the total Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: michael.hafen(a)washk12.org QA Contact: testopia(a)bugs.koha-community.org I will submit a patch which: Adds the total to csv output. Changes screen output to only show the patrons name once, instead of with each group by column. Also show total checkout when output to screen. Changes item type group by from biblioitems.itemtype to items.itype. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 18657] New: Inventory tool should display more
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18657 Bug ID: 18657 Summary: Inventory tool should display more Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Currently the tool reports: Incorrect not-for-loan values Wrong place Checked out We should have: Optional display of items w/o problems Display of missing/lost items now marked found -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 37111] New: OPAC renewal - CSRF "op must be set"
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37111 Bug ID: 37111 Summary: OPAC renewal - CSRF "op must be set" Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org In the OPAC, when a patron clicks the "renew" link for an item they get an error: op must be set at /kohadevbox/koha/opac/opac-renew.pl line 36 in (eval) at /kohadevbox/koha/opac/opac-renew.pl line 36 33: my $query = CGI->new; 34: my $op = $query->param('op') || q{}; 35: 36: die "op must be set" unless $op eq 'cud-renew'; ... To replicate (using KTD): 1. Check some items out to a patron 2. Set the username and apssword for the patron so that you can log in as that patron. 3. Log in to the OAPC as that patron. 4. Go to Your account > Summary (the default landing page after you log in). 5. Click "Renew" for one of the items. 6. You get the error as above. -- You are receiving this mail because: You are watching all bug changes.

1 40

[Bug 35984] New: automated static code analysis should include security tests
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35984 Bug ID: 35984 Summary: automated static code analysis should include security tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: evelyn(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org A few libraries have asked recently if, prior to production/during the development lifecycle, automated source code analysis tools are used to test for security flaws specifically. Typically these questions are in relation to processes like renewing cybersecurity insurance or initial discovery by a potential partner library's security/IT department. Perlcritic seems to be currently used, but as far as I can tell it appears the tests are for enforcing the coding standard. Using an automated tool to look for security flaws will be a beneficial addition to the project, so I'd like to at least start the discussion here. OWASP has an informational page for further reading: https://owasp.org/www-community/controls/Static_Code_Analysis -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 30594] New: Package Crypt::CBC 2.35 or higher to increase security
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '25

04 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30594 Bug ID: 30594 Summary: Package Crypt::CBC 2.35 or higher to increase security Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: mtj(a)kohaaloha.com Currently, Debian mostly comes with Crypt::CBC 2.33 pre-packaged. If we package 2.35 or above we can benefit from a performance boost as well as having the ability to update our derivation function to using the recommended pbkdf2 algorithm instead of the backwards compatible default of opensslv1. If we choose to package this, we should also update Koha::Encryption to reflect the change and use pbkdf2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5