February 2024 - Koha-bugs - lists.koha-community.org

[Bug 34542] New: Add tests for '.maincontent' presence to the QA tools
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34542 Bug ID: 34542 Summary: Add tests for '.maincontent' presence to the QA tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 22807 Blocks: 23003 We added the 'Skip to main content' feature in bug 22807. It relies heavily on the present of a .maincontent class being found on every OPAC page. We have a coding guidline around this, but to date I don't think we have a QA script test for it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 [Bug 22807] Accessibility: Add 'Skip to main content' link https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #124 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I don't believe this should be pushed without the follow-up bug worked on.. it is confusing to the end user as it stands without any meaningful link the the UI to closed days from the calendar. There is a proposal on how to achieve such a link at the data level such that such display and manipulation would be more future-proof and easy to implement in my opinion.. however the mere mention of that idea was immediately dismissed in chat so I'm stepping away again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36079 [Bug 36079] Library hours and the Calendar are not linked in any meaningful ways -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #123 from Ray Delahunty <r.delahunty(a)arts.ac.uk> --- I see the status is Passed QA but I'd love to see the changes this bugfix offers... in action. Is a test plan possible so a signoff can be tried in a sandbox? I note the test plan in Comment 109 has 'Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services'. I don't see an 'Update database' as an Action. I see Apply patches, Refresh schema and Restart services. Is this one not appropriate for a newbie Signoff-er? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #122 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- OK.. I think this is 'good enough' at this point. There are follow-ups I'd like to see so I'm going to post bugs for them and link them to here.. but I think the basic feature all works and this is a long long overdue piece of work. We have a foundation to build upon now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #121 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162104&action=e… Bug 6796: Code defensively for if library hours are not set Sponsored-by: PTFS Europe Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162056|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162103&action=e… Bug 6796: day_of_week representation fix The code here was flawed, DateTime returns a 1-7 indexed array with the first day being Monday, Koha expects an 0-6 indexed array with the first day being Sunday. Sponsored-by: PTFS Europe Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '24

13 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162055|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 162102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162102&action=e… Bug 6796: Merge and correct database update Sponsored-by: PTFS Europe Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0