April 2024 - Koha-bugs - lists.koha-community.org

[Bug 5920] Optionally remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '24

30 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5920] Optionally remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '24

30 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #32 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 165834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165834&action=e… Bug 5920: (QA follow-up) Switch to use existing dependancy We already have a scrubber module we can use; This patch switches us from the newly introduced dependancy to using the existing and well respected Scrubber we already have. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5920] Optionally remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '24

30 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165690|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 165833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165833&action=e… Bug 5920: Add HTML::Restrict to cpanfile Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5920] Optionally remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '24

30 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165689|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 165832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165832&action=e… Bug 5920: Strip HTML from report exports This patch uses HTML::Restrict to strip out HTML tags from the CSV download of reports. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5920] Optionally remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '24

30 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #29 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Good call on HTML::Scrubber.. I jsut rebased the existing patches and modernised it a bit, but I should have spotted the overlap. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31656] New: Expand TT access for CHECKOUT notice
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '24

29 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31656 Bug ID: 31656 Summary: Expand TT access for CHECKOUT notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org The FOREACH loop TT syntax doesn't work in the CHECKOUT notice. I suspect this is due to it being generated in C4/Circulation.pm, as described here https://wiki.koha-community.org/wiki/Customising_Notices_and_Slips#Notice_S… You can only use four dashes to repeat information in this notice. To test: 1. Edit the CHECKOUT notice 1.1. Go to Tools > Notices and slips 1.2. Search for the CHECKOUT notice and click Edit 1.3. In the Email tab, use the following code for the letter (should be the one by default) The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 1.4. Save 2. In a patron file, choose to get the Item checkout email notice 2.1. Go to a patron file 2.2. Click on the Edit button next to the patron messaging preferences table 2.3. Check Email for the Item checkout 2.4. Save 3. Check out items to the same patron 3.1. Go to the Check out tab in the patron file 3.2. Check out at least two items 4. Check the generated notice 4.1. Go to the Notices tab in the patron file 4.2. Click on the Checkouts notice to view the contents --> It should show both titles 5. Change the CHECKOUT notice, redo steps 1.x using the following letter content The following items have been checked out: [% FOREACH checkout IN checkouts %] [%~ SET item = checkout.item %] [%~ SET biblio = checkout.item.biblio %] [% biblio.title %] [% END %] Thank you for visiting [% branch.branchname %]. 6. Try checking out again, redo steps 2-4 with a different patron --> There are no titles and the letter is repeated twice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 15461] Add staff equivalent for OpacLocationOnDetail
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '24

29 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #20 from Lucas Gass <lucas(a)bywatersolutions.com> --- rebased for current main, returning status to NQA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15461] Add staff equivalent for OpacLocationOnDetail
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '24

29 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #19 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 165806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165806&action=e… Bug 15461: Perl tidy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15461] Add staff equivalent for OpacLocationOnDetail
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '24

29 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162990|0 |1 is obsolete| | Attachment #162991|0 |1 is obsolete| | Attachment #162992|0 |1 is obsolete| | Attachment #162993|0 |1 is obsolete| | Attachment #165804|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 165805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165805&action=e… Bug 15461: Add StaffLocationOnDetail system preference To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15461] Add staff equivalent for OpacLocationOnDetail
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '24

29 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #17 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 165804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165804&action=e… Bug 15461: Add StaffLocationOnDetail -- You are receiving this mail because: You are watching all bug changes.

1 0