May 2024 - Koha-bugs - lists.koha-community.org

[Bug 35518] New: Call to C4::Context->userenv happens before it's gets populated breaks code logic
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 Bug ID: 35518 Summary: Call to C4::Context->userenv happens before it's gets populated breaks code logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com, nugged(a)gmail.com Depends on: 17798 We getting results from `C4::Context->userenv` on line 72: my $userenv = C4::Context->userenv; but `C4::Context->userenv` gets populated only far below in `get_template_and_user` call, line 142, this means that everything that we getting further from `$userenv` is empty. And more, because autovivification occurs for the `$userenv` at line 73: my $branch = $userenv->{'branch'} // ''; that does not cause any visible errors, but it causes malfunctions at places where $branch, $desk_id is used, and also where $userenv is accessed, at line 153: if (!C4::Auth::haspermission( $userenv->{id} , { circulate => 'force_checkout' } ) ). To check that we have undef and it gets autovivificated, let's add some dumps into code when we open any borrower, e.g. /cgi-bin/koha/circ/circulation.pl?borrowernumber=19, Let's dump $userenv before and after `$branch = $userenv->{'branch'} // '';` line: 72 my $userenv = C4::Context->userenv; 73 use Data::Dumper; 74 warn __LINE__, ' ', Dumper($userenv); 75 my $branch = $userenv->{'branch'} // ''; 76 warn __LINE__, ' ', Dumper($userenv); this gives in server logs: 74 $VAR1 = undef; 76 $VAR1 = {}; and also to check when `C4::Context->userenv` gets its real values, let's dump before and after the `get_template_and_user()` call at line 142 (line 145 if to continue above dumps code): 145 warn __LINE__, ' ', Dumper([C4::Context->userenv]); 146 my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( ... 153 ); 154 warn __LINE__, ' ', Dumper([C4::Context->userenv]); this gives in server logs: 145 $VAR1 = []; 154 $VAR1 = [ { ... 'id' => 'admin', ... } ]; what depicts the whole bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 39

[Bug 36832] New: Adding authority records is broken
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36832 Bug ID: 36832 Summary: Adding authority records is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: RM_priority Severity: blocker Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org We get a 404 after opening a blank authority record and using Z39.50 to try to import a record and after manually filling out the form and submitting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 36838] New: Can't approve or reject tags in the staff interface
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36838 Bug ID: 36838 Summary: Can't approve or reject tags in the staff interface Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: RM_priority Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 34478 The AJAX-driven operations on the tags review page are not working following the CSRF work. The console shows a 403 error and the logs show "No CSRF token passed for POST" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 36995] New: Can't delete Library EAN
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36995 Bug ID: 36995 Summary: Can't delete Library EAN Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Acquisitions Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 34478 The CSRF update added the "cud-" prefix where it should not have. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 36877] New: Patron card creator does not work when editing layout, profile or template
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36877 Bug ID: 36877 Summary: Patron card creator does not work when editing layout, profile or template Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: bibliothek(a)th-wildau.de QA Contact: testopia(a)bugs.koha-community.org 1. When trying to edit a layout in patron card creator the following error is thrown on the website: WARNING: An unsupported operation was attempted on layout 20. Please have your system administrator check the error log for details. The log says: [WARN] Unsupported operation type submitted: edit at /kohadevbox/koha/patroncards/edit-layout.pl line 271. To reproduce: a) go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout b) click on edit 'Test Layout' c) the above warning shows up 2. When trying to edit a template it shows an empty 'New patron card template' form 3. When trying to edit a profile it shows an empty 'New printer profile' form I think this is somehow related to Bug 34478 as all 3 scripts check for an operation $op eq 'cud-edit' but the query param is just 'edit' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 36883] New: Can't finish club enrollment in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36883 Bug ID: 36883 Summary: Can't finish club enrollment in the OPAC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 34478 When I try to enroll in a club via the OPAC the "Finish enrollment" stage doesn't work--there's a 403 error: [WARN] Programming error - No CSRF token passed for POST http://localhost:8080/opac/svc/club/enroll (referer: http://localhost:8080/cgi-bin/koha/opac-user.pl) at /kohadevbox/koha/Koha/Middleware/CSRF.pm line 82. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 36630] New: Item search batch operations buttons broken by CRSF
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36630 Bug ID: 36630 Summary: Item search batch operations buttons broken by CRSF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: blawlor(a)clamsnet.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Since Bug 34478 Full CSRF protection some POST requests return 403 with an error and need to be ajusted. On the Item search results page, the Batch operations buttons are broken and need to be changed to GET. To recreate: 1. Do an item search 2. On the results page 'click Select visible rows' 3. Click 'Batch operations' and select 'Batch item modification' 4. See Programming error - op 'show' must start with 'cud-' for POST http://localhost:8081/intranet/tools/batchMod.pl (referer: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl) 5. Click 'Batch operations' and select 'Batch item deletion' 6. See the same error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 36384] New: 'Used saved' typo in guided reports
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36384 Bug ID: 36384 Summary: 'Used saved' typo in guided reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 36568] New: Changing rows per page on a custom report is broken
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568 Bug ID: 36568 Summary: Changing rows per page on a custom report is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: emily.lamancusa(a)montgomerycountymd.gov Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org Depends on: 34478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 36336] New: Exporting records from detail page is broken
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36336 Bug ID: 36336 Summary: Exporting records from detail page is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When exporting a record from the detail page in the staff interface, almost all formats give an Error 500 - Internal server error. But with tail -f /var/log/koha/kohadev/*.log there doesn't seem to be anything in the logs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15