September 2024 - Koha-bugs - lists.koha-community.org

[Bug 37426] New: DBIC schema file Category.pm manually modified causing checksum mismatch and blocking refresh of that file
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37426 Bug ID: 37426 Summary: DBIC schema file Category.pm manually modified causing checksum mismatch and blocking refresh of that file Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor(a)tuxayo.net QA Contact: testopia(a)bugs.koha-community.org dbic complains at the end of the refresh: DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in './/Koha/Schema/Result/Category.pm', the auto-generated part of the file has been modified outside of this loader. Aborting. If you want to overwrite these modifications, set the 'overwrite_modifications' loader option. It seems to come from commit "Bug 28924: Add DBIC file" Which has changes in the autogenerated section but not in the footer of that section having the checksum. Hence causing the mismatch when running `dbic` It might have been a conflict where the resolution accidentally dropped the checksum changes. Because the rest of the changes look indeed autogenerated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 19876] New: Koha::Account->pay() does not exit specific fine loop when balance is used up
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Bug ID: 19876 Summary: Koha::Account->pay() does not exit specific fine loop when balance is used up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If a patron selects specific fines to pay and enters an amount less than all of those fines the loop will continue through all fines. This can be problematic for lost fines which are not paid or not paid fully as they will be marked 'Paid for...' and returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 17138] New: UpdateFine() modyfies existing fine records even when there is no need
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 Bug ID: 17138 Summary: UpdateFine() modyfies existing fine records even when there is no need Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In C4/Overdues.pm: 574: # we're updating an existing fine. Only modify if amount changed 577: if ( $data->{'amount'} != $amount ) { for some numbers (e.g. 5.60) the comparison in line 577 fails ($data->{'amount'} is decimal(28,6) i.e. a string, and $amount may be a floating point number with no exact binary representation). E.g. when the fine amounts are multiple of 0.20, it fails for the 33.3% of the amounts (on average). Depending on the fine charging settings, this may trigger unnecessary database writes (and a lot of them). If 'Fine Charging Interval' is 1 day, this has very little practical consequences (misc/cronjobs/fines.pl script is usually run once per day, and all fines need an increase anyway). But if the charging interval is longer, e.g. 7 days, in a given day amount changes only for the 1/7 of the fines (again, on average), and over 60% of the database writes would be redundant. To reproduce: 1) run misc/cronjobs/fines.pl 2) add warn "AMOUNT ".$data->{'amount'}." vs $amount"; below line 577 in C4/Overdues.pm 3) run misc/cronjobs/fines.pl again 4) you'll see some warnings like 'AMOUNT 5.600000 vs 5.6' or: dump accountlines table after step 1), run the script 2nd time, dump the table again and compare the contents - some of the records would have a different timestamp. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 38

[Bug 26662] New: Authority linking doesn't work with custom authority type
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26662 Bug ID: 26662 Summary: Authority linking doesn't work with custom authority type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org If you're using custom authority types, automatic linking via C4::Biblio::LinkBibHeadingsToAuthorities will never work. It's because C4::Heading::MARC21 has a hard-coded mapping of bib fields to authority types (instead of consulting the MARC bibliographic framework). This means if you're using "CORPO_NAME_AWSEOME" instead of "CORPO_NAME" for your authorities, you'll never get an automated match, since C4::Heading::_search (used ultimately by C4::Linker::Default) uses the hard-coded auth_type from C4::Heading::MARC21. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 37913] New: Remove more unreachable code in aqcontract.tt
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37913 Bug ID: 37913 Summary: Remove more unreachable code in aqcontract.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Acquisitions Assignee: phil(a)chetcolibrary.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 37728 Bug 37823 removes one set of unreachable code from aqcontract.tt, a block that tried to tell you that you had created a new contract rather than just showing you the new contract, but there is another: When you delete a contract, what actually happens is that you are shown the details page for the vendor, which lists the contracts for that vendor at the bottom, thus showing you that the contract has been deleted, but the template has a block which thinks it is going to tell you "<h1>Contract deleted</h1>" and then have you click an OK button to POST a form with no op param starting with cud-, which now fails the CSRF protection. Luckily, it's unreachable (and has been since aqcontract.pl first landed, it has always redirected after deleting, and has never shown that block), but having it there still fails a test once bug 37728 lands and lets the test see it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 [Bug 37728] More "op" are missing in POSTed forms -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 30122] New: Display note fields in authority result list
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30122 Bug ID: 30122 Summary: Display note fields in authority result list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 35328] New: Add a notes pop-up for authority records to authority search results
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328 Bug ID: 35328 Summary: Add a notes pop-up for authority records to authority search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 22403] New: Temporary Card
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22403 Bug ID: 22403 Summary: Temporary Card Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- We are CONSTANTLY having to write out patron card numbers on post-its for patrons that forgot their library cards. It would be great if there were an option under the print options on the patron page to print a temporary card. It could print the barcode and number, and maybe have an optional customizable message. Even better, since patrons are prone to leave these lying around, maybe it prints a temporary number that ISN'T their card number, but it is a temporary secondary number linked to their account that expires in X amount of hours. We could hand that out to them, providing of course they provide a photo id to prove who they are. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 37790] New: Prevent indexing and holds queue updates when running update_localuse_from_statistics.pl
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37790 Bug ID: 37790 Summary: Prevent indexing and holds queue updates when running update_localuse_from_statistics.pl Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz The maintenance script touches all items to update the localuse from the statistics table. This will not affect holdability of items, nor it is mapped in the search engine by default. To avoid spawning large numbers of background jobs we should skip these options when storing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 38020] New: Fix 'delete list' button to have same formatting as 'edit list'
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '24

18 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Bug ID: 38020 Summary: Fix 'delete list' button to have same formatting as 'edit list' Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In the staff interface, the edit and delete list buttons in the 'edit' dropdown look different. To recreate: 1. Create a list in the staff interface 2. Go to lists 3. View the list 4. Click the Edit dropdown 5. Notice the two dropdown options for Edit list and Delete list have different formatting and look different -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29